July 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: fix bad layout in import vm dialog
by ahadas＠redhat.com 08 Jul '15

08 Jul '15

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: fix bad layout in import vm dialog ...................................................................... webadmin: fix bad layout in import vm dialog The widgets in the upper section of the import VM dialog were not placed correctly because their width was not set. So this patch sets a style that contains the right width to them. Change-Id: I3145477814d5e948a2b6fb16982257251f6b9c19 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/43218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3145477814d5e948a2b6fb16982257251f6b9c19 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.5]: packaging: setup: add Unkown Task to Async Task Map
by piotr.kliczewski＠gmail.com 08 Jul '15

08 Jul '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: add Unkown Task to Async Task Map ...................................................................... packaging: setup: add Unkown Task to Async Task Map Added missing Unknown Task to Async Task Map. Change-Id: I495a092ce93c8b0f52476a76c739f294f41f8cb4 Bug-Url: https://bugzilla.redhat.com/1238795 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit d380f30b03a6d40a0af22905e9a86efe758c9d1a) --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/async_tasks_map.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43305 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I495a092ce93c8b0f52476a76c739f294f41f8cb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: bulk user query for VMConsoleProxyServlet
by ofrenkel＠redhat.com 08 Jul '15

08 Jul '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: bulk user query for VMConsoleProxyServlet ...................................................................... core: bulk user query for VMConsoleProxyServlet Add bulk queries for UserProfiles, avoiding queries in the inner loop. Change-Id: Ic58b0e92ee416fb43661910632970055d3c23e8d Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UserProfile.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UserProfileDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/UserProfileDaoTest.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/user_profiles_sp.sql 6 files changed, 30 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic58b0e92ee416fb43661910632970055d3c23e8d Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: packaging: setup: add Unkown Task to Async Task Map
by sbonazzo＠redhat.com 08 Jul '15

08 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: add Unkown Task to Async Task Map ...................................................................... packaging: setup: add Unkown Task to Async Task Map Added missing Unknown Task to Async Task Map. Change-Id: I495a092ce93c8b0f52476a76c739f294f41f8cb4 Bug-Url: https://bugzilla.redhat.com/1238795 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/async_tasks_map.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43301 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I495a092ce93c8b0f52476a76c739f294f41f8cb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: ovirt-hosted-engine: drop fc21 builds
by sbonazzo＠redhat.com 08 Jul '15

08 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-hosted-engine: drop fc21 builds ...................................................................... ovirt-hosted-engine: drop fc21 builds ovirt-hosted-engine-setup now requires subpackages from ovirt-engine which is not built for fc21. Change-Id: Iea02dc196228429c3619cff43c1ec0411779bd87 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/yaml/builders/copy-create-job-artifact.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup_create-rpms.yaml M jobs/confs/yaml/jobs/ovirt/publish-rpms-nightly-master.yaml 4 files changed, 9 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/43303 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea02dc196228429c3619cff43c1ec0411779bd87 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: enable Cinder integration feature
by derez＠redhat.com 08 Jul '15

08 Jul '15

Daniel Erez has submitted this change and it was merged. Change subject: core: enable Cinder integration feature ...................................................................... core: enable Cinder integration feature Update the default value of 'CinderProviderSupported' ConfigValue to "true". Change-Id: If2db1472169e049cc97e202dc31eb3fb5689ee30 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2db1472169e049cc97e202dc31eb3fb5689ee30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: uutils: CertificateChain: use trust manager to collect certi...
by masayag＠redhat.com 07 Jul '15

07 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: uutils: CertificateChain: use trust manager to collect certificate chain ...................................................................... uutils: CertificateChain: use trust manager to collect certificate chain handshake may fail for various of reasons, for example client certificate is required. collect peer certificate from server hello message which triggers the trust manager. Change-Id: Ief5896020d88aff20ce48924deb72c5306fbe328 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/crypto/CertificateChain.java 1 file changed, 19 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43292 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief5896020d88aff20ce48924deb72c5306fbe328 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine-config : add Double type support
by masayag＠redhat.com 07 Jul '15

07 Jul '15

Moti Asayag has submitted this change and it was merged. Change subject: engine-config : add Double type support ...................................................................... engine-config : add Double type support Added support for Double type Example: Adding ElimDoubleTest engine-config.properties --------------------------- ElimDoubleTest.type=Double ElimDoubleTest.description=Test Double values ConfigValues: --------------------------- @TypeConverterAttribute(Double.class) @DefaultValueAttribute("1.1") ElimDoubleTest, I also added the code for installing this value in 0000_config.sql and called Double d = Config.getValue("ElimDoubleTest"); But all the above was only for testing, the new helper class is the only code added since all code uses either Generics or dynamic load of the helper. Change-Id: I0608da138b57c9b571e082eba2e5991b95ede01f Signed-off-by: emesika <emesika(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/DoubleValueHelper.java 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0608da138b57c9b571e082eba2e5991b95ede01f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Verify iSCSI username and password length
by sbonazzo＠redhat.com 07 Jul '15

07 Jul '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Verify iSCSI username and password length ...................................................................... packaging: setup: Verify iSCSI username and password length Verify that iSCSI username length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_USERNAME_LENGTH (Currently set to 50 characters). Also verify that iSCSI password length is equal or less to the ovirt_hosted_engine_setup.constants.Const.MAX_STORAGE_PASSWORD_LENGTH (Currently also set to 50 characters). Please note that the values of these constants must be synced with the values defined in user_name and password fields of the storage_server_connections table. (These tables are defined in packaging/dbscripts/create_tables.sql). Note: this patch requires https://gerrit.ovirt.org/#/c/42851/ patch ('store' param support in queryEnvKey) in order to function properly. Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1210763 --- M ovirt-hosted-engine-setup.spec.in M src/bin/ovirt-hosted-engine-setup.env M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/storage/blockd.py 4 files changed, 60 insertions(+), 30 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/42596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74ba0a296b5c488dbf31c656f4c67fb7c79cc52e Gerrit-PatchSet: 17 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: gluster: ignore a problematic test
by emesika＠redhat.com 07 Jul '15

07 Jul '15

Eli Mesika has submitted this change and it was merged. Change subject: gluster: ignore a problematic test ...................................................................... gluster: ignore a problematic test This test does not pass CI tests from time to time and is unstable. Error generated by CI : 09:57:42 Failed tests: 09:57:42 testSaveDetails(org.ovirt.engine.core.dao.gluster.GlusterGeoRepDaoTest): expected:<org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSessionDetails@d01db74c> but was:<org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSessionDetails@8654f94c> 09:57:42 This patch ignores this test until it is fixed Change-Id: I411c67ff0109676dc118300f2dbbb75541739de5 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterGeoRepDaoTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Passed CI tests Moti Asayag: Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/43264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I411c67ff0109676dc118300f2dbbb75541739de5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0