August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: cleanup: Fix naming in Model
by tjelinek＠redhat.com 24 Aug '15

24 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: cleanup: Fix naming in Model ...................................................................... frontend: cleanup: Fix naming in Model Removed 'private' field prefixes and removed redundant set/gethash. Change-Id: I4872cb4a63a41a7d47b6e295f6e85a10c67e26d0 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 28 insertions(+), 36 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4872cb4a63a41a7d47b6e295f6e85a10c67e26d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, webadmin: Fix of overriding CtrlAltEnd ConfigValue by ...
by tjelinek＠redhat.com 24 Aug '15

24 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: core, webadmin: Fix of overriding CtrlAltEnd ConfigValue by frontend ...................................................................... core, webadmin: Fix of overriding CtrlAltEnd ConfigValue by frontend Remaping of shortcut Ctrl-Alt-Del -> Ctrl-Alt-End is controled by ConfigValues#RemapCtrlAltDelDefault and frontend Console Options dialog that takes precedence. There was a bug that causes that only ConfigValue was taken into account. Change-Id: Ie6c166cd9882f6e857029fff8d30c5416ac3bdcf Bug-Url: https://bugzilla.redhat.com/1184445 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 3 files changed, 56 insertions(+), 12 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6c166cd9882f6e857029fff8d30c5416ac3bdcf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: List upgrade host failure statuses in message
by masayag＠redhat.com 24 Aug '15

24 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: core: List upgrade host failure statuses in message ...................................................................... core: List upgrade host failure statuses in message Change-Id: If6802e6975e337b9268d6722d320f0f3c7e42ed7 Bug-Url: https://bugzilla.redhat.com/1253362 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 10 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/44997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6802e6975e337b9268d6722d320f0f3c7e42ed7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core, restapi: Avoid NPE when there are no provider certific...
by juan.hernandez＠redhat.com 24 Aug '15

24 Aug '15

Juan Hernandez has submitted this change and it was merged. Change subject: core, restapi: Avoid NPE when there are no provider certificates ...................................................................... core, restapi: Avoid NPE when there are no provider certificates Currently the backend and the RESTAPI generate a NPE when there are no certificates available for a provider, for example if it is using HTTP instead of HTTPS. The backend generates a log error and then returns null as the result of the query. The RESTAPI takes this and assumes that it is a list, thus generating the NPE. This patch changes the backend so that it returns an empty list in this case and the RESTAPI so that it tolerates null. The result of trying to import certificates after the patch will be the error message generated by the backend: <fault> <reason>Operation Failed</reason> <detail>[Failed to import provider certificate.]</detail> </fault> Change-Id: Ie3617dffe56fef88c9267a5471fe41a7ab294254 Bug-Url: https://bugzilla.redhat.com/1255848 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetProviderCertificateChainQuery.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendExternalProviderResource.java 2 files changed, 13 insertions(+), 8 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Alexander Wels: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3617dffe56fef88c9267a5471fe41a7ab294254 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Extend size converter
by sabose＠redhat.com 24 Aug '15

24 Aug '15

Sahina Bose has submitted this change and it was merged. Change subject: engine: Extend size converter ...................................................................... engine: Extend size converter This patch extends size converter to support units upto Yobibyte. Change-Id: I19311ff7a0590b85d2466cb5e4b76b67080f66ed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1250024 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests anmolbabu: Verified Sahina Bose: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44403 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19311ff7a0590b85d2466cb5e4b76b67080f66ed Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: use commons-configuration.version in bll/pom.xml
by masayag＠redhat.com 23 Aug '15

23 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: core: use commons-configuration.version in bll/pom.xml ...................................................................... core: use commons-configuration.version in bll/pom.xml Use commons-configuration.version property (defined in main pom.xml) in bll/pom.xml instead of duplicating the value. Change-Id: I592d385bb4eb68871a294bfa51ec4bac29ceafea Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I592d385bb4eb68871a294bfa51ec4bac29ceafea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fix Coverity and other warnings
by masayag＠redhat.com 23 Aug '15

23 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: core: fix Coverity and other warnings ...................................................................... core: fix Coverity and other warnings Fix the following Coverity and other warnings: * CID 1317259 * CID 1317261 * Add @Tests annoutation to managementNetworkChangedCorrectlyWithIpHostname method * Suppress warnings for deprecation of SetupNetworksParameters * Suppress warnings for unchecked assignment where that cann't be fixed Change-Id: I89a389d1951018deacef394879c797d74be44ae1 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 1 file changed, 28 insertions(+), 41 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/45224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a389d1951018deacef394879c797d74be44ae1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add validation on provider remove.
by tnisan＠redhat.com 23 Aug '15

23 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Add validation on provider remove. ...................................................................... core: Add validation on provider remove. Add validation when removing a Cinder provider. Change-Id: Ia1b2ca36b15abfd9895d0ffc2f3e04c988afa599 Bug-Url: https://bugzilla.redhat.com/1255252 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java 3 files changed, 64 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1b2ca36b15abfd9895d0ffc2f3e04c988afa599 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Add validation on provider remove.
by mlipchuk＠redhat.com 23 Aug '15

23 Aug '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add validation on provider remove. ...................................................................... core: Add validation on provider remove. Add validation when removing a Cinder provider. Change-Id: Ia1b2ca36b15abfd9895d0ffc2f3e04c988afa599 Bug-Url: https://bugzilla.redhat.com/1255252 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java 3 files changed, 64 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/45214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1b2ca36b15abfd9895d0ffc2f3e04c988afa599 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: send guest cpus in numa node, not host cpus
by tnisan＠redhat.com 23 Aug '15

23 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: send guest cpus in numa node, not host cpus ...................................................................... core: send guest cpus in numa node, not host cpus currently the default vm numa node list the host numa cpu ids. this is wrong and it should specify the guest cpu ids. Change-Id: I48e08f45d2fe6fc417d2deb813ae67bbc11ea484 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1254560 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> (cherry picked from commit cd6156d28146e47e6f6ecf7f9135b5e3fc40f1ec) --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Omer Frenkel: Verified -- To view, visit https://gerrit.ovirt.org/45225 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48e08f45d2fe6fc417d2deb813ae67bbc11ea484 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0