August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Host Hardware hba device layout
by awels＠redhat.com 24 Aug '15

24 Aug '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Host Hardware hba device layout ...................................................................... webadmin: Host Hardware hba device layout - Due to the FormPanel layout changes the HBA panels were not getting enough space. This patch fixes that. Change-Id: I67a76196640b22c81002eaf8f446d270ef67aa7c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252018 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralHardwareView.ui.xml 2 files changed, 22 insertions(+), 17 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67a76196640b22c81002eaf8f446d270ef67aa7c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: Added scrollbar to "NUMA Topology" popup
by derez＠redhat.com 24 Aug '15

24 Aug '15

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Added scrollbar to "NUMA Topology" popup ...................................................................... webadmin: Added scrollbar to "NUMA Topology" popup In the "NUMA Topology" window, when the host had more than two NUMA nodes, they couldn't be reached. Therefore, a scroll-bar was added to the NUMA node panel. Change-Id: I594ce5be24240fa9d9218ea2ff46bc9e44ca8352 Bug-Url: https://bugzilla.redhat.com/1226865 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.ui.xml 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/45226 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594ce5be24240fa9d9218ea2ff46bc9e44ca8352 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: doc: README.developer: more jmx cleanups
by masayag＠redhat.com 24 Aug '15

24 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: doc: README.developer: more jmx cleanups ...................................................................... doc: README.developer: more jmx cleanups Change-Id: Icd3357ece3e1cd0e09ee6a073695e736d538741f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Moti Asayag: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd3357ece3e1cd0e09ee6a073695e736d538741f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: refactored QoSMapper
by tjelinek＠redhat.com 24 Aug '15

24 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: refactored QoSMapper ...................................................................... restapi: refactored QoSMapper • overgrown methods • fallback through cases • ignored unsupported enum values Change-Id: I1a2a6af65c5149bd67e5b6306e57aa0f5a4828b5 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java 1 file changed, 139 insertions(+), 103 deletions(-) Approvals: Ori Liel: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/43981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a2a6af65c5149bd67e5b6306e57aa0f5a4828b5 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: refactored out updateActionTypeForQosType method
by tjelinek＠redhat.com 24 Aug '15

24 Aug '15

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: refactored out updateActionTypeForQosType method ...................................................................... restapi: refactored out updateActionTypeForQosType method • this code does not belong into update/add method (also making it overgrown) • not initializating 'updateActionType' variable causes NPE much later in process without sensible explanation. Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQosResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java 4 files changed, 105 insertions(+), 48 deletions(-) Approvals: Ori Liel: Looks good to me, approved Martin Mucha: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/41468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic16d1488a932b49a4fedea3247c2e00cf06f6c5c Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Don't fire event if certification weren't retrieved
by oourfali＠redhat.com 24 Aug '15

24 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Don't fire event if certification weren't retrieved ...................................................................... core: Don't fire event if certification weren't retrieved Reporting 'Failure to retrieve certificates' as an event log should be skipped to reduce confusion. If there are not certificates, there is probably communication issue with the host, and logging it as an error to the log should be sufficient. Change-Id: I4744ede410ca89ee12a153e43136652ed04dae3e Bug-Url: https://bugzilla.redhat.com/1253510 Signed-off-by: Moti Asayag <masayag(a)redhat.com> (cherry picked from commit 7b2daec6f635f4e9a560ae162168c1ff62488bbc) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4744ede410ca89ee12a153e43136652ed04dae3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix, retrieve dedicatedHostList on new VmNumaNode resu...
by tnisan＠redhat.com 24 Aug '15

24 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE ...................................................................... core: Fix, retrieve dedicatedHostList on new VmNumaNode result NPE The dedicatedHostList is passed to VmNumaNodeCommand in parameters. Retrieving the VM from parent command result in NPE. getVm() returns null, because it query on vms view. The VM is not registered in vms view until it saves its vm_statistics record and vm_dynamic record as well. The best practice is to pass and read parameters. This bug broke the REST api as well. Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf Bug-Url: http://bugzilla.redhat.com/1254665 Signed-off-by: Dudi Maroshi <dudi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dudi Maroshi: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b63a76d9b7e40077dd39605d3aabb0a54b82dcf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Don't fire event if certification weren't retrieved
by oourfali＠redhat.com 24 Aug '15

24 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Don't fire event if certification weren't retrieved ...................................................................... core: Don't fire event if certification weren't retrieved Reporting 'Failure to retrieve certificates' as an event log should be skipped to reduce confusion. If there are not certificates, there is probably communication issue with the host, and logging it as an error to the log should be sufficient. Change-Id: I4744ede410ca89ee12a153e43136652ed04dae3e Bug-Url: https://bugzilla.redhat.com/1253510 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CertificationValidityChecker.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4744ede410ca89ee12a153e43136652ed04dae3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add warning to low disk space message
by oourfali＠redhat.com 24 Aug '15

24 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add warning to low disk space message ...................................................................... core: Add warning to low disk space message Change-Id: Ib3ab958f1a7299e519517bf44d4efc7e64d1a0b4 Bug-Url: https://bugzilla.redhat.com/1123613 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45248 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ab958f1a7299e519517bf44d4efc7e64d1a0b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add warning to low disk space message
by oourfali＠redhat.com 24 Aug '15

24 Aug '15

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add warning to low disk space message ...................................................................... core: Add warning to low disk space message Change-Id: Ib3ab958f1a7299e519517bf44d4efc7e64d1a0b4 Bug-Url: https://bugzilla.redhat.com/1123613 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Oved Ourfali: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/45017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3ab958f1a7299e519517bf44d4efc7e64d1a0b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0