August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: engine: Check if pvsize is not empty-GetDeviceList
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Check if pvsize is not empty-GetDeviceList ...................................................................... engine: Check if pvsize is not empty-GetDeviceList In the GetDeviceListVDSCommand, check if the pvsize entry is not an empty String before trying to parse it into Long. Change-Id: I6d946eddc5f36cdf48fe82adc461b58880d5bdd9 Bug-Url: https://bugzilla.redhat.com/1256027 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/45478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d946eddc5f36cdf48fe82adc461b58880d5bdd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: Update DEFAULT_MANAGEMENT_NETWORK_NOT_FOUND
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: engine: Update DEFAULT_MANAGEMENT_NETWORK_NOT_FOUND ...................................................................... engine: Update DEFAULT_MANAGEMENT_NETWORK_NOT_FOUND Update ACTION_TYPE_FAILED_DEFAULT_MANAGEMENT_NETWORK_NOT_FOUND message. Change-Id: I48c5ddcb98ce5e2367570e05d093a037f84452f1 Bug-Url: https://bugzilla.redhat.com/1209045 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c5ddcb98ce5e2367570e05d093a037f84452f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: ui: missing CD error formating message
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: ui: missing CD error formating message ...................................................................... ui: missing CD error formating message Bug-Url: https://bugzilla.redhat.com/1141758 Change-Id: I7006d69188f52850f200fd076c818a2e0557bb1b Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 27 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Passed CI tests Shahar Havivi: Verified Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45424 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7006d69188f52850f200fd076c818a2e0557bb1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: added "console options" to the VMs main tab
by tnisan＠redhat.com 30 Aug '15

30 Aug '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: added "console options" to the VMs main tab ...................................................................... webadmin: added "console options" to the VMs main tab - enriched the DropdownActionButton to be able to recalculate the actions' availability based on selection change - enriched DropdownActionButton to use the actual selection and not the one which was valid during creation of the table (which was ok for subtabs but not for maintabs) - used this new support to create the console options Bug-Url: https://bugzilla.redhat.com/1025447 Change-Id: I21855cef2524f2ece99d563209d70cec6d9d911c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 3 files changed, 55 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21855cef2524f2ece99d563209d70cec6d9d911c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: validate MTU against any non-VLAN network
by alkaplan＠redhat.com 30 Aug '15

30 Aug '15

Alona Kaplan has submitted this change and it was merged. Change subject: engine: validate MTU against any non-VLAN network ...................................................................... engine: validate MTU against any non-VLAN network Validate MTU against any non-VLAN network Change-Id: I9025787776fe6f567c94fe7b66a235c2f81229f5 Bug-Url: https://bugzilla.redhat.com/1242227 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/NetworkMtuValidatorTest.java 2 files changed, 17 insertions(+), 26 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/44620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9025787776fe6f567c94fe7b66a235c2f81229f5 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: Refine generics in LinqUtils
by masayag＠redhat.com 30 Aug '15

30 Aug '15

Moti Asayag has submitted this change and it was merged. Change subject: core: Refine generics in LinqUtils ...................................................................... core: Refine generics in LinqUtils Refine generics in LinqUtils. Change-Id: I86e81b4a708ea411ae8c47e077b1412b79cba4ca Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/linq/LinqUtils.java 1 file changed, 11 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86e81b4a708ea411ae8c47e077b1412b79cba4ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Mounting $PWD in the same path
by dcaroest＠redhat.com 28 Aug '15

28 Aug '15

David Caro has submitted this change and it was merged. Change subject: Mounting $PWD in the same path ...................................................................... Mounting $PWD in the same path That has risen up when using an external service, for example, libvirt and passing to it paths, if the path is not the same, then it fails, with this, it's transparent if the path is external or not because they are the same. Change-Id: I5706f6c3fce2552b06202c8f251ec5083ed4dec0 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M mock_configs/mock_runner.sh 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: David Caro: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/45398 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5706f6c3fce2552b06202c8f251ec5083ed4dec0 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in jenkins[master]: Fixed issue with the upgrade jobs
by dcaroest＠redhat.com 28 Aug '15

28 Aug '15

David Caro has submitted this change and it was merged. Change subject: Fixed issue with the upgrade jobs ...................................................................... Fixed issue with the upgrade jobs They were not properly resolving the git and gerrit server Change-Id: I1b610535a0e548ed2d4fc7915b67ddc7064d6640 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/yaml/templates/engine-upgrade.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests David Caro: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/45452 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b610535a0e548ed2d4fc7915b67ddc7064d6640 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Paz Dangur <pdangur(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: New datacenter invalid highlight
by awels＠redhat.com 28 Aug '15

28 Aug '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: New datacenter invalid highlight ...................................................................... webadmin: New datacenter invalid highlight - The new Datacenter popup was changed to have tabs but never had the code hooked up to highlight invalid fields on the tabs. This patch hooks up the tabs to the infrastructure. Change-Id: Iac7e452d282775d0f1bc296bf2dfce9ae62091f1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252525 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/datacenter/DataCenterPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/DataCenterPopupView.ui.xml 5 files changed, 46 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45328 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac7e452d282775d0f1bc296bf2dfce9ae62091f1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: webadmin: network general tab layout
by awels＠redhat.com 28 Aug '15

28 Aug '15

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: network general tab layout ...................................................................... webadmin: network general tab layout - Fixed network general tab layout to not overlap when resizing. Change-Id: Id58d67169b670e9ae37c174a2d8d389cb5a57113 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1252987 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id58d67169b670e9ae37c174a2d8d389cb5a57113 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0