August 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: extracted InterfacesSpeed calculation methods.
by piotr.kliczewski＠gmail.com 28 Aug '15

28 Aug '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: extracted InterfacesSpeed calculation methods. ...................................................................... core: extracted InterfacesSpeed calculation methods. extracted, so they can be reused in HostSetupNetworksValidator Bug-Url: https://bugzilla.redhat.com/1249654 Change-Id: Ieef6c4559f7414579f9a5cf0754e7cc8e1d32d7a Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfacesSpeed.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java 2 files changed, 130 insertions(+), 72 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef6c4559f7414579f9a5cf0754e7cc8e1d32d7a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: persisting NetworkattAchments HostNetworkQos data
by piotr.kliczewski＠gmail.com 28 Aug '15

28 Aug '15

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: persisting NetworkattAchments HostNetworkQos data ...................................................................... core: persisting NetworkattAchments HostNetworkQos data Bug-Url: https://bugzilla.redhat.com/1249654 Change-Id: I57bf60eacb803e1db27a3a91d542f2dcb40f3a0b Signed-off-by: Martin Mucha <mmucha(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkAttachment.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkAttachmentDaoImpl.java M packaging/dbscripts/network_sp.sql 4 files changed, 139 insertions(+), 14 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45203 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57bf60eacb803e1db27a3a91d542f2dcb40f3a0b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: setup: aaa: Preserve external_id of existing admin user
by sbonazzo＠redhat.com 28 Aug '15

28 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: aaa: Preserve external_id of existing admin user ...................................................................... setup: aaa: Preserve external_id of existing admin user Preserves external_id of existing admin@internal user during upgrade instead of always generating new external_id. Change-Id: I40f4d761c2a0bf73a4fd2d642c2e1945f2df29cd Bug-Url: https://bugzilla.redhat.com/1257077 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaainternal.py 1 file changed, 34 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests Martin Betak: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/45343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40f4d761c2a0bf73a4fd2d642c2e1945f2df29cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: increase again the timeout waiting the engine
by sbonazzo＠redhat.com 28 Aug '15

28 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: increase again the timeout waiting the engine ...................................................................... packaging: setup: increase again the timeout waiting the engine On automated setup hosted-engine is waiting till a timeout for the engine to come up. That value wasn't enought for overloaded CI environment. Change-Id: I7a7124f5bf56da48b5ade4941d5f50ac3d910b33 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/health.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a7124f5bf56da48b5ade4941d5f50ac3d910b33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: increase again the timeout waiting the engine
by sbonazzo＠redhat.com 28 Aug '15

28 Aug '15

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: increase again the timeout waiting the engine ...................................................................... packaging: setup: increase again the timeout waiting the engine On automated setup hosted-engine is waiting till a timeout for the engine to come up. That value wasn't enought for overloaded CI environment. Change-Id: I7a7124f5bf56da48b5ade4941d5f50ac3d910b33 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/health.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/45442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a7124f5bf56da48b5ade4941d5f50ac3d910b33 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in jenkins[master]: Yamlized ovirt-engine upgrade job
by eedri＠redhat.com 28 Aug '15

28 Aug '15

Eyal Edri has submitted this change and it was merged. Change subject: Yamlized ovirt-engine upgrade job ...................................................................... Yamlized ovirt-engine upgrade job Yamlized ovirt-engine upgrade job for: - 3.4,3.5->3.5 - 3.5,3.6->3.6 - 3.6,master -> master Change-Id: I271b77ea518a84b8ae2e7883aa3988975b600032 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml A jobs/confs/shell-scripts/ovirt-engine_upgrade-engine.cleanup.sh A jobs/confs/shell-scripts/ovirt-engine_upgrade-engine.sh A jobs/confs/yaml/builders/ovirt-engine_upgrade-engine.yaml A jobs/confs/yaml/publishers/engine-upgrade-cleanup.yaml A jobs/confs/yaml/templates/engine-upgrade.yaml D jobs/ovirt-engine_upgrade_stable_to_3.4/build_engine_rpm.sh D jobs/ovirt-engine_upgrade_stable_to_3.4/cleanup.sh D jobs/ovirt-engine_upgrade_stable_to_3.4/upgrade.sh C jobs/ovirt-engine_upgrade_to_3.5/build_engine_rpm.sh R jobs/ovirt-engine_upgrade_to_3.5/cleanup.file.otopi C jobs/ovirt-engine_upgrade_to_3.5/cleanup.sh R jobs/ovirt-engine_upgrade_to_3.5/setup.file.otopi C jobs/ovirt-engine_upgrade_to_3.5/upgrade.sh C jobs/ovirt-engine_upgrade_to_3.6/build_engine_rpm.sh C jobs/ovirt-engine_upgrade_to_3.6/cleanup.file.otopi C jobs/ovirt-engine_upgrade_to_3.6/cleanup.sh R jobs/ovirt-engine_upgrade_to_3.6/setup.file.otopi C jobs/ovirt-engine_upgrade_to_3.6/upgrade.sh R jobs/ovirt-engine_upgrade_to_master/build_engine_rpm.sh R jobs/ovirt-engine_upgrade_to_master/cleanup.file.otopi R jobs/ovirt-engine_upgrade_to_master/cleanup.sh C jobs/ovirt-engine_upgrade_to_master/setup.file.otopi R jobs/ovirt-engine_upgrade_to_master/upgrade.sh 24 files changed, 283 insertions(+), 747 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Sharon Naftaly: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44280 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I271b77ea518a84b8ae2e7883aa3988975b600032 Gerrit-PatchSet: 11 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Max Kovgan <mvk(a)redhat.com> Gerrit-Reviewer: Sagi Shnaidman <sshnaidm(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:refactor: Move cinder logic to CINDERStorageHelper
by mlipchuk＠redhat.com 27 Aug '15

27 Aug '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:refactor: Move cinder logic to CINDERStorageHelper ...................................................................... core:refactor: Move cinder logic to CINDERStorageHelper Move cinder specific logic performed when connecting host to storage pool to CINDERStorageHelper instead of having it in ConnectHostToStoragePoolServersCommand. Change-Id: I67cf676681ffc29727b3318a33f476d4ca90a9ec Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 5 files changed, 98 insertions(+), 84 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/44892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67cf676681ffc29727b3318a33f476d4ca90a9ec Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:refactor: Refactor code to be reused in future patch
by mlipchuk＠redhat.com 27 Aug '15

27 Aug '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:refactor: Refactor code to be reused in future patch ...................................................................... core:refactor: Refactor code to be reused in future patch Move addMessageToAuditLog method from CINDERStorageHelper to StorageHelperBase so it can be used in future patches. Change-Id: I7a02b2cfe66abe7feb7bf275458a635aee714361 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 2 files changed, 8 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/44333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a02b2cfe66abe7feb7bf275458a635aee714361 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:refactor: Add IStorageHelper.disconnectHostFromStorageP...
by mlipchuk＠redhat.com 27 Aug '15

27 Aug '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:refactor: Add IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted ...................................................................... core:refactor: Add IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted New IStorageHelper.disconnectHostFromStoragePoolServersCommandCompleted added. This is a more generic way to perform logic after command execution completed. Change-Id: Id66a258e25cc000588bdbf7b416529a9eb4bbd8a Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CINDERStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 5 files changed, 33 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/44904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id66a258e25cc000588bdbf7b416529a9eb4bbd8a Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core:refactor: Add IStorageHelper.prepareDisconnectHostFromS...
by mlipchuk＠redhat.com 27 Aug '15

27 Aug '15

Maor Lipchuk has submitted this change and it was merged. Change subject: core:refactor: Add IStorageHelper.prepareDisconnectHostFromStoragePoolServers ...................................................................... core:refactor: Add IStorageHelper.prepareDisconnectHostFromStoragePoolServers New IStorageHelper.prepareDisconnectHostFromStoragePoolServers added. This methos is called when disconnecting storage server. Change-Id: I0b9bc5f368060b4014c697d6a44d96e656b0dbd4 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 4 files changed, 20 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/44896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b9bc5f368060b4014c697d6a44d96e656b0dbd4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0