January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: stateless vms monitoring - vmManagers
by ahadas＠redhat.com 28 Jan '16

28 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: stateless vms monitoring - vmManagers ...................................................................... core: stateless vms monitoring - vmManagers As part of the effort to make VmsMonitoring stateless, the managers of the monitored VMs are now fetched using the VM analyzers instead of holding them as a member of VmsMonitoring. Change-Id: Ic7f60c810db6f8a37353c732a452e5b151b7c5b7 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 3 files changed, 18 insertions(+), 25 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52816 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f60c810db6f8a37353c732a452e5b151b7c5b7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: CreateSnapshot - add parameters ctor
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CreateSnapshot - add parameters ctor ...................................................................... core: CreateSnapshot - add parameters ctor Change Iaae93b7e6b041749c4911806bfdb78fa4afe166c add missing ctors to the relevant commands, CreateSnapshot was missing from that patch - this patch adds the ctor to that command as well. Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1300757 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/52854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Uninitialized host fails to open hardware tab
by masayag＠redhat.com 28 Jan '16

28 Jan '16

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Uninitialized host fails to open hardware tab ...................................................................... webadmin: Uninitialized host fails to open hardware tab When hardware sub-tab is selected for uninitialized host, a NPE is thrown since the HBA collection is null. In addition, the HostGeneralModel.oupdateAlerts() will be the only place where alerts are being handled. Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Bug-Url: https://bugzilla.redhat.com/1293574 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 3 files changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/52852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759e49a0418c9a0c21e917b153d4c1ef4c877911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: VM.getCompatibilityVersion() usage
by ahadas＠redhat.com 28 Jan '16

28 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: engine: VM.getCompatibilityVersion() usage ...................................................................... engine: VM.getCompatibilityVersion() usage This patch is part of the series introducing VM compatibility version feature. This feature allows to customize a VM to its own compatibility version unrelated to one of the cluster. VM compatibility version is limited by Data Center and capabilities of the host the VM will be able to run on. This patch makes using VM.getCompatibilityVersion() instead of VM.getClusterCompatibilityVersion() where appropriate. Change-Id: I4d8b71f38ca4a33c340922b06d4bf9b3e2b3c82b Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetNumberOfCpusCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/HostDeviceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllAttachableDisksForVmQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java 45 files changed, 151 insertions(+), 126 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/48162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d8b71f38ca4a33c340922b06d4bf9b3e2b3c82b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: CreateSnapshot - add parameters ctor
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CreateSnapshot - add parameters ctor ...................................................................... core: CreateSnapshot - add parameters ctor Change Iaae93b7e6b041749c4911806bfdb78fa4afe166c add missing ctors to the relevant commands, CreateSnapshot was missing from that patch - this patch adds the ctor to that command as well. Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1300757 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/52849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54effa540931d68c67b0f5928a4cf3ad343dc5ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: stateless vms monitoring - timeToUpdateVmStatistics
by ahadas＠redhat.com 28 Jan '16

28 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: stateless vms monitoring - timeToUpdateVmStatistics ...................................................................... core: stateless vms monitoring - timeToUpdateVmStatistics As part of the effort to make VmsMonitoring stateless, the indication whether or not the upcoming monitoring cycle should include VM statistics is now stored as a variable instead of holding it as a member of VmsMonitoring. Change-Id: If43199150509046de25fb4efe55cac1a03e46a49 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 5 files changed, 22 insertions(+), 28 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52815 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If43199150509046de25fb4efe55cac1a03e46a49 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix RSDL for adding clusters
by juan.hernandez＠redhat.com 28 Jan '16

28 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix RSDL for adding clusters ...................................................................... restapi: Fix RSDL for adding clusters The RSDL metadata doesn't document correctly the use of the "scheduling_policy.name" element for adding a cluster. As a result the Python SDK doesn't document it in its documentation comments and the CLI doesn't list it in autocompletion. This patch fixes that issue. Change-Id: I3418e301679c31eec3950c4428485d48e39cad73 Bug-Url: https://bugzilla.redhat.com/1279159 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved; Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/48251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3418e301679c31eec3950c4428485d48e39cad73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: stateless vms monitoring - vdsManager
by ahadas＠redhat.com 28 Jan '16

28 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: core: stateless vms monitoring - vdsManager ...................................................................... core: stateless vms monitoring - vdsManager As part of the effort to make VmsMonitoring stateless, the VdsManager is now stored as a variable instead of holding it as a member of VmsMonitoring. Change-Id: Ifa6da1901221033316ba4f5666776d512bd0a943 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVmStatsRefresher.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 5 files changed, 38 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/52814 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa6da1901221033316ba4f5666776d512bd0a943 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: disallow powermock imports
by amureini＠redhat.com 28 Jan '16

28 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: build: disallow powermock imports ...................................................................... build: disallow powermock imports We've seen PowerMock stretches the build time by a considerable amount. We worked very hard on removing it, and this patch helps safegaurd against re-introducing it. Change-Id: I9edc9b31eaa17925df6da0f1aa11ddaac5f529aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9edc9b31eaa17925df6da0f1aa11ddaac5f529aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: IllegalImport checkstyle
by amureini＠redhat.com 28 Jan '16

28 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: build: IllegalImport checkstyle ...................................................................... build: IllegalImport checkstyle Add a checkstyle check to forbid illegal imports (com.sun, by default). The project doesn't currently have any such imports, but this patch serves as a safeguard from having them added in the future. Change-Id: I3ec04edbdd0f9651d138afa5db370f3ba17c202d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52716 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ec04edbdd0f9651d138afa5db370f3ba17c202d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0