January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Release keys removed from the console title
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Release keys removed from the console title ...................................................................... webadmin: Release keys removed from the console title With this fix, the console title does not contain release keys. This info is displayed by virt-viewer out of the box. Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e Bug-Url: https://bugzilla.redhat.com/1295659 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 2 files changed, 1 insertion(+), 20 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/52807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I620d55a83ec6f0231fb6eb9f882a10fa98199f9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Use the proper whitelist for MigrateVmCommand.canDoAction
by tnisan＠redhat.com 28 Jan '16

28 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: Use the proper whitelist for MigrateVmCommand.canDoAction ...................................................................... Use the proper whitelist for MigrateVmCommand.canDoAction The execute methods gets whitelist using the getVdsWhiteList method. But canDoAction used getParameters directly. This caused trouble for MigrateVmToServerCommand which overrides getVdsWhitelist as a different value was used for canDoAction and execute calls. Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258960 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: dao: Avoid Java 8 constructs in VmDynamicDaoImpl
by ahadas＠redhat.com 27 Jan '16

27 Jan '16

Arik Hadas has submitted this change and it was merged. Change subject: dao: Avoid Java 8 constructs in VmDynamicDaoImpl ...................................................................... dao: Avoid Java 8 constructs in VmDynamicDaoImpl Removing Java 8 constructs from VmDynamicDaoImpl, because they are not currently supported in DAOs and cause DAO tests to fail. Change-Id: I64a396986c98ddf7640737bf4b5b9b25ad84874c Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java 1 file changed, 15 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a396986c98ddf7640737bf4b5b9b25ad84874c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: fix remove disk snapshots for cinder
by tnisan＠redhat.com 27 Jan '16

27 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix remove disk snapshots for cinder ...................................................................... core: fix remove disk snapshots for cinder Fix init on remove disk snapshots command for Cinder disks flow. The 'representativeImage' can be null when using CoCo after the disk snapshot has been removed and the command is in the ending phase. Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Bug-Url: https://bugzilla.redhat.com/1301340 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 21 insertions(+), 18 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix remove disk snapshots for cinder
by tnisan＠redhat.com 27 Jan '16

27 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix remove disk snapshots for cinder ...................................................................... core: fix remove disk snapshots for cinder Fix init on remove disk snapshots command for Cinder disks flow. The 'representativeImage' can be null when using CoCo after the disk snapshot has been removed and the command is in the ending phase. Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Bug-Url: https://bugzilla.redhat.com/1301340 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommand.java 1 file changed, 21 insertions(+), 18 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec6e9ef84e2dd4db63db25d6d5e52915828203c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: relying on shared code from ovirt_setup_lib
by sradco＠redhat.com 27 Jan '16

27 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: relying on shared code from ovirt_setup_lib ...................................................................... packaging: setup: relying on shared code from ovirt_setup_lib See also I884089c5674ab8042cc02fe46ab5a3ca3a599b97 in engine Bug-Url: https://bugzilla.redhat.com/1301962 Change-Id: I21ce4c431a28857106fb571f8d0a604f6085a4d7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-dwh.spec.in M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-dwh/db/clear.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/single_etl.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/schema.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/provisioning/postgres.py 6 files changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21ce4c431a28857106fb571f8d0a604f6085a4d7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: Fix semanage requirement in fedora 23
by sbonazzo＠redhat.com 27 Jan '16

27 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: Fix semanage requirement in fedora 23 ...................................................................... packaging: spec: Fix semanage requirement in fedora 23 semanage was packaged in policycoreutils-python until fedora 23, then it moved to policycoreutils-python-utils. Fix the spec file accordingly. Change-Id: I1236ea2f611437634c331d8bc89c74287a7ff0e8 Bug-Url: https://bugzilla.redhat.com/1302035 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52782 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1236ea2f611437634c331d8bc89c74287a7ff0e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[ovirt-engine-reports-3.6]: build: after build reports for 3.6.3
by sradco＠redhat.com 27 Jan '16

27 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: build: after build reports for 3.6.3 ...................................................................... build: after build reports for 3.6.3 Change-Id: I9432aea3a6fcda65bdc1540336dcd362544491f2 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9432aea3a6fcda65bdc1540336dcd362544491f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-reports[ovirt-engine-reports-3.6]: build: build reports for 3.6.3
by sradco＠redhat.com 27 Jan '16

27 Jan '16

Shirly Radco has submitted this change and it was merged. Change subject: build: build reports for 3.6.3 ...................................................................... build: build reports for 3.6.3 Change-Id: Iebc7c36c6f6e99e09ca020c0554b2e205e9d6780 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-reports.spec.in M version.mak 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebc7c36c6f6e99e09ca020c0554b2e205e9d6780 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-engine-reports-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not cache queries containing asterisk
by emesika＠redhat.com 27 Jan '16

27 Jan '16

Eli Mesika has submitted this change and it was merged. Change subject: core: do not cache queries containing asterisk ...................................................................... core: do not cache queries containing asterisk If the search query contains an asterisk ('*') then the query should not be cached in order to match correctly changes that might apply to a tag association for example before the cache entry is expired (one day) Change-Id: I6ff4fc5a872103f73519a5ed2a9b6a8f0a5a366d Bug-Ur: https://bugzilla.redhat.com/show_bug.cgi?id=1301383 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Passed CI tests Juan Hernandez: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52797 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ff4fc5a872103f73519a5ed2a9b6a8f0a5a366d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0