January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: String equality checks
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: String equality checks ...................................................................... core: String equality checks Use equality instead of identity (==, !=) when comparing strings. While the JVM usually produces the same literal from the pool this is not a behavior that should be relied on. Instead, logical equality should be checked. A checkstyle check was added to ensure such errors are not repeated. Change-Id: I987ca985240f7783f677b785f058ed16edafe5f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/quota/QuotaPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 3 files changed, 4 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I987ca985240f7783f677b785f058ed16edafe5f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerTest MockConfigRule
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerTest MockConfigRule ...................................................................... core: SyntaxCheckerTest MockConfigRule Utilize MockConfigRule instead of rewriting the same logic (in a flawed way) in the test. Change-Id: I679dca054f96224ca41d640d04059f1756daa555 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 9 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51262 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I679dca054f96224ca41d640d04059f1756daa555 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerTest variable initialization
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerTest variable initialization ...................................................................... core: SyntaxCheckerTest variable initialization Removed redundant initalizations. Change-Id: I45fdfac1588e8da1e2a610471d870a669383475f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45fdfac1588e8da1e2a610471d870a669383475f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyntaxCheckerTest prints
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SyntaxCheckerTest prints ...................................................................... core: SyntaxCheckerTest prints Removed prints to stdout which have no place in an automatic test. Change-Id: Ibaaea565e89bb93999b976f6ec7e6478d6fd9828 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaaea565e89bb93999b976f6ec7e6478d6fd9828 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Standardize SyntexCheckerTest static imports
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Standardize SyntexCheckerTest static imports ...................................................................... core: Standardize SyntexCheckerTest static imports Statically import org.junit.Assert, org.mockito.Mockito and org.mockito.Matchers methods as per the project's conventions. Change-Id: I41868dc4ed5cb164782700d182b257e77404df07 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 14 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41868dc4ed5cb164782700d182b257e77404df07 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix SyntaxCheckerTest asserts
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix SyntaxCheckerTest asserts ...................................................................... core: Fix SyntaxCheckerTest asserts Fixed asserts to use equality instead of identity (==, !=). While the JVM usually produces the same literal from the pool this is not a behavior that should be relied on. Instead, logical equality should be checked. Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/51258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36e9106ae39b4fc0ef0ba315c0a65de04a0267b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: One statement per line checkstyle
by amureini＠redhat.com 13 Jan '16

13 Jan '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: One statement per line checkstyle ...................................................................... engine: One statement per line checkstyle As the project's style already (mostly) follows Java's style recommendation of having a single statement per line, this patch fixes the several places that do not follow this guideline and applies a checkstyle check to make sure no violations are introduced in the future. Change-Id: Id70f9e6d37f67d04d7a944aef4fb3925a9b72f4a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterServiceSyncJobTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateWatchdogsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmWatchdogsResourceTest.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 5 files changed, 16 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Sahina Bose: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id70f9e6d37f67d04d7a944aef4fb3925a9b72f4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Run unit tests for patches
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Run unit tests for patches ...................................................................... Run unit tests for patches This patch changes the "check-patch.sh" so that the code generator is built, and executed and then the unit tests are executed. Change-Id: I70afcc8ef94fe8356153d06ad66cce1e7738a0b8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D automation/check-patch.packaages A automation/check-patch.packages M automation/check-patch.sh 3 files changed, 40 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70afcc8ef94fe8356153d06ad66cce1e7738a0b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for "Get" and "List" parameters
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for "Get" and "List" parameters ...................................................................... Add support for "Get" and "List" parameters Some of the "Get" and "List" operations of the API support parameters. For example, the operation to list virtual machines supports the "search" parameter. This patch adds support for this kind of parameters, so that this, for example, will work: # Create the connection: connection = Ovirt::SDK::V4Connection.new({ :url => 'https://engine.example.com/ovirt-engine/api', :username => 'admin@internal', :password => '...', :ca_file => 'ca.pem', }) # Get the VMs service: vms_service = connection.system.vms # Search for VMs with a given name and print their id: vms = vms_service.list({:search => 'name=myvm'}) vms.each do |vm| puts vm.id end # Close the connection: connection.close The patch also improves the tests so that this support is better tested. Change-Id: I0f1fe53af1f81a29c72c4a5ab99f88d4ceda3e1b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M README.md M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M pom.xml M sdk/examples/list_vms.rb A sdk/examples/search_vms.rb M sdk/lib/ovirt/sdk/v4.rb M sdk/lib/ovirt/sdk/v4/connection.rb A sdk/lib/ovirt/sdk/v4/xml_formatter.rb A sdk/spec/connection_spec.rb A sdk/spec/parameters.yaml M sdk/spec/spec_helper.rb A sdk/spec/vms_service_spec.rb A sdk/spec/xml_formatter_spec.rb 13 files changed, 695 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51791 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f1fe53af1f81a29c72c4a5ab99f88d4ceda3e1b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for the "Remove" operation
by juan.hernandez＠redhat.com 13 Jan '16

13 Jan '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support for the "Remove" operation ...................................................................... Add support for the "Remove" operation This patch adds support for the "Remove" operation. Change-Id: Ieb1ca304fb0a194af714ec9d437823ca1032768b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java A sdk/examples/remove_vm.rb M sdk/lib/ovirt/sdk/v4/connection.rb 3 files changed, 70 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51790 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb1ca304fb0a194af714ec9d437823ca1032768b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0