January 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: fix FcpStorageView faults
by derez＠redhat.com 13 Jan '16

13 Jan '16

Daniel Erez has submitted this change and it was merged. Change subject: frontend: fix FcpStorageView faults ...................................................................... frontend: fix FcpStorageView faults FcpStorageView has four faults that are fixed in this patch: 1. It extends from AbstractSanStorageView, which is useless since it's the only subclass of AbstractSanStorageView. 2. The corresponding ui.xml file is AbstractSanStorageView.ui.xml (and not FcpStorageView.ui.xml), which causes the editor to ignore the label "errorMessage" in FcpStorageView and to malfunction. 3. The @Path annotation of the label "errorMessage" is "GetLUNsFailure", while the corresponding string field in the model, SanStorageModel, is "getLUNsFailure". 4. AbstractSanStorageView extends from AbstractStorageView<SanStorageModelBase>, while the model of FcpStorageView is SanStorageModel. This patch: - Merges AbstractSanStorageView into FcpStorageView. - Renames the AbstractSanStorageView.ui.xml to FcpStorageView.ui.xml. - Renames the Path annotation of the label "errorMessage" to "getLUNsFailure". - Replaces the generics type of AbstractStorageView to SanStorageModel. As a consequence, the label "errorMessage" is finally shown when it's supposed to be shown in the FcpStorageView. Change-Id: Idff765f50ce3d461c18f0db428687e7a27e8b64c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1297689 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.ui.xml 3 files changed, 84 insertions(+), 103 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/51720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idff765f50ce3d461c18f0db428687e7a27e8b64c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: Disable engine registration if hosted engine is configured
by dougsland＠redhat.com 13 Jan '16

13 Jan '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: Disable engine registration if hosted engine is configured ...................................................................... Disable engine registration if hosted engine is configured We can trivially check for HE configuration by importing the config paths from the HE plugin and checking those. Do so, and don't let users register if HE is configured, since it's probably registered to HE Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258397 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/49052 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> (cherry picked from commit b18463d1992ac0c130c1b4d448e2eb9f8b7627c2) Reviewed-on: https://gerrit.ovirt.org/51800 Reviewed-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Continuous-Integration: Douglas Schilling Landgraf <dougsland(a)redhat.com> Tested-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: increase default nodes in cell tree
by awels＠redhat.com 13 Jan '16

13 Jan '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: increase default nodes in cell tree ...................................................................... webadmin: increase default nodes in cell tree - The default number of nodes shown in a cell tree was 25. It would automatically include a 'show more' link to show another 25, until all nodes are shown. Since we include a 'show all' button at the top this makes no sense in our application. This patch increases the number of visible nodes to all. And as a side effect solves the translation problem of the 'show more' link. Change-Id: I508fd174c5abf569397c0a52b60d1fe23f0646f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269433 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/ElementIdCellTree.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I508fd174c5abf569397c0a52b60d1fe23f0646f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: Disable engine registration if hosted engine is configured
by fabiand＠redhat.com 13 Jan '16

13 Jan '16

Fabian Deutsch has submitted this change and it was merged. Change subject: Disable engine registration if hosted engine is configured ...................................................................... Disable engine registration if hosted engine is configured We can trivially check for HE configuration by importing the config paths from the HE plugin and checking those. Do so, and don't let users register if HE is configured, since it's probably registered to HE Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258397 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/49052 Continuous-Integration: Jenkins CI Reviewed-by: Fabian Deutsch <fabiand(a)redhat.com> --- M src/engine_page.py 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, approved Jenkins CI: Passed CI tests Ryan Barry: Verified -- To view, visit https://gerrit.ovirt.org/49052 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5c86134968a1fa2d6661ac163908112fe1018a4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: build: ovirt-live-3.6.2_rc2
by sbonazzo＠redhat.com 13 Jan '16

13 Jan '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-3.6.2_rc2 ...................................................................... build: ovirt-live-3.6.2_rc2 Change-Id: I4d5259dc7b4451b7f72a0e1c10c2064b788bae47 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/51798 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d5259dc7b4451b7f72a0e1c10c2064b788bae47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webui: Fix numa pinning dialog cancel button
by tnisan＠redhat.com 13 Jan '16

13 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: webui: Fix numa pinning dialog cancel button ...................................................................... webui: Fix numa pinning dialog cancel button When opening the numa pinning dialog through the VM edit screen, the pinning changes were persisted when you hit the cancel button. They should only be persisted when the OK button is pressed. Instead of directly manipulationg the numa nodes associated with the VM, a numa node model is moved around. When hitting the OK button the model is converted to numa node objects and set on the VM. Bug-Url: https://bugzilla.redhat.com/1284784 Change-Id: Ifc7ac4cdb0f7887bf74de5cdba2ca35b7bc92dfc Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/NumaSupportPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/numa/UnassignedVNumaNodesPanelPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/AssignedVNumaNodesPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/DraggableVirtualNumaPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/NumaSupportPopupView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/numa/VirtualNumaPanel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/NumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VNodeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 11 files changed, 177 insertions(+), 108 deletions(-) Approvals: Roman Mohr: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/51639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc7ac4cdb0f7887bf74de5cdba2ca35b7bc92dfc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Losing graphical protocol fix
by tnisan＠redhat.com 13 Jan '16

13 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Losing graphical protocol fix ...................................................................... core: Losing graphical protocol fix The problem was that changing graphical protocol (SPICE, VNC) in setups with ConfigValues.MultipleGraphicsSupported set to false might cause to attempt to have multiple graphics devices for a while. Causes: 1. Operations of adding and removing graphics devices were not ordered. Now devices are first removed then added. 2. Methods CommandBase#canDoAction()/validate() are by default called in separate DB transaction. This causes AddGraphicsDeviceCommand validation method to not being aware of previous device removals. Fixed by @CanDoActionSupportsTransaction. Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac Bug-Url: https://bugzilla.redhat.com/1297751 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 2 files changed, 38 insertions(+), 19 deletions(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51715 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd69f9a6dc69892a7189a7bab6be464a5094a9ac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: Add connection details explicitly for NFS
by tnisan＠redhat.com 13 Jan '16

13 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: Add connection details explicitly for NFS ...................................................................... core: hosted-engine: Add connection details explicitly for NFS It is not reliable to assume AddExistingFileStorageDomain command will create the connection details internally, thus the import HE domain command calls is prior to importing the domain. Change-Id: I790d1d22ffe5358b8a0daeb85b004d5a484a4745 Bug-Url: https://bugzilla.redhat.com/1293928 Bug-Url: https://bugzilla.redhat.com/1290518 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommandTest.java 2 files changed, 44 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I790d1d22ffe5358b8a0daeb85b004d5a484a4745 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: storage: make storagServerConnectin compensatable
by tnisan＠redhat.com 13 Jan '16

13 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: storage: make storagServerConnectin compensatable ...................................................................... core: storage: make storagServerConnectin compensatable In order to properly use it in complex flow and use proper rollback by conpensation, this entity is now compensation ready. Change-Id: I6d93f4a758cc96d89165dcd29d4df9e31d32ae9a Bug-Url: https://bugzilla.redhat.com/1293928 Bug-Url: https://bugzilla.redhat.com/1290518 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageConnectionToStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IscsiBondValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetLunsByVgIdTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommonTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageServerConnectionToStorageDomainCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionTestCommon.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/IscsiBondValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageConnectionValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendIscsiBondStorageConnectionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainServerConnectionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StorageConnectionHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/IscsiBondModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 48 files changed, 175 insertions(+), 175 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d93f4a758cc96d89165dcd29d4df9e31d32ae9a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: hosted-engine: import the domain only when DC is UP
by tnisan＠redhat.com 13 Jan '16

13 Jan '16

Tal Nisan has submitted this change and it was merged. Change subject: core: hosted-engine: import the domain only when DC is UP ...................................................................... core: hosted-engine: import the domain only when DC is UP Most of the setups will be concluded by an engine restart (configurable). At that stage the import may have already kicked in, and this race causes - 1) a reboot during the import - may lead to failed rollback, so we're left with junk in DB 2) An attemt to Attach before we have an UP host. This leads to a rollback which may lead to closure 1. As long as we don't attempt to add a data domain during HE setup, this approch will keep us safe and will import the domain while there isn't a restart planned. Change-Id: I2710be830cdb234fbb38456234219389e9299833 Bug-Url: https://bugzilla.redhat.com/1293928 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportHostedEngineStorageDomainCommandTest.java 2 files changed, 38 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/51418 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2710be830cdb234fbb38456234219389e9299833 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0