October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Move OvfManager to bll
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: Move OvfManager to bll ...................................................................... core: Move OvfManager to bll OvfManager is a tool used by the bll layer and adds abstraction and exposes an API to export VM and Templates. Moving it to bll will allow extending and enriching the information added to the OVF without constantly expending the structures and arguments. The following patch is adding a specialized OVF writer for hosted engine and will use the OvfManager access to the DAL layer. Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64959 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d82408f10de3e6172e8cce4044d5a8b58f36afc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: utils: Encapsulte OVF build algo into OvfBuilder
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: utils: Encapsulte OVF build algo into OvfBuilder ...................................................................... utils: Encapsulte OVF build algo into OvfBuilder The steps to build the OVF where called outside by the OvfManager. Its the responsiblity of the Object to build its internal structure and so it is encapsulated into it, making the API safer, easier and cleaner. Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581 Bug-Url: https://bugzilla.redhat.com/1358383 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java 2 files changed, 12 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I427aa4e9ada86c59e4d7cf999dbdb23aaaa44581 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Log exception instead of printStackTrace
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: restapi: Log exception instead of printStackTrace ...................................................................... restapi: Log exception instead of printStackTrace Change-Id: I17bfcb92943191860d45af26a08ce366e1839aa0 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSchedulingPolicyResource.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/60314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17bfcb92943191860d45af26a08ce366e1839aa0 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: vdsBroker: Log exception instead of printStackTrace
by rgolan＠redhat.com 31 Oct '16

31 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: vdsBroker: Log exception instead of printStackTrace ...................................................................... core: vdsBroker: Log exception instead of printStackTrace Change-Id: I489cdc3473a35219f4fa87a159cb5ed0b6292e3d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Roman Mohr: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60315 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I489cdc3473a35219f4fa87a159cb5ed0b6292e3d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix is_draft (bool) value
by sbendavi＠redhat.com 31 Oct '16

31 Oct '16

Shlomo Ben David has submitted this change and it was merged. Change subject: Fix is_draft (bool) value ...................................................................... Fix is_draft (bool) value bool(x) function isn't converts 'True' | 'False' strings into bool (True | False) values, it only returns True if the passed value is True, False otherwise. I've replaced it with ast.literal_eval() function that converts and returns the required bool values. Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932 Fixes: OVIRT-797 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65876 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c17f14465fa9c4cc741f136abc3836ffeaea932 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fixed host displayed cluster
by oourfali＠redhat.com 31 Oct '16

31 Oct '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: fixed host displayed cluster ...................................................................... webadmin: fixed host displayed cluster - Due to the order in which the cluster value was updated the list box would think when it was receiving the final value that it was still updating. This caused it to discard the final value and display the wrong value. This patch fixes that issue. Change-Id: I610d5a9adabf1302fe81be15e977c3c517017502 Bug-Url: https://bugzilla.redhat.com/1383020 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GroupedListModelListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java 4 files changed, 13 insertions(+), 53 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I610d5a9adabf1302fe81be15e977c3c517017502 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.5]: engine: Refresh LUN size fails to validate
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Refresh LUN size fails to validate ...................................................................... engine: Refresh LUN size fails to validate The RefreshLunsSizeCommand does not verify the LUNs sizes reported by the hosts correctly, failing the command wrongly. See commit: I71d59b9 Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Bug-Url: https://bugzilla.redhat.com/1389455 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.5 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Refresh LUN size fails to validate
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Refresh LUN size fails to validate ...................................................................... engine: Refresh LUN size fails to validate The RefreshLunsSizeCommand does not verify the LUNs sizes reported by the hosts correctly, failing the command wrongly. See commit: I71d59b9 Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Bug-Url: https://bugzilla.redhat.com/1389455 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/RefreshLunsSizeCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/65855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bb02029f33c4ced5c6a1fa890c50dd2e59ad5a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant test in UpdateVmCommandTest
by tnisan＠redhat.com 30 Oct '16

30 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant test in UpdateVmCommandTest ...................................................................... core: Remove redundant test in UpdateVmCommandTest testMigratoinCanBeSetWhenVMUsesScsiReservation is supposed to test if a VM can be migrated with regrards to whether SCSI reservation is set, however, nothing in UpdateVmCommand test or ever refers in any way to the scsi reservation value thus making this test redundant Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib638643246025eefbbd5d1aef50e435a75f3572a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added emails to all test experimental repo jobs
by eedri＠redhat.com 30 Oct '16

30 Oct '16

Eyal Edri has submitted this change and it was merged. Change subject: Added emails to all test experimental repo jobs ...................................................................... Added emails to all test experimental repo jobs As the pipeline plugin has no post build tasks we have only two statuses: FAILURE and SUCCESS Change-Id: Icfa221b109ad2ff5b88e58c5259b2292ee4b8c59 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Nadav Goldin: Looks good to me Eyal Edri: Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icfa221b109ad2ff5b88e58c5259b2292ee4b8c59 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0