October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: spec: correctly move engine/constants.py to engine-common pa...
by sbonazzo＠redhat.com 28 Oct '16

28 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: correctly move engine/constants.py to engine-common package ...................................................................... spec: correctly move engine/constants.py to engine-common package Moving engine/constants.py by itself it's not enough. Moving the whole directory. Maybe at this point is just better to put all the constants into a single file. Change-Id: Ic71fa80fad9927ef60f53dcb46fb3324605b2ba8 Bug-Url: https://bugzilla.redhat.com/1386213 Bug-Url: https://bugzilla.redhat.com/1263785 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/misc.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/__init__.py D packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/misc.py 4 files changed, 5 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic71fa80fad9927ef60f53dcb46fb3324605b2ba8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: vdsbroker's pom.xml
by tnisan＠redhat.com 28 Oct '16

28 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: vdsbroker's pom.xml ...................................................................... core: vdsbroker's pom.xml Removed commented out JBoss dependencies. Change-Id: I2e426702849569a6ae5a0419a30147d7b86cc0f2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/pom.xml 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65828 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e426702849569a6ae5a0419a30147d7b86cc0f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: VM dialog mem leak
by piotr.kliczewski＠gmail.com 28 Oct '16

28 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: VM dialog mem leak ...................................................................... webadmin: VM dialog mem leak - Fixed memory leaks in the VM dialog. Change-Id: I53c22111275458753bdabc43f710b9e837a59a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1368101 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/HasDataListModelEditorAdapter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBoxEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ManagePolicyUnitPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java 13 files changed, 66 insertions(+), 27 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53c22111275458753bdabc43f710b9e837a59a46 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.16
by juan.hernandez＠redhat.com 28 Oct '16

28 Oct '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.16 ...................................................................... restapi: Update to model 4.1.16 The more relevant changes in this new version of the model are the following: * Make `Ip.version` optional. * Add the `active_slave` link to the `Bonding` type. * Add DNS configuration support to `Network` and `NetworkAttachment`. * Add `remote_viewer_connection_file` attribute to the `GraphicsConsole` type, and the `populate_remote_viewer_connection_file` parameter to the operations that retrive the representation ov graphics consoles. * Add the `uses_scsi_reservation` attribute to the `DiskAttachment` type. Change-Id: Ib8cb777cd43e58c71a1b072d57e85af259631dfd Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8cb777cd43e58c71a1b072d57e85af259631dfd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin, userportal: Overhaul UiCommonEditorDriver cleanup()...
by piotr.kliczewski＠gmail.com 28 Oct '16

28 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin,userportal: Overhaul UiCommonEditorDriver cleanup() impl. ...................................................................... webadmin,userportal: Overhaul UiCommonEditorDriver cleanup() impl. 1. when cleaning up the edited Model object: - emit `if (getObject() != null) { .. }` block only if we have at least one statement to put in that block 2. when cleaning up the Editor instance: - scan supertype hierarchy to find all fields (inherited too) eligible for cleanup 3. refactor code by splitting into smaller methods With this patch, there is no need for "supertype field cleanup", the generated driver.cleanup() impl. takes care of that already. Change-Id: Ia2aa2c259e97c623c81aed23fad892a11e4f28cb Bug-Url: https://bugzilla.redhat.com/1368101 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java 7 files changed, 73 insertions(+), 29 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65818 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2aa2c259e97c623c81aed23fad892a11e4f28cb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Improve column control menu
by piotr.kliczewski＠gmail.com 28 Oct '16

28 Oct '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Improve column control menu ...................................................................... webadmin: Improve column control menu 1. replaced JavaScript/jQuery JSNI code with proper Java/GWT code to avoid performance issues & leaks 2. replaced up/down arrow icons on menu items with drag'n'drop Side note: HTML5 DnD spec is a _total_ mess. Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Bug-Url: https://bugzilla.redhat.com/1285499 Bug-Url: https://bugzilla.redhat.com/1368101 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenu.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnContextMenuItem.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnController.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/ColumnResizeCellTable.java D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/ColumnContextMenu.css D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_no.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/checkbox_yes.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_down.png D frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/move_up.png 11 files changed, 328 insertions(+), 375 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14b47620db16b25657e4a7197a84db38fe956420 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GWT: remove unused code from GWT servlet
by rgolan＠redhat.com 28 Oct '16

28 Oct '16

Roy Golan has submitted this change and it was merged. Change subject: core: GWT: remove unused code from GWT servlet ...................................................................... core: GWT: remove unused code from GWT servlet Change-Id: Ie209c901f8cadaa6d799efec08d8bd60240671f9 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie209c901f8cadaa6d799efec08d8bd60240671f9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DbConfigUtils assignment in if
by amureini＠redhat.com 28 Oct '16

28 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbConfigUtils assignment in if ...................................................................... core: DbConfigUtils assignment in if Moved the assignment outside of the if block to make the code easier to read. Change-Id: I1a23c9739fa862be02b45c8fb7be4249c2fca888 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a23c9739fa862be02b45c8fb7be4249c2fca888 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ConfigValues: Remove redundant qualification
by amureini＠redhat.com 28 Oct '16

28 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: ConfigValues: Remove redundant qualification ...................................................................... core: ConfigValues: Remove redundant qualification Change-Id: I8628ac98471572795a5e6d13331d377b5af1b7e1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8628ac98471572795a5e6d13331d377b5af1b7e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Move generic getValue to ConfigUtilsBase
by amureini＠redhat.com 28 Oct '16

28 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: Move generic getValue to ConfigUtilsBase ...................................................................... core: Move generic getValue to ConfigUtilsBase Moved the generic getValue implementation to ConfigBaseBase to create a better separation of layers - ConfigUtilsBase deals with all the logic regarding parsing values, handling defaults, etc, and DbConfigUtils adds only its DB specific bits - retrieving from the database, caching, etc. Change-Id: Ieada7dc63cdc394b5d3e9c031a324e0c986b0a2a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java 2 files changed, 119 insertions(+), 117 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieada7dc63cdc394b5d3e9c031a324e0c986b0a2a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0