October 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: LableNicCommand#init()
by amureini＠redhat.com 27 Oct '16

27 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: LableNicCommand#init() ...................................................................... core: LableNicCommand#init() Move initialization logic from constructor to the init() method where it belongs (see 6188d4e for details). Change-Id: I50ada8fad004e20af9e3f8086c573db798831921 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50ada8fad004e20af9e3f8086c573db798831921 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[ovirt-4.0]: Report session-startup on refresh
by vfeenstr＠redhat.com 27 Oct '16

27 Oct '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Report session-startup on refresh ...................................................................... Report session-startup on refresh To show that we support session-startup and session-shutdown we need to send upon receiving a refresh message also the session-startup message. Otherwise VDSM will assume that we do not support session-{startup,shutdown} reporting. Change-Id: Ia19348cd66552fcf029d6725ba78e22619ce77e9 Backport-To: 4.0 Bug-Url: https://bugzilla.redhat.com/1389332 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> (cherry picked from commit baa1be15dde19743ee0b7a7a412952fec5ea387e) --- M ovirt-guest-agent/OVirtAgentLogic.py M tests/message_validator.py 2 files changed, 11 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia19348cd66552fcf029d6725ba78e22619ce77e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix check for whether vm is starting up
by ahadas＠redhat.com 27 Oct '16

27 Oct '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix check for whether vm is starting up ...................................................................... core: fix check for whether vm is starting up Previously the check relied on the result of getLastVdsRunOn to see if the VM is starting up since preferred hosts are supposed to be used only during VM startup. But VmDynamic#lastVdsRunOn never contains the real host that the VM ran on when getting to this method (it is always null so this check is passed also for migrating VMs). Therefore, this check is changed. Change-Id: I02832a76d94f7a02d6f2b82970461d14a628ed74 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnit.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/65282 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02832a76d94f7a02d6f2b82970461d14a628ed74 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: Report session-startup on refresh
by vfeenstr＠redhat.com 27 Oct '16

27 Oct '16

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Report session-startup on refresh ...................................................................... Report session-startup on refresh To show that we support session-startup and session-shutdown we need to send upon receiving a refresh message also the session-startup message. Otherwise VDSM will assume that we do not support session-{startup,shutdown} reporting. Change-Id: Ia19348cd66552fcf029d6725ba78e22619ce77e9 Backport-To: 4.0 Bug-Url: https://bugzilla.redhat.com/1341106 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/OVirtAgentLogic.py M tests/message_validator.py 2 files changed, 11 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified; Looks good to me, approved Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia19348cd66552fcf029d6725ba78e22619ce77e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SchedulingManager#schedule
by amureini＠redhat.com 27 Oct '16

27 Oct '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: SchedulingManager#schedule ...................................................................... core: SchedulingManager#schedule The @NotNull constraint introduced on this by 0e4ae6 method caused RunVmCommand to fail with the following error: 2016-10-27 05:31:41,519 ERROR [org.ovirt.engine.core.bll.RunVmOnceCommand] (default task-19) [7b964e35] Exception: javax.validation.UnexpectedTypeException: HV000186: The constraint of type 'javax.validation.constraints.NotNull' defined on 'schedule.<return value>' has multiple matching constraint validators which is due to an additional value handler of type 'org.hibernate.validator.internal.engine.valuehandling.OptionalValueUnwrapper'. It is unclear which value needs validating. Clarify configuration via @UnwrapValidatedValue. This patch removes the problematic annotation and fixes the issue. Change-Id: I60fa11fe9e3805e293334dabc6cff156833e0310 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/65784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60fa11fe9e3805e293334dabc6cff156833e0310 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove synchronization of OVirtNodeInfo getInstance
by tnisan＠redhat.com 27 Oct '16

27 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove synchronization of OVirtNodeInfo getInstance ...................................................................... core: Remove synchronization of OVirtNodeInfo getInstance Commit 0736d3c2 removed the pointless null check before the double locking check, this patch now removes the synchronized from the getInstance method as the actual initialization part is taking part in a synchronized block Change-Id: Ibba279dcca897b4496ff90f98449c29bb8adf5dc Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65785 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibba279dcca897b4496ff90f98449c29bb8adf5dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix cpu profile group permissions
by tnisan＠redhat.com 27 Oct '16

27 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix cpu profile group permissions ...................................................................... core: Fix cpu profile group permissions Use PermissionDao to correctly check cpu profile user and group permissions. Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Bug-Url: https://bugzilla.redhat.com/1386289 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_views.sql 14 files changed, 68 insertions(+), 111 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/65568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055c67bc9e3cb6024198e7ee021de3950357f0e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Add CDI and unit tests for CpuProfileHelper
by tnisan＠redhat.com 27 Oct '16

27 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add CDI and unit tests for CpuProfileHelper ...................................................................... core: Add CDI and unit tests for CpuProfileHelper Change-Id: I3dd1d953812f057801c97ee752868a9965344036 Bug-Url: https://bugzilla.redhat.com/1386289 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/ProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java 12 files changed, 169 insertions(+), 48 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Andrej Krejcir: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dd1d953812f057801c97ee752868a9965344036 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: scheduling: Add missing parameters to Power saving balance p...
by tnisan＠redhat.com 27 Oct '16

27 Oct '16

Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Add missing parameters to Power saving balance policy ...................................................................... scheduling: Add missing parameters to Power saving balance policy The Enable automatic PM and Hosts in reserve options were not visible from the webadmin. Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1384563 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide045be1b54a6a579abe118440f0dbf1d41ed44d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: oVirt Live 4.0.5 RC4
by sbonazzo＠redhat.com 27 Oct '16

27 Oct '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: oVirt Live 4.0.5 RC4 ...................................................................... oVirt Live 4.0.5 RC4 Change-Id: I290a376c1364e982bdbedf7b2770f6d7bf2aa2ab Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65783 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I290a376c1364e982bdbedf7b2770f6d7bf2aa2ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0