November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: @Inject RegisterVdsQuery Daos
by Code Review 08 Nov '16

08 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject RegisterVdsQuery Daos ...................................................................... core: @Inject RegisterVdsQuery Daos @Inject the DAOs instead of explicitly getting them from DbFacade. Change-Id: I72c91f196c2ee478683e4e673a72c6d763bcd070 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQuery.java 1 file changed, 29 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66272 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c91f196c2ee478683e4e673a72c6d763bcd070 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: aaa: Sort auth domains alphabetically
by Code Review 08 Nov '16

08 Nov '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Sort auth domains alphabetically ...................................................................... aaa: Sort auth domains alphabetically The authentication domains displayed on login screen should be sorted alphabetically. Change-Id: I47fb174c600b23bbf510bc5302bac9f3a5c540d9 Bug-Url: https://bugzilla.redhat.com/1391646 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47fb174c600b23bbf510bc5302bac9f3a5c540d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: VmLogonCommand should propogate errors
by Code Review 08 Nov '16

08 Nov '16

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: VmLogonCommand should propogate errors ...................................................................... engine: VmLogonCommand should propogate errors VmLogonCommand should propogate errors in running VmLogon vds command. Fixing a regression caused by f8da95ffe Change-Id: I23e5a22d16298027ffdd5814b26906cfdc9d60eb Bug-Url: https://bugzilla.redhat.com/1391146 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/IsPasswordDelegationPossibleQuery.java 3 files changed, 25 insertions(+), 33 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66264 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23e5a22d16298027ffdd5814b26906cfdc9d60eb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix the upgrade script that converts memory volumes to...
by Code Review 08 Nov '16

08 Nov '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: fix the upgrade script that converts memory volumes to disks ...................................................................... core: fix the upgrade script that converts memory volumes to disks This patch fixes yet another problem that was found in the upgrade script that converts snapshot's memory volumes to disks in the database. This time the problem is with using 'NOT IN <set>' where the set could have NULL values (therefore the fix is to filter the NULL values from the set). Change-Id: I48103802395e58afb155a4501e36c256dbf65084 Bug-Url: https://bugzilla.redhat.com/1390254 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0140_convert_memory_snapshots_to_disks.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/66263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48103802395e58afb155a4501e36c256dbf65084 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: cleanup: Remove delegated method isImagesExists.
by Code Review 08 Nov '16

08 Nov '16

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: cleanup: Remove delegated method isImagesExists. ...................................................................... cleanup: Remove delegated method isImagesExists. Remove redundant method, and enhance isImagesExists. Change-Id: I6192d7d2ffbe03988b4cdf7d98cb22cac70f281a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/66243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6192d7d2ffbe03988b4cdf7d98cb22cac70f281a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Enable compression by default
by Code Review 08 Nov '16

08 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Enable compression by default ...................................................................... Enable compression by default This patch changes the SDK so that compression is enabled by default, except when debug is enabled. Change-Id: I4d78edd4da62fb589bfaa3b931673d465003fcaf Bug-Url: https://bugzilla.redhat.com/1370464 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/enable_compression.rb M sdk/lib/ovirtsdk4/connection.rb 2 files changed, 17 insertions(+), 9 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d78edd4da62fb589bfaa3b931673d465003fcaf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fix import VM validation based on an empty template.
by Code Review 08 Nov '16

08 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix import VM validation based on an empty template. ...................................................................... core: Fix import VM validation based on an empty template. If template has no disks there is no need to validate for storage correlation between the VM's disks and the Template's disks Change-Id: I6a3d478a1d8aacd25fd00b633e136c29ce7ec99b Bug-Url: https://bugzilla.redhat.com/1392380 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/66249 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a3d478a1d8aacd25fd00b633e136c29ce7ec99b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Fail validation when creating a thin VM with non QCOW ...
by Code Review 08 Nov '16

08 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fail validation when creating a thin VM with non QCOW disks ...................................................................... core: Fail validation when creating a thin VM with non QCOW disks When creating a VM based on template with thin provisioning the disks cannot be RAW as a snapshot is created on top of the base template disk. This patch adds this validation before attempting to create the VM. Bug-Url: https://bugzilla.redhat.com/1362464 Change-Id: I6f0f143e9a9109badc6adce4bf6d3ad733f8fada Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 38 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/66121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0f143e9a9109badc6adce4bf6d3ad733f8fada Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[gh-pages]: Remove travis configuration
by Code Review 08 Nov '16

08 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Remove travis configuration ...................................................................... Remove travis configuration Change-Id: I21cd91ad04527ab35a166418c7e257354c4e9785 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- D .travis.yml 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21cd91ad04527ab35a166418c7e257354c4e9785 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: gh-pages Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Use COPYPOSTFIELDS for HTTP POST data
by Code Review 08 Nov '16

08 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Use COPYPOSTFIELDS for HTTP POST data ...................................................................... Use COPYPOSTFIELDS for HTTP POST data Using POSTFIELDS instead of COPYPOSTFIELDS causes issue when, passing data to setopt as function call instead of variable. The explanation of COPYPOSTFIELDS from pycurl website: COPYPOSTFIELDS behaves as the POSTFIELDS option, but the original data is instead copied by the library, allowing the application to overwrite the original data after setting this option. Change-Id: If9c80abcd331adfbc5fa11f29259d9d44053596e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1392878 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9c80abcd331adfbc5fa11f29259d9d44053596e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0