November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: engine : User is not able to edit profile
by Code Review 06 Nov '16

06 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine : User is not able to edit profile ...................................................................... engine : User is not able to edit profile User who login using group permissions does not exist in the database as of 4.0 SSO rework. This is causing issues with editing user profiles which requires user to exists in the database and also with other operations where the user inherits the permissions of the group. Reintroducing saving users to database resolves these issues. The user info is also updated in users table on user login if the information has changed. Change-Id: Ie83bc67585a6af7276289e7898852e998f68671d Bug-Url: https://bugzilla.redhat.com/1389251 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie83bc67585a6af7276289e7898852e998f68671d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Improve method documentation doc string
by Code Review 05 Nov '16

05 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve method documentation doc string ...................................................................... Improve method documentation doc string This patch improves formatting of method documentation string. Change-Id: I48fd94d10d9fe993cd4de2f1f424af01ab224060 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 059113a2ca1d8649ae15192be8c5b00b3565bf2f) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48fd94d10d9fe993cd4de2f1f424af01ab224060 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Improve method documentation doc string
by Code Review 05 Nov '16

05 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Improve method documentation doc string ...................................................................... Improve method documentation doc string This patch improves formatting of method documentation string. Change-Id: I48fd94d10d9fe993cd4de2f1f424af01ab224060 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48fd94d10d9fe993cd4de2f1f424af01ab224060 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: preserve maintenance status on reboot
by Code Review 04 Nov '16

04 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: preserve maintenance status on reboot ...................................................................... core: preserve maintenance status on reboot Insure that in the case a NGN host is rebooted from Maintenance status it will remain in this status after reboot Change-Id: Ia6bdff5bcf07b063577b1e38bfc9965c7d75bd5f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1383224 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostInternalCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 4 files changed, 23 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6bdff5bcf07b063577b1e38bfc9965c7d75bd5f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Sort auth domains alphabetically
by Code Review 04 Nov '16

04 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Sort auth domains alphabetically ...................................................................... aaa: Sort auth domains alphabetically The authentication domains displayed on login screen should be sorted alphabetically. Change-Id: I47fb174c600b23bbf510bc5302bac9f3a5c540d9 Bug-Url: https://bugzilla.redhat.com/1391646 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/AuthenticationUtils.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47fb174c600b23bbf510bc5302bac9f3a5c540d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Clarify the units of `provisioned_size`
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Clarify the units of `provisioned_size` ...................................................................... Clarify the units of `provisioned_size` This patch changes the example to add a VM disk so that it is clearer that size of a disk has to be specified in bytes. It also changes the example to use a more realistic size, 10 GiB, as it currently the size is 1 MiB, which isn't realistic. Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 8e73bf7af2c9fea227ec8f9e4b84baebd5ea620f) --- M sdk/examples/add_floating_disk.rb M sdk/examples/add_vm_disk.rb 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Clarify the units of `provisioned_size`
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Clarify the units of `provisioned_size` ...................................................................... Clarify the units of `provisioned_size` This patch changes the example to add a VM disk so that it is clearer that size of a disk has to be specified in bytes. It also changes the example to use a more realistic size, 10 GiB, as it currently the size is 1 MiB, which isn't realistic. Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/examples/add_floating_disk.rb M sdk/examples/add_vm_disk.rb 2 files changed, 9 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If21816ca1b180883bb799b32a2fd5857e7e25cd2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to model 4.1.16
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Update to model 4.1.16 ...................................................................... Update to model 4.1.16 The more relevant changes in this new version of the model are the following: * Make `Ip.version` optional. * Add the `active_slave` link to the `Bonding` type. * Add DNS configuration support to `Network` and `NetworkAttachment`. * Add `remote_viewer_connection_file` attribute to the `GraphicsConsole` type, and the `populate_remote_viewer_connection_file` parameter to the operations that retrive the representation ov graphics consoles. * Add the `uses_scsi_reservation` attribute to the `DiskAttachment` type. Change-Id: Ieca68c367fc06845405c39ec49a33cb947ebd36c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/65833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieca68c367fc06845405c39ec49a33cb947ebd36c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to metamodel 1.1.8
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to metamodel 1.1.8 ...................................................................... restapi: Update to metamodel 1.1.8 The more relevant change in this version of the metamodel is the following: * Add `LogicalUnit.discardMaxSize` to the list of exceptions of integer attributes that are represented using `xs:long` instead of `xs:int`. Change-Id: If55b849d6d8581b4719f379d9193467a03eb69e9 Related-To: https://bugzilla.redhat.com/1241106 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If55b849d6d8581b4719f379d9193467a03eb69e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: jsonrpc: version release
by Code Review 04 Nov '16

04 Nov '16

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: jsonrpc: version release ...................................................................... jsonrpc: version release Change-Id: I35144a87330b3280804edbceecc9266befd0c95b Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Verified Sandro Bonazzola: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/66067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35144a87330b3280804edbceecc9266befd0c95b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0