November 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Add example showing how to create a floating disk
by Code Review 04 Nov '16

04 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to create a floating disk ...................................................................... Add example showing how to create a floating disk This patch adds an example that shows how create a disk that isn't attached to any virtual machine, a.k.a. floating disk. Change-Id: Ic9d15b0c042b753d1178ff9f822ece829418e2d1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_floating_disk.py 1 file changed, 68 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9d15b0c042b753d1178ff9f822ece829418e2d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add example showing how to create a floating disk
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example showing how to create a floating disk ...................................................................... Add example showing how to create a floating disk This patch adds an example that shows how create a disk that isn't attached to any virtual machine, a.k.a. floating disk. Change-Id: Ie7b33b98178d2381b1bef2b97349496f7c2bd4f2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 177786e8d6c5bf3839e8ce6ec35389b1a0ce1421) --- A sdk/examples/add_floating_disk.rb 1 file changed, 57 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66064 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b33b98178d2381b1bef2b97349496f7c2bd4f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add example showing how to create a floating disk
by Code Review 04 Nov '16

04 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add example showing how to create a floating disk ...................................................................... Add example showing how to create a floating disk This patch adds an example that shows how create a disk that isn't attached to any virtual machine, a.k.a. floating disk. Change-Id: Ie7b33b98178d2381b1bef2b97349496f7c2bd4f2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_floating_disk.rb 1 file changed, 57 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/66037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7b33b98178d2381b1bef2b97349496f7c2bd4f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add example showing how to create a floating disk
by Code Review 04 Nov '16

04 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to create a floating disk ...................................................................... Add example showing how to create a floating disk This patch adds an example that shows how create a disk that isn't attached to any virtual machine, a.k.a. floating disk. Change-Id: I08f304744bdd5f18bbf7813211692bfe7eff1de6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9404424e9794204b371d33901036124b71f6d144) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddFloatingDisk.java 1 file changed, 74 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08f304744bdd5f18bbf7813211692bfe7eff1de6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add example showing how to create a floating disk
by Code Review 04 Nov '16

04 Nov '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add example showing how to create a floating disk ...................................................................... Add example showing how to create a floating disk This patch adds an example that shows how create a disk that isn't attached to any virtual machine, a.k.a. floating disk. Change-Id: I08f304744bdd5f18bbf7813211692bfe7eff1de6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddFloatingDisk.java 1 file changed, 74 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08f304744bdd5f18bbf7813211692bfe7eff1de6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add ExternalVnicProfileMappings to ImportVmParameters
by Code Review 03 Nov '16

03 Nov '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Add ExternalVnicProfileMappings to ImportVmParameters ...................................................................... engine: Add ExternalVnicProfileMappings to ImportVmParameters Add ExternalVnicProfileMappings and reassignBadMacs to ImportVmParameters. Change-Id: I5cb604a0c1a97da7780cfefee9ba46328efbf66e Bug-Url: https://bugzilla.redhat.com/1277675 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/ExternalVnicProfileMapping.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 3 files changed, 58 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/64536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cb604a0c1a97da7780cfefee9ba46328efbf66e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: The SSO token expiration date should be returned as Long
by Code Review 03 Nov '16

03 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: The SSO token expiration date should be returned as Long ...................................................................... aaa: The SSO token expiration date should be returned as Long The SSO token expiration needs to returned as a long value and should not be cast to int. The token expiration is the Authrization record expiration date returned from the ldap server and should not be confused with engine session expiration date. Change-Id: I59af81778815e4b3c1de1920c397e9123ea01687 Bug-Url: https://bugzilla.redhat.com/1391643 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/66051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59af81778815e4b3c1de1920c397e9123ea01687 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Test VdcQueryType constant existence
by Code Review 03 Nov '16

03 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Test VdcQueryType constant existence ...................................................................... core: Test VdcQueryType constant existence QueryExistenceTest has a test to ensure that any VdcQueryType constant has a corresponding command class. This patch adds the reverse test, scanning the relevant packages using org.reflections.Reflections and verifying that each command class has a corresponding constant in VdcQueryType. Change-Id: Icb9fbc1c3215a9e01d27b29e2ac01e092be43aea Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueryExistenceTest.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Objections: Tal Nisan: Fails -- To view, visit https://gerrit.ovirt.org/66048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb9fbc1c3215a9e01d27b29e2ac01e092be43aea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Test VdcActionType constant existence
by Code Review 03 Nov '16

03 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Test VdcActionType constant existence ...................................................................... core: Test VdcActionType constant existence VdcActionTypeTest has a test to ensure that any VdcActionType constant has a corresponding command class. This patch adds the reverse test, scanning the relevant packages using org.reflections.Reflections and verifying that each command class has a corresponding constant in VdcActionType. Change-Id: I4acd826081cf0ec31e1a186f7089d97fabdfaea6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandEnumTestUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VdcActionTypeTest.java 3 files changed, 42 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4acd826081cf0ec31e1a186f7089d97fabdfaea6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove unused MonitorCommand
by Code Review 03 Nov '16

03 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused MonitorCommand ...................................................................... core: Remove unused MonitorCommand Commit a8e1e03 removed VdcActionType#Monitor several years ago. This change made MonitorCommand inaccessible, and the entire call stack, from BLL all the way down to the VdsServer implementations dead code. This patch rectifies this mistake and removes this dead code. Change-Id: If9bbd2d1e5a2b1b05b26b4944056f589c77eaad8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MonitorCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MonitorCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmMonitorCommandVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmMonitorCommandVDSCommand.java 9 files changed, 0 insertions(+), 110 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9bbd2d1e5a2b1b05b26b4944056f589c77eaad8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0