November 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Last build status wasn't string type
by Code Review 01 Nov '16

01 Nov '16

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Last build status wasn't string type ...................................................................... Last build status wasn't string type Checking if last build failed didn't work because function returned object instead of string. Adding a cast to string, fixed it Change-Id: Ie5343e901c9e0ed96f15cc497fdc1496ef02d6d1 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/groovy-scripts/test-ovirt-repo.groovy 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gil Shinar: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5343e901c9e0ed96f15cc497fdc1496ef02d6d1 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: oVirt Live 4.0.5 RC5
by Code Review 01 Nov '16

01 Nov '16

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: oVirt Live 4.0.5 RC5 ...................................................................... oVirt Live 4.0.5 RC5 Change-Id: I2dc316049917d65d613f863be4bf768a0d49dc3a Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65936 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dc316049917d65d613f863be4bf768a0d49dc3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.0.z]: service: Disable stdout capture in systemd
by Code Review 01 Nov '16

01 Nov '16

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: service: Disable stdout capture in systemd ...................................................................... service: Disable stdout capture in systemd Standard output for agent and broker system services disabled to prevent log duplications and keep logging only to the custom log files (agent and broker logs) Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660 Bug-Url: https://bugzilla.redhat.com/1376559 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit d5950ec) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M initscripts/ovirt-ha-agent.service.in M initscripts/ovirt-ha-broker.service.in 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/65907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b49fad3a2a915019231341e64d161aad9d4660 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.0.z Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DownloadImageCommand's package
by Code Review 01 Nov '16

01 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: DownloadImageCommand's package ...................................................................... core: DownloadImageCommand's package Move DownloadImageCommand to the org.ovirt.engine.core.bll.storage.disk.image together with the other image-related command. Change-Id: I20a5a26b3226fdb69e8302db7d5a8086141b0b29 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/DownloadImageCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20a5a26b3226fdb69e8302db7d5a8086141b0b29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Remove redundant message when moving disks from VM...
by Code Review 01 Nov '16

01 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant message when moving disks from VM disk subtab ...................................................................... webadmin: Remove redundant message when moving disks from VM disk subtab Commit e3d029f introduced a message in the move disks popup noting which disks are moving while a VM is running. Prior to that when moving a disks from within the VM disks subtab there was a general warning when moving disks when the VM is running, this general message is redundant and thus removed. Bug-Url: https://bugzilla.redhat.com/-1390543 Change-Id: I7ee926cd02e71e4fece18a1994be99e1d6e68109 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65941 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ee926cd02e71e4fece18a1994be99e1d6e68109 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : User is not able to edit profile
by Code Review 01 Nov '16

01 Nov '16

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine : User is not able to edit profile ...................................................................... engine : User is not able to edit profile User who login using group permissions does not exist in the database as of 4.0 SSO rework. This is causing issues with editing user profiles which requires user to exists in the database and also with other operations where the user inherits the permissions of the group. Reintroducing saving users to database resolves these issues. Change-Id: Ie83bc67585a6af7276289e7898852e998f68671d Bug-Url: https://bugzilla.redhat.com/1389251 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie83bc67585a6af7276289e7898852e998f68671d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant message when moving disks from VM...
by Code Review 01 Nov '16

01 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant message when moving disks from VM disk subtab ...................................................................... webadmin: Remove redundant message when moving disks from VM disk subtab Commit e3d029f introduced a message in the move disks popup noting which disks are moving while a VM is running. Prior to that when moving a disks from within the VM disks subtab there was a general warning when moving disks when the VM is running, this general message is redundant and thus removed. Bug-Url: https://bugzilla.redhat.com/-1390543 Change-Id: I7ee926cd02e71e4fece18a1994be99e1d6e68109 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 0 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ee926cd02e71e4fece18a1994be99e1d6e68109 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Add POSIX domain creation to Data Center "Guide Me"
by Code Review 01 Nov '16

01 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add POSIX domain creation to Data Center "Guide Me" ...................................................................... webadmin: Add POSIX domain creation to Data Center "Guide Me" Bug-Ur: https://bugzilla.redhat.com/1359943 Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 1 file changed, 128 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b26369caea5471af29febd2afecd4b371d5d0c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use filePath.toFile().exists() instead of File.exists()
by Code Review 01 Nov '16

01 Nov '16

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: use filePath.toFile().exists() instead of File.exists() ...................................................................... core: use filePath.toFile().exists() instead of File.exists() Probably not critical, but it is good practice to use `toFile().exists()` because the Files.exists() method can lead to unexpected poor performance on Java 8 [1],[2]. [1] https://sonarqube.com/coding_rules#rule_key=squid%3AS3725 [2] https://bugs.openjdk.java.net/browse/JDK-8153414 Change-Id: I7049f2bdf16368f202f78cf2e9da9dff35fc74ba Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IconLoader.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65915 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7049f2bdf16368f202f78cf2e9da9dff35fc74ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update OVF in storage domains for HE VM edit
by Code Review 01 Nov '16

01 Nov '16

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: core: Update OVF in storage domains for HE VM edit ...................................................................... core: Update OVF in storage domains for HE VM edit Updating hosted engine VM saves OVF to storage domain as well as to the DB. This patch is complementary to: https://gerrit.ovirt.org/#/c/51842 Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Bug-Url: https://bugzilla.redhat.com/1372000 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfDataUpdater.java 2 files changed, 22 insertions(+), 22 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Andrej Krejcir: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib02d41136458677399428c62c8e475b4cb2fcb79 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0