November 2016 - Engine-commits - oVirt List Archives

Change in gerrit-admin[master]: Enable update_tracker for master branch
by Code Review 03 Nov '16

03 Nov '16

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Enable update_tracker for master branch ...................................................................... Enable update_tracker for master branch - Currently we are not updating external tracker info for patches in 'master' branch. - Updating both 'stable' and 'master' branch patches info in Bugzilla (external tracker) Change-Id: Iaddcc513d20fa5f1cd08d236dc7b93925fa4779e Fixes: OVIRT-803 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/update_tracker 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65916 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaddcc513d20fa5f1cd08d236dc7b93925fa4779e Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in gerrit-admin[master]: Enable check_bug_url for master branch
by Code Review 03 Nov '16

03 Nov '16

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Enable check_bug_url for master branch ...................................................................... Enable check_bug_url for master branch - Currently we are not checking bug urls for master branch. - Enabled for master branch and set it to be optional for 'master' branch but mandatory for 'stable' branches. Change-Id: Idf87c24f9c4d21b0b54d95bda9a324ecb35d0354 Fixes: OVIRT-801 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_bug_url 1 file changed, 38 insertions(+), 38 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf87c24f9c4d21b0b54d95bda9a324ecb35d0354 Gerrit-PatchSet: 4 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add the 'active_slave' parameter to Bonding
by Code Review 03 Nov '16

03 Nov '16

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add the 'active_slave' parameter to Bonding ...................................................................... restapi: Add the 'active_slave' parameter to Bonding This patch adds the 'active_slave' parameter to the Bonding struct in the restapi. This enables to check if there is an active slave in a bond, and determine which network interface is the active slave by restapi. This patch requires at least version 4.1.15 of ovirt-engine-api-model. Change-Id: I7084703f5805e670aeca60fcc5146e6bfcbea75e Bug-Url: https://bugzilla.redhat.com/1038550 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Dominik Holler: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65594 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7084703f5805e670aeca60fcc5146e6bfcbea75e Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: support FQDN for server address in brick
by Code Review 03 Nov '16

03 Nov '16

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: gluster: support FQDN for server address in brick ...................................................................... gluster: support FQDN for server address in brick Currently only IP address is supported for gluster bricks with gluster network defined. This fails to sync bricks which are created in CLI using FQDN of the gluster network. This patch address this issue by resolving the FQDN to correct IP address and compare that address with the actual IP address of nic with gluster network Note: This patch will work only if ENGINE can resolve the host address used in the brick to correct IP address in the host. Change-Id: I0c596dcaa119b20135bb56d15ff5f6672875bb41 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/60083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c596dcaa119b20135bb56d15ff5f6672875bb41 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: 'urandom' and 'random' considered equal
by Code Review 03 Nov '16

03 Nov '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: 'urandom' and 'random' considered equal ...................................................................... core: 'urandom' and 'random' considered equal ... in monitoring since current VDSM can't report 'urandom' in getVdsCaps calls yet. This prevents hosts in 4.1+ clusters that require 'urandom' RNG source from becoming non-operational. Bug-Url: https://bugzilla.redhat.com/1374227 Change-Id: I467a0de3fd7ebe187db23f193303a1399432bbd4 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategy.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/65926 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I467a0de3fd7ebe187db23f193303a1399432bbd4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Recreate set_modified hook
by Code Review 03 Nov '16

03 Nov '16

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Recreate set_modified hook ...................................................................... Recreate set_modified hook The new hook is replacing the old set_MODIFIED hook. - It updates only u/s bugs (oVirt classification) - It updates bug status from POST to MODIFIED only for MERGED patches and the bug status should be in POST state. Example: 1 patch status: MERGED bug status: POST result: OK ==> change bug status to MODIFIED Example: 2 patch status: NEW bug status: other (NEW|ASSIGNED|POST|MODIFIED) result: IGNORE Change-Id: I27b48f0a45931a68503bfaec140c7e42ad100d97 Fixes: OVIRT-804 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- A hooks/custom_hooks/change-merged.set_MODIFIED R hooks/custom_hooks/change-merged.set_MODIFIED-not-used D hooks/custom_hooks/change-merged.set_MODIFIED.sh A hooks/custom_hooks/set_modified 4 files changed, 373 insertions(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65942 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27b48f0a45931a68503bfaec140c7e42ad100d97 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add image transfer support.
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add image transfer support. ...................................................................... restapi: Add image transfer support. Add image transfer support. Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransfer.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransferResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3ApiOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ImageTransferMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ImageTransferMapperTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskUploadImageProgressColumn.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 18 files changed, 285 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ebc6dbbf7d869f5a853a1c0822c775a2b5d4369 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: image upload: don't expose resource ID to entity updates.
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: image upload: don't expose resource ID to entity updates. ...................................................................... image upload: don't expose resource ID to entity updates. Resource ID is used for identifying the upload tickets. once the ability of clearing it is exposed for the frontend/REST, it can potentially cause loss of a transfer session, opening up security risks. Remove this member from the image transfer updates entity, and set it as a parameter for the backend ImageTransferUpdater class. Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UploadImageStatusParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/ImageTransferUpdates.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 7 files changed, 24 insertions(+), 79 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee39b43faea82a4737919de0c39acba4b2b60b26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: removed static calls to DbFacade in UploadImage commands
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: removed static calls to DbFacade in UploadImage commands ...................................................................... core: removed static calls to DbFacade in UploadImage commands Introduced ImageTransferUpdater bean: * Contains the logic of UploadImageCommand -> updateEntity. * Injected in UploadImageCommand and UploadImageStatusCommand. * Used in order to avoid static calls to DbFacade. Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Signed-off-by: Daniel Erez <derez(a)redhat.com> Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImageTransferUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageStatusCommand.java 3 files changed, 123 insertions(+), 81 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fcb18033ec113d2387d3d57bc320c94f361e4a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Introduce DiskValidatior#isAttachedToAnyVM
by Code Review 03 Nov '16

03 Nov '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Introduce DiskValidatior#isAttachedToAnyVM ...................................................................... core: Introduce DiskValidatior#isAttachedToAnyVM Add a validation to check if a disk is connected to any VM. Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808 Bug-Url: https://bugzilla.redhat.com/1337077 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 45 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/65956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50fdba592b56db01e7be2b2b1d6086e941d43808 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0