December 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Made mock runner create logs in a safe place
by Code Review 29 Dec '16

29 Dec '16

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Made mock runner create logs in a safe place ...................................................................... Made mock runner create logs in a safe place Recently we made mock_runner.sh create logs in exported-artifacts to make post-build collection scritps consistant. This can fail when the script running inside mock tries to clean up exported-artifacts on it own. In that case, mock_runner.sh can fail because the directories and files it created are not longer there. This patch moves log creation to a safe temporary directory, and moves the logs to exported-artifacts only when mock_runner.sh is finished. Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-992 Change-Id: I5f7f7756c3f44f4bdd6b5f6f40ee3b547b906fdb Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M automation/check-patch.sh M mock_configs/mock_runner.sh 2 files changed, 18 insertions(+), 4 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f7f7756c3f44f4bdd6b5f6f40ee3b547b906fdb Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: set a valid singleQxlPci value for v2v VMs
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: set a valid singleQxlPci value for v2v VMs ...................................................................... engine: set a valid singleQxlPci value for v2v VMs In case of v2v from KVM, the singleQxlPci value of the imported VM was always set to 'true' without any validation (since it isn't read from OVF in case of KVM, it was set to a default value). The singleQxlPci is supported only when the VM's OS is Linux and the Video device type is QXL and only on those cases it should be set to 'true'. Since the singleQxlPci validation is done in updateVm command, in case of a none Linux VM or if video type is not QXL, each update operation via the APIs failed in validation phase. This is the exact senario occured in BZ 1408715. Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Bug-Url: https://bugzilla.redhat.com/1408715 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69185 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: send vm lease on run vm
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: send vm lease on run vm ...................................................................... core: send vm lease on run vm This patch sends the lease that is set for a VM as a device when running a VM. Change-Id: Ie22ab7035b5b0b017adb376d7a7fbc3624a06778 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 17 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69258 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie22ab7035b5b0b017adb376d7a7fbc3624a06778 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: ability to run vms in unknown status
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: ability to run vms in unknown status ...................................................................... core: ability to run vms in unknown status This patch modifies RunVm to be able to run VMs that are in UNKNOWN status. New argument was added to its parameters so this ability will be used only for VMs that are highly available and are configured with a lease (this would be added in a latter patch). Change-Id: I4460de033b2086a1e8c60c41db302eb23f914ef4 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java 5 files changed, 18 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4460de033b2086a1e8c60c41db302eb23f914ef4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add vm leases
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add vm leases ...................................................................... core: add vm leases Add VM lease to the VM and template entities. This field actually contains just the GUID of the storage domain that the lease is set in. Change-Id: I8f84c305509d2eb4eeac8319b953386fa7c23157 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDao.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0680_add_vm_leases.sql M packaging/dbscripts/vm_templates_sp.sql M packaging/dbscripts/vms_sp.sql 10 files changed, 71 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69253 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f84c305509d2eb4eeac8319b953386fa7c23157 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add vm lease on add/edit/import vm
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add vm lease on add/edit/import vm ...................................................................... core: add vm lease on add/edit/import vm Add VM lease in the following flows: Add VM - if we fail to create the lease the VM is not added. Import VM - if we fail to create the lease, the VM is imported without lease. Edit VM - if we fail to create the lease, the VM is not updated. Note that even if we fail to remove the previous lease, we proceed with the update. Change-Id: I7c666a17d664c2b73ea7cfef10987f12b2bc1b5c Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 7 files changed, 58 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c666a17d664c2b73ea7cfef10987f12b2bc1b5c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: remove vm lease on remove vm
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove vm lease on remove vm ...................................................................... core: remove vm lease on remove vm VM lease should be removed when removing its VM. Note that this is a 'best effort' operation - we remove the VM even if we didn't manage to remove its lease. Change-Id: I0cc52f429d91748e759194baf84085a812bd6c59 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmLeaseVDSParameters.java 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cc52f429d91748e759194baf84085a812bd6c59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: auto start vms with lease
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: auto start vms with lease ...................................................................... core: auto start vms with lease When detecting that a host is non-responsive we move the VMs that are supposed to run on that host to Unknown status. This patch adds to that a special treatment for VMs with leases: for each VM with a lease, we will try to run the VM on another host. The lease should prevent us from getting a split-brain. However, we do not want to try to run the VM on each vds monitoring cycle (which is by default every 3 seconds) so we define a config value for setting the frequency of those attempts. Note that when host becomes non-responsive we get network exceptions from several places: 1. calls to refresh host capabilities. 2. calls to poll vms (on statistics iterations). 3. every command that interacts with vdsm. As a result, VdsManager#restartVmsWithLeaseIfNeeded may be called simultaneously from several threads and that may cause us to skip a restart attempt. Thus, adding a lock to ensure mutually exclusive execution of that method. Change-Id: I464f14fe953a6fedfa53d6655eeb31965b5f1579 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 57 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I464f14fe953a6fedfa53d6655eeb31965b5f1579 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add and remove vds commands for vm leases
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add and remove vds commands for vm leases ...................................................................... core: add and remove vds commands for vm leases This patch adds the VDS commands for adding and removing VM leases as a synchronous operations. Change-Id: Ic5c5c22778cc2c31d0f8d27f2200fa728e91e53f Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmLeaseVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddVmLeaseVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RemoveVmLeaseVDSCommand.java 6 files changed, 117 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69254 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5c5c22778cc2c31d0f8d27f2200fa728e91e53f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: remove unneeded query when getting vms to move to unknown
by Code Review 29 Dec '16

29 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: remove unneeded query when getting vms to move to unknown ...................................................................... core: remove unneeded query when getting vms to move to unknown When host monitoring gets a network exception during monitoring of a specific host, it switches this host to maintenance and moves all the VMs running on this host to Unknown. The retrieval of VMs that need to be switched to unknown was composed of two parts: 1. get all the VMs running on the host (their run_on_vds points to that host). 2. get all the VMs that migrate to the host (their migrating_to_vds points to that host) and also are in MigratingTo status. But (2) is redundant since at this phase of the migration run_on_vds must point to the destination host. Therefore, this part is removed. Note: the query for VM dynamics from the database was moved as a preparation for future changes. Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 7 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1727da9d56cf3b21464da913942f115abeb1bd5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0