December 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: EnumSet is not recognized by GWT
by Code Review 29 Dec '16

29 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: EnumSet is not recognized by GWT ...................................................................... engine: EnumSet is not recognized by GWT Change-Id: I5b196649895c400edc17d2214a5412251b6fe6c5 Bug-Url: https://bugzilla.redhat.com/1408843 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ErrataFilter.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b196649895c400edc17d2214a5412251b6fe6c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix standard-ci artifact collection
by Code Review 29 Dec '16

29 Dec '16

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Fix standard-ci artifact collection ...................................................................... Fix standard-ci artifact collection When a project's standard CI scripts run, they place artifacts in the exported-artifacts directory under the project's git clone directory. Jenkins, however, collects artifactes from the exported-artifacts directory under $WORKSPACE. To bridge this gap, there was some code in the standard_*.sh scripts (That are in-charge of invoking mock_runner.sh itself) to move stuff from the project's directory to the worspace directory. That code only ran if mock_runner.sh (And hence the project's own CI script) was successful. This meant that artifact colection in case of failure was impossible. This patch: - Moves the artifact collection to a new script that is run as a post-build step. - Removes the catch-all log collection code from cleanup.sh as that was probably an attempt to work-around the issue explained here. - Made mock_runner.sh log to a path under exported-artifacts so its logs get collected - Consolidates all standard-CI publishers into one standard-publisher - Removed the unneeded extra publisher for the YAML DIFF jobs Change-Id: Ife10ed15afb02333c9fbb92b362b376eafa0c047 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-988 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M automation/jenkins_check_yaml.sh A jobs/confs/shell-scripts/collect_artifacts.sh M jobs/confs/shell-scripts/mock_cleanup.sh M jobs/confs/shell-scripts/standard_build_artifacts.sh M jobs/confs/shell-scripts/standard_build_artifacts_manual.sh M jobs/confs/shell-scripts/standard_check_merged.sh M jobs/confs/shell-scripts/standard_check_patch.sh M jobs/confs/yaml/publishers/exported-artifacts.yaml D jobs/confs/yaml/publishers/html-reports.yaml D jobs/confs/yaml/publishers/mock-cleanup.yaml A jobs/confs/yaml/publishers/standard.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml M jobs/confs/yaml/templates/install-rpm-sanity.yaml M jobs/confs/yaml/templates/repos-check-closure.yaml M jobs/confs/yaml/templates/standard-stage.yaml M mock_configs/mock_runner.sh 16 files changed, 88 insertions(+), 140 deletions(-) Approvals: Eyal Edri: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69194 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife10ed15afb02333c9fbb92b362b376eafa0c047 Gerrit-PatchSet: 6 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SshSoftFencingCommand redundant semicolon
by Code Review 29 Dec '16

29 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: SshSoftFencingCommand redundant semicolon ...................................................................... core: SshSoftFencingCommand redundant semicolon Change-Id: I3425715b991994e1a5a9c62235e81b807343eece Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3425715b991994e1a5a9c62235e81b807343eece Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SshSoftFencingCommand type inference
by Code Review 29 Dec '16

29 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: SshSoftFencingCommand type inference ...................................................................... core: SshSoftFencingCommand type inference Change-Id: I702c70a6c1359c2b902086a93f70ac0be94f5392 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69270 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I702c70a6c1359c2b902086a93f70ac0be94f5392 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: support empty vnic profile mapping
by Code Review 28 Dec '16

28 Dec '16

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: support empty vnic profile mapping ...................................................................... engine: support empty vnic profile mapping Support mapping of an empty external vnic profile in the DR flow. Change-Id: Ica930066f0ae77d9292553272ad5346067ee46cb Bug-Url: https://bugzilla.redhat.com/1408669 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingFinder.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ExternalVnicProfileMappingFinderTest.java 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/69124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica930066f0ae77d9292553272ad5346067ee46cb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Raise SDK error for unknown tags
by Code Review 28 Dec '16

28 Dec '16

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Raise SDK error for unknown tags ...................................................................... Raise SDK error for unknown tags Currently when the SDK tries to read a document that contains an unknonwn tag, for example, a document that is actually HTML, it generates a 'KeyError' because it tries to access a dictionary that doesn't contain that tag as key. In this situation the SDK should instead generate a SDK error explaining that there is no reader for that tag. But that doesn't happen because we are accessing the dictionary with the '[]' operator, which generates the 'KeyError' when the key doesn't exist. To avoid that this patch changes the SDK so that it uses the 'get' method instead, and so that it raises an SDK error instead of an 'Exception'. Change-Id: Ifebb1d5d71dfdb3ccccae9ae0596d9fadc5ed1b9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/reader.py M sdk/tests/test_reader.py 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifebb1d5d71dfdb3ccccae9ae0596d9fadc5ed1b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: rest-api: take max memory from template
by Code Review 28 Dec '16

28 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: rest-api: take max memory from template ...................................................................... rest-api: take max memory from template When editing a pool we fill static properties of the VMs in the pool from their template, like memory size for example. The setting of max memory size was missing, preventing the ability to edit a pool. Change-Id: I45e5e0e387b3bb132a8d647d306ef18cf8c593d4 Bug-Url: https://bugzilla.redhat.com/1408577 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69243 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45e5e0e387b3bb132a8d647d306ef18cf8c593d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: revert "core: set max memory on the fly for existing vm pools"
by Code Review 28 Dec '16

28 Dec '16

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: revert "core: set max memory on the fly for existing vm pools" ...................................................................... revert "core: set max memory on the fly for existing vm pools" This reverts commit 241d12c977ae84680a7e1f032000be6c079ee0ec. The fix should be in REST-API instead. Change-Id: I9dc10d62c502782cb957f71dd15afa5d38b33e6a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolCommand.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69242 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dc10d62c502782cb957f71dd15afa5d38b33e6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removing vdsm ppc64 build for now
by Code Review 28 Dec '16

28 Dec '16

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Removing vdsm ppc64 build for now ...................................................................... Removing vdsm ppc64 build for now Change-Id: I8eeef1062e9b5c4c9bffe942185771a290c19bd2 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8eeef1062e9b5c4c9bffe942185771a290c19bd2 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: set a valid singleQxlPci value for v2v VMs
by Code Review 28 Dec '16

28 Dec '16

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: set a valid singleQxlPci value for v2v VMs ...................................................................... engine: set a valid singleQxlPci value for v2v VMs In case of v2v from KVM, the singleQxlPci value of the imported VM was always set to 'true' without any validation (since it isn't read from OVF in case of KVM, it was set to a default value). The singleQxlPci is supported only when the VM's OS is Linux and the Video device type is QXL and only on those cases it should be set to 'true'. Since the singleQxlPci validation is done in updateVm command, in case of a none Linux VM or if video type is not QXL, each update operation via the APIs failed in validation phase. This is the exact senario occured in BZ 1408715. Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Bug-Url: https://bugzilla.redhat.com/1408715 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/69174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c01d632652e5982cf7d87da8f64e57ebbc6f603 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0