February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-live[ovirt-live-3.6]: ovirt-live-3.6.3_rc4
by sbonazzo＠redhat.com 24 Feb '16

24 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-live-3.6.3_rc4 ...................................................................... ovirt-live-3.6.3_rc4 Change-Id: Idf55b8e263fea6e7d27630e7f1ae604def8a9412 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf55b8e263fea6e7d27630e7f1ae604def8a9412 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: TryBackToAllCinderSnapshots refactor
by laravot＠redhat.com 24 Feb '16

24 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: TryBackToAllCinderSnapshots refactor ...................................................................... engine: TryBackToAllCinderSnapshots refactor Refactor of TryBackToAllCinderSnapshotsCommand flow. Change-Id: I662f9d1fbe0db66abff52a6a00a165c61cad0c60 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneCinderDisksCommandCallback.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/TryBackToAllCinderSnapshotsCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneCinderDisksParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 16 insertions(+), 265 deletions(-) Approvals: Freddy Rolland: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52905 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I662f9d1fbe0db66abff52a6a00a165c61cad0c60 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove CloneCinderDisksCommand
by laravot＠redhat.com 24 Feb '16

24 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: Remove CloneCinderDisksCommand ...................................................................... engine: Remove CloneCinderDisksCommand Remove CloneCinderDisksCommand as it not in use after refactor. Change-Id: I3e00a4f368d3daf3e5f8224cc037383552e709ec Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneSingleCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 3 insertions(+), 159 deletions(-) Approvals: Freddy Rolland: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52865 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e00a4f368d3daf3e5f8224cc037383552e709ec Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Clone Cinder disk refactor - AddVm command
by laravot＠redhat.com 24 Feb '16

24 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: Clone Cinder disk refactor - AddVm command ...................................................................... engine: Clone Cinder disk refactor - AddVm command In AddVmCommand, cloning of Cinder disks is now done directly and not through CloneCinderDisksCommand. The rollback operation of deleting the copied disk in this flow is done in CloneSingleCinderDiskCommand. Change-Id: I5206ca5bb85bcef8168e0ac016c8e2a23af19fca Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java 1 file changed, 28 insertions(+), 18 deletions(-) Approvals: Freddy Rolland: Verified Liron Aravot: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5206ca5bb85bcef8168e0ac016c8e2a23af19fca Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Clone Cinder disk refactor - AddVmTemplate
by laravot＠redhat.com 24 Feb '16

24 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: engine: Clone Cinder disk refactor - AddVmTemplate ...................................................................... engine: Clone Cinder disk refactor - AddVmTemplate In AddVmTemplateCommand, cloning of Cinder disks is now done directly and not through CloneCinderDisksCommand. The rollback operation of deleting the copied disk in this flow is done in CloneSingleCinderDiskCommand. Change-Id: I183788e8cd6a5a540739d2a2474200d8a5157d25 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneCinderDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneSingleCinderDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java 4 files changed, 52 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I183788e8cd6a5a540739d2a2474200d8a5157d25 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in parsing balloon information
by ahadas＠redhat.com 24 Feb '16

24 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in parsing balloon information ...................................................................... core: cleanup in parsing balloon information This patch mainly simplifies VdsBrokerObjectsBuilder#getBalloonInfo. In addition, adding TODO for fixing the balloon info handling. Change-Id: I5ada48ec44c3d6a4e3b9c4a9c096f50f3c47590c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 7 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53925 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ada48ec44c3d6a4e3b9c4a9c096f50f3c47590c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: RemoveStoragePoolCommand comments
by amureini＠redhat.com 24 Feb '16

24 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStoragePoolCommand comments ...................................................................... core: RemoveStoragePoolCommand comments Formatted a comment as a standard java comment, as using Javadoc in the wrong context may break some doclets. Change-Id: Id36924b61b486f86795660e8a57dda3c7611cf53 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/53944 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id36924b61b486f86795660e8a57dda3c7611cf53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: ui: Windows VM name validation is limited to 15 chars in sys...
by tnisan＠redhat.com 24 Feb '16

24 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: ui: Windows VM name validation is limited to 15 chars in sysprep ...................................................................... ui: Windows VM name validation is limited to 15 chars in sysprep Bug-Url: https://bugzilla.redhat.com/1308778 Change-Id: Id7a443635ffc510152f4727f86bfe519d77c13e8 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 5 files changed, 35 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Passed CI tests Shahar Havivi: Verified -- To view, visit https://gerrit.ovirt.org/53956 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7a443635ffc510152f4727f86bfe519d77c13e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract balloon related code from vm-analyzer
by ahadas＠redhat.com 24 Feb '16

24 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract balloon related code from vm-analyzer ...................................................................... core: extract balloon related code from vm-analyzer VmAnalyzer should (ideally) take a VM that was reported by VDSM, compare it to the previous information we have for that VM and analyze the difference. However, the analyzer currently does more than that and therefore is not easy to maintain. In this patch things that are related to monitoring balloon information are extracted from VmAnalyzer to a new class called BalloonMonitoring. The benefits are: 1. Less not-that-related code in VmAnalyzer and one less DAO to pass to it. 2. No use of static fields in VmAnalyzer (VmsMonitoring is already a singleton). 3. We get to the point where the dynamic data of the VM is persisted to the database faster - we eliminate a call to the DAO per-VM before the data is flushed into the database. This is now done after the important information is saved into the database. Change-Id: I3ccdab942209ea83f7803f4736cc49f371aa23dc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/BalloonMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 3 files changed, 142 insertions(+), 53 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ccdab942209ea83f7803f4736cc49f371aa23dc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: limit sysprep net-bios name to 15 chars
by tnisan＠redhat.com 24 Feb '16

24 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: limit sysprep net-bios name to 15 chars ...................................................................... core: limit sysprep net-bios name to 15 chars Change-Id: I282940ef6a1dc8b3842236e6eeb0cae80f918539 Bug-Url: https://bugzilla.redhat.com/1308778 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Shahar Havivi: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53955 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I282940ef6a1dc8b3842236e6eeb0cae80f918539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0