April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: restapi: BackendTemplateDiskResource.copy() - pass the disk id
by tnisan＠redhat.com 07 Apr '16

07 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: BackendTemplateDiskResource.copy() - pass the disk id ...................................................................... restapi: BackendTemplateDiskResource.copy() - pass the disk id Currently the callers of MoveOrCopyDisk command always pass the disk id to the command, an exception is BackendTemplateDiskResource.copy(). This patch set the disk id on the passed parameters. Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324363 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Passed CI tests Ori Liel: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/55727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant unlock call in image upload failure.
by derez＠redhat.com 07 Apr '16

07 Apr '16

Daniel Erez has submitted this change and it was merged. Change subject: core: remove redundant unlock call in image upload failure. ...................................................................... core: remove redundant unlock call in image upload failure. In BaseImagesCommand, Calling unLockImage() only calls setImageStatus(ImageStatus.OK). since in image upload failure handling we are calling setImageStatus(ImageStatus.ILLEGAL) right after unLockImage(), there is no point calling unLockImage(). Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/55624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12f9dc64e1ef14d655120251334ea1dc0be74c77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: webadmin: fix memory leak in alerts / events footer
by tnisan＠redhat.com 07 Apr '16

07 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix memory leak in alerts / events footer ...................................................................... webadmin: fix memory leak in alerts / events footer Fixed a large memory leak in alerts and events footer. Each table has a 'dismiss' column and cell. The cells were holding references to ModelProviders, which created a circular reference. These tables also update every 5 seconds, so that was a ton of DOM nodes that were detached and not GC-able. Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Bug-Url: https://bugzilla.redhat.com/1294678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> (cherry picked from commit c6c6a37c0cfbf7aaa770a4bba03ceddaa26c1cc0) --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 5 files changed, 54 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55789 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: userportal, webadmin: use a custom patched bootstrap.js
by tnisan＠redhat.com 07 Apr '16

07 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal, webadmin: use a custom patched bootstrap.js ...................................................................... userportal, webadmin: use a custom patched bootstrap.js Temporarily switch to a custom patched bootstrap.js. Bootstrap 3.3.4 - 3.3.6 have a memory leak in the tooltips that we are using extensively. It will take a while to get that fixed upstream, so for now let's include the fix locally. I addded a GWT-TODO so we remember to switch back to upstream when its fixed. Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a X-Ref: https://github.com/twbs/bootstrap/issues/17973#issuecomment-202648725 Bug-Url: https://bugzilla.redhat.com/1294678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> (cherry picked from commit 4158ad8ec9f4c4b22188de7c1ed6f17d00b9119b) --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/javascripts.tag A packaging/branding/ovirt.brand/bootstrap-3.3.6-custom.js 2 files changed, 2,365 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6e423738fa2905b24ae448bd870dd1b375b250a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix monitoring hibernation flow
by ahadas＠redhat.com 07 Apr '16

07 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix monitoring hibernation flow ...................................................................... core: fix monitoring hibernation flow Remove set of VmDynamic to save to null that is unneeded anymore. Change-Id: I3ed497a28ca99fa54f619e05cf403f13262dc2d2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ed497a28ca99fa54f619e05cf403f13262dc2d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: fix memory leak in alerts / events footer
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: fix memory leak in alerts / events footer ...................................................................... webadmin: fix memory leak in alerts / events footer Fixed a large memory leak in alerts and events footer. Each table has a 'dismiss' column and cell. The cells were holding references to ModelProviders, which created a circular reference. These tables also update every 5 seconds, so that was a ton of DOM nodes that were detached and not GC-able. Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Bug-Url: https://bugzilla.redhat.com/1294678 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractImageButtonCell.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/AlertListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 5 files changed, 54 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0ede93316863258f57619ce3e229417b4420e33 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Update to version 4.0.12 of model and 1.0.7 of metamodel
by juan.hernandez＠redhat.com 06 Apr '16

06 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to version 4.0.12 of model and 1.0.7 of metamodel ...................................................................... Update to version 4.0.12 of model and 1.0.7 of metamodel This patch updates the SDK to use the latest released versions of the model and metamodel. Change-Id: If1fade28837e1051971b144a6de9581df6918293 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml M sdk/pom.xml 2 files changed, 6 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1fade28837e1051971b144a6de9581df6918293 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Update to version 4.0.12 of model and 1.0.7 of metamodel
by juan.hernandez＠redhat.com 06 Apr '16

06 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Update to version 4.0.12 of model and 1.0.7 of metamodel ...................................................................... Update to version 4.0.12 of model and 1.0.7 of metamodel This patch updates the SDK to use the latest released versions of the model and metamodel. Change-Id: Iebd7b34987c30d561f5433ff1196e6975ce126ab Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D generator/src/main/java/org/ovirt/sdk/ruby/Main.java M pom.xml M sdk/pom.xml 3 files changed, 7 insertions(+), 43 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55774 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebd7b34987c30d561f5433ff1196e6975ce126ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.5]: v2v: Set disk's boot flag after conversion
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: v2v: Set disk's boot flag after conversion ...................................................................... v2v: Set disk's boot flag after conversion Disk's boot flag is determined in ConvertVmCommand when disk information is already written into DB. Because of that the boot flag needs to be written after that in a separate call. Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308914 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoImpl.java M packaging/dbscripts/base_disks_sp.sql 5 files changed, 45 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/55674 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9603163bfd03bfe248ebfdd227e4a9087568706 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.5 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Name validation invalidates the General tab
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Name validation invalidates the General tab ...................................................................... webadmin: Name validation invalidates the General tab When validation of VM Name fails in the Edit VM/Template/Pool Dialog, the "General" tab is marked as invalid and gets focus. Change-Id: Ib2de0d635df993db49dcd64fff5e5b5069f35baa Bug-Url: https://bugzilla.redhat.com/1314417 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 7 files changed, 12 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/55741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2de0d635df993db49dcd64fff5e5b5069f35baa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0