April 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Fixed issue with DB upgrade job not fetching
by bkorren＠redhat.com 06 Apr '16

06 Apr '16

Barak Korren has submitted this change and it was merged. Change subject: Fixed issue with DB upgrade job not fetching ...................................................................... Fixed issue with DB upgrade job not fetching Becuase of the strange way Jenkins was configuring Git, the upgrade job was not really fetching remote branches, so it failed to checkout the branch it needed to test against Change-Id: I2d1c88eb1a409166416a9a6ffe41a0926d909328 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/shell-scripts/ovirt-engine_upgrade-db.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Looks good to me Eyal Edri: Ready for merge Barak Korren: Verified; Ready for review Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me -- To view, visit https://gerrit.ovirt.org/54978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d1c88eb1a409166416a9a6ffe41a0926d909328 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendDiskResource.testCopyBySdName() - verify Ima...
by laravot＠redhat.com 06 Apr '16

06 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: restapi: BackendDiskResource.testCopyBySdName() - verify ImageGroupId ...................................................................... restapi: BackendDiskResource.testCopyBySdName() - verify ImageGroupId The test should verify that the correct ImageGroupId is passed as well Change-Id: I44601a2675767b543847d8347e52f3f0fe9dcc41 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44601a2675767b543847d8347e52f3f0fe9dcc41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendDiskResource.testCopyBySdId() - verify Image...
by laravot＠redhat.com 06 Apr '16

06 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: restapi: BackendDiskResource.testCopyBySdId() - verify ImageGroupId ...................................................................... restapi: BackendDiskResource.testCopyBySdId() - verify ImageGroupId The test should verify that the correct ImageGroupId is passed as well Change-Id: Ie7c74a341ed065f1e3dca9f093cb13c69c65c9c8 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ori Liel: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7c74a341ed065f1e3dca9f093cb13c69c65c9c8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: BackendTemplateDiskResource.copy() - pass the disk id
by laravot＠redhat.com 06 Apr '16

06 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: restapi: BackendTemplateDiskResource.copy() - pass the disk id ...................................................................... restapi: BackendTemplateDiskResource.copy() - pass the disk id Currently the callers of MoveOrCopyDisk command always pass the disk id to the command, an exception is BackendTemplateDiskResource.copy(). This patch set the disk id on the passed parameters. Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324363 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Ori Liel: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia99e06feb7d67769c2d831a140e869d8d7116744 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: build: post ovirt live 4.0.0 alpha1
by sbonazzo＠redhat.com 06 Apr '16

06 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: post ovirt live 4.0.0 alpha1 ...................................................................... build: post ovirt live 4.0.0 alpha1 Change-Id: Ic5468d9a44057c7f88a78ffc3a2a255033504406 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5468d9a44057c7f88a78ffc3a2a255033504406 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Disabled ability to make VM HA on hosted engine
by tnisan＠redhat.com 06 Apr '16

06 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Disabled ability to make VM HA on hosted engine ...................................................................... core: Disabled ability to make VM HA on hosted engine Disabled checkbox for high availability in the Edit VM dialog popup and ability to change the setting via the REST API when the hosted engine option is being used. These options shouldn't be available on hosted engine because hosted engine uses a different HA mechanism than the non-hosted version. Change-Id: I088cf32361cbd2b59e328b8c31b0e63377865251 Bug-Url: https://bugzilla.redhat.com/1305330 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 55 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/53860 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I088cf32361cbd2b59e328b8c31b0e63377865251 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fixed env variables used for building rpms in master and 3.6...
by sbonazzo＠redhat.com 06 Apr '16

06 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fixed env variables used for building rpms in master and 3.6 upgrade jobs ...................................................................... Fixed env variables used for building rpms in master and 3.6 upgrade jobs Change-Id: I8406461bb26b1755dcb1e7193d9f55c178f523d9 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- M jobs/ovirt-engine_upgrade_to_3.6/build_engine_rpm.sh M jobs/ovirt-engine_upgrade_to_master/build_engine_rpm.sh 2 files changed, 48 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Passed CI tests; Ready for merge Sharon Naftaly: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/55506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8406461bb26b1755dcb1e7193d9f55c178f523d9 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add vm pool flow callbacks usage
by laravot＠redhat.com 06 Apr '16

06 Apr '16

Liron Aravot has submitted this change and it was merged. Change subject: core: add vm pool flow callbacks usage ...................................................................... core: add vm pool flow callbacks usage This patch adjusts the add vm pool flow to use callbacks correctly which solves the tasks/jobs problems for that flow. Change-Id: I18c2f2c6982913dc9cd26780d11985723a7f93fe Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1310426 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 3 files changed, 17 insertions(+), 0 deletions(-) Approvals: Shmuel Leib Melamud: Verified; Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Liron Aravot: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c2f2c6982913dc9cd26780d11985723a7f93fe Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix of "<UNKNOWN>" in importing VM audit log
by ahadas＠redhat.com 06 Apr '16

06 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Fix of "<UNKNOWN>" in importing VM audit log ...................................................................... core: Fix of "<UNKNOWN>" in importing VM audit log Fix "Clusters" -> "Cluster". The entry in values map comes from ImportVmCommand .getJobMessageProperties() -> VdcObjectType.Cluster.name() .toLowerCase() Change-Id: If39cfe5d78ce0c82b1ac345e099a97fc1705de75 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If39cfe5d78ce0c82b1ac345e099a97fc1705de75 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Remove the action version map notion
by amureini＠redhat.com 05 Apr '16

05 Apr '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove the action version map notion ...................................................................... engine: Remove the action version map notion The action version map is a (now outdated) mapping between action types (constants from VdcActionType) and the minimal cluster/DC levels required to execute them. This mechanism has several inherit drawbacks: * It's a parallel effort to the FeatureSupported, splitting the same logic to two places, making the codebase harder to follow and understand. * It's checked in CommandBase's infrastructure, for every command run, adding a performance and complexity penalty to even to (most of the) commands that don't need it. * It returns a generic message, with no option for a specific feature to add its custom message. Versions 3.5 and 3.6, with their abundance of new features did not add a thing to the action version map, reinforcing the notion that this feature is being phased out in favor of the more modern FeatureSupported infrastructure. In 4.0, as the support for 3.4 (and lower) DC/clusters was removed, this feature remains a mute point, a check that always succeeds. This patch finishes the job and removes this feature entirely. The patch removes the following: 1. The ActionVersionMap business entity 2. The action_version_map database table and all the stored procedures and DAO methods referencing it, including their tests 3. The now unused GetCommandsCompatibilityVersionsQuery that exposes this information to the frontend and the tooling around it Change-Id: I97d4345363e1d47c4570f6bbf61a0e07f1052419 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetCommandsCompatibilityVersionsQueryTest.java M backend/manager/modules/common/exclude-filters.xml D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/CommandVersionsInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ActionGroupDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java D packaging/dbscripts/action_version_map_sp.sql A packaging/dbscripts/upgrade/04_00_0410_drop_action_group_map.sql 16 files changed, 2 insertions(+), 455 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97d4345363e1d47c4570f6bbf61a0e07f1052419 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0