May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Mappers for VmBase.customCompatibilityVersion
by ahadas＠redhat.com 09 May '16

09 May '16

Arik Hadas has submitted this change and it was merged. Change subject: restapi: Mappers for VmBase.customCompatibilityVersion ...................................................................... restapi: Mappers for VmBase.customCompatibilityVersion Added mappers for VmBase.customCompatibilityVersion. In addition, added a lacking mapper for Version, fixed the existing mapper and modified Cluster and DataCenter mappers to use it, instead of constructing Version object by hand. Change-Id: I1748b71254d280e029784f86a8322306f13a20ae Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VersionMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmBaseMapper.java 5 files changed, 28 insertions(+), 24 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified -- To view, visit https://gerrit.ovirt.org/56277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1748b71254d280e029784f86a8322306f13a20ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Added icon to indicate host running the HE VM
by rgolan＠redhat.com 09 May '16

09 May '16

Roy Golan has submitted this change and it was merged. Change subject: webadmin: Added icon to indicate host running the HE VM ...................................................................... webadmin: Added icon to indicate host running the HE VM Added an icon to the additional status column of the host main tab to indicate on which host the hosted engine VM is running. Depends on: https://gerrit.ovirt.org/#/c/55669/ Change-Id: Ic66c6e6099a733082c4577e1c0bd55e097edb3e3 Bug-Url: https://bugzilla.redhat.com/1308861 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostAdditionalStatusColumn.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/55675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic66c6e6099a733082c4577e1c0bd55e097edb3e3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix handling of migrating vm reported down on source host
by ahadas＠redhat.com 09 May '16

09 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix handling of migrating vm reported down on source host ...................................................................... core: fix handling of migrating vm reported down on source host The check whether a VM runs on a monitored host should now be using VmAnalyzer#isVmRunningInDatabaseOnMonitoredHost instead of checing if dbVm is null. Change-Id: Ic8fa7bc4d50127a7a4d20cf730ebe90f4af8da9e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/57239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fa7bc4d50127a7a4d20cf730ebe90f4af8da9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fixed HTTP error code for host name duplication error.
by oliel＠redhat.com 09 May '16

09 May '16

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fixed HTTP error code for host name duplication error. ...................................................................... restapi: Fixed HTTP error code for host name duplication error. Changed the HTTP error code for "host name is allready taken" from BAD_PARAMETERS to CONFLICT Change-Id: I01c198021689d6647aeb14e8bbc75d27aa23e39e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1308563 Signed-off-by: borod108 <bodnopoz(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Boris Odnopozov: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57192 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c198021689d6647aeb14e8bbc75d27aa23e39e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Boris Odnopozov <bodnopoz(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: remote_engine: Allow chmod/chown
by sbonazzo＠redhat.com 09 May '16

09 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: remote_engine: Allow chmod/chown ...................................................................... packaging: setup: remote_engine: Allow chmod/chown Allow changing owner/group/mode on a file copied to a remote engine server. Change-Id: I0577daf1c48a0d4e787b527560db423821765a25 Bug-Url: https://bugzilla.redhat.com/1318665 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/remote_engine.py M packaging/setup/ovirt_engine_setup/remote_engine_base.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_manual_files.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py 4 files changed, 51 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/57047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0577daf1c48a0d4e787b527560db423821765a25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add ability to check if a VDS is hosting the HE VM
by rgolan＠redhat.com 09 May '16

09 May '16

Roy Golan has submitted this change and it was merged. Change subject: engine: Add ability to check if a VDS is hosting the HE VM ...................................................................... engine: Add ability to check if a VDS is hosting the HE VM Add a property to the VDS entity that tracks whether a given host is hosting the hosted engine VM. The property is calculated and populated in the VDS view and is not persisted. This approach provides the simplest way to get this information into the VDS entity since the Java 1.7 limitation on classes in the common package prevents using convenience methods available elsewhere in the code base. The change to the VDS view created no significant performance issues when tested locally and at scale. Change-Id: I7e2609f59e588c6ab9279b74312b68dc5af06d5a Bug-Url: https://bugzilla.redhat.com/1308861 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDaoTest.java M packaging/dbscripts/create_views.sql 4 files changed, 127 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e2609f59e588c6ab9279b74312b68dc5af06d5a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix typo in an error message string
by tjelinek＠redhat.com 09 May '16

09 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: fix typo in an error message string ...................................................................... webadmin: fix typo in an error message string Fix typo in an error message for message constant: windowsHostNameInfo Bug-Url: https://bugzilla.redhat.com/1331939 Change-Id: Ie656c0e4eaec47d1cdeac9dc6c04a056f0df51c1 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie656c0e4eaec47d1cdeac9dc6c04a056f0df51c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Move DBTransaction to common
by Shirly Radco 09 May '16

09 May '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Move DBTransaction to common ...................................................................... packaging: setup: Move DBTransaction to common so that it runs also in cleanup. Bug-Url: https://bugzilla.redhat.com/1328860 Change-Id: I9c620d4c5e5842249fa193e02c8fb76e5521ff78 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/engine_connection.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/engine_connection.py 2 files changed, 40 insertions(+), 41 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56458 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c620d4c5e5842249fa193e02c8fb76e5521ff78 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ioprocess: add fc23 build
by sbonazzo＠redhat.com 09 May '16

09 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ioprocess: add fc23 build ...................................................................... ioprocess: add fc23 build Change-Id: If37c46a96b7402ededac0b2c58c7207a37f5fb84 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ioprocess/ioprocess_create-rpms.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If37c46a96b7402ededac0b2c58c7207a37f5fb84 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publish-rpms-nightly-3.6: add cockpit-ovirt
by sbonazzo＠redhat.com 09 May '16

09 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: publish-rpms-nightly-3.6: add cockpit-ovirt ...................................................................... publish-rpms-nightly-3.6: add cockpit-ovirt cockpit-ovirt is needed by NGN, in tech preview for 3.6 Change-Id: I02b8891af6561a5e35d446619e3032e7e85fb66d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b8891af6561a5e35d446619e3032e7e85fb66d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0