July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: continue refactoring VmInfoBuilder
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: continue refactoring VmInfoBuilder ...................................................................... core: continue refactoring VmInfoBuilder * Move VmInfoBuilder related classes to a separate package in order to define and enforce the proper visiblity. * Rename VmInfoBuilder to VmInfoBuilderImpl. * Extract VmInfoBuilder interface and make other classes to know only that. * Collapse VmInfoBuilder into its base class as that is the single existent derrivative. Change-Id: I9fa380ee56e74c46f8f6319ce4439563868506db Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/DiskImageByBootAndSnapshotComparator.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilder.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderFactory.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VnicProfileProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderFactoryTest.java 15 files changed, 816 insertions(+), 758 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa380ee56e74c46f8f6319ce4439563868506db Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: change labels ovirt-appliance build can run on
by eedri＠redhat.com 14 Jul '16

14 Jul '16

Eyal Edri has submitted this change and it was merged. Change subject: change labels ovirt-appliance build can run on ...................................................................... change labels ovirt-appliance build can run on Change-Id: I2e03a15a504a3d90c21ea4353ba77e4d598d6142 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests Anatoly Litovsky: Looks good to me -- To view, visit https://gerrit.ovirt.org/60736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e03a15a504a3d90c21ea4353ba77e4d598d6142 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: removing el7 checks from 3.6
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: removing el7 checks from 3.6 ...................................................................... removing el7 checks from 3.6 3.6 is EOL, and el6 is the most supported platform for it, so dropping el7 checks (keeping builds) to allow adding more tests on 4.0 and master Change-Id: I4077544e2f444275a6a21b98ca6aedf9eeca80b0 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4077544e2f444275a6a21b98ca6aedf9eeca80b0 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: Filter orphaned Host Devieces on refresh
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: backend: Filter orphaned Host Devieces on refresh ...................................................................... backend: Filter orphaned Host Devieces on refresh In some hotplug scenarios (especially those related to SCSI devices) it can happen that libvirt reports to VDSM an internally inconsistent list of devices, namely that the parent_device points to a device not in the list or is empty altogether. Those cases violate the DB constraint imposed on the host_device and cause the RefreshHostDevicesCommand transaction to fail. Since those cases are impossible to handle at lower layers and we need to maintain consistend view of the host devices for our main business logic, we now ignore those invalid devices in the hostdev refresh cycle. Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315100 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommandTest.java 2 files changed, 118 insertions(+), 4 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I520d7b6cc7ef099da7b6a67381a7cdc8d2ae0e64 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix WELD-001410
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: engine: fix WELD-001410 ...................................................................... engine: fix WELD-001410 Make NumaValidator Singleton instead of ApplicationScoped. This fixes "WELD-001410: The injection point has non-proxyable dependencies". Change-Id: Ie747dda3d8664116ab8d766b60f40bca8ff10d95 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Arik Hadas: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie747dda3d8664116ab8d766b60f40bca8ff10d95 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: Revert "jsonrpc: version bump"
by oourfali＠redhat.com 14 Jul '16

14 Jul '16

Oved Ourfali has submitted this change and it was merged. Change subject: Revert "jsonrpc: version bump" ...................................................................... Revert "jsonrpc: version bump" This reverts commit 01df3ed5410847639bcbfe8d1d37981a26e5c708. Version 1.1.13 causes issues. We need to work with 1.1.12. Change-Id: I993d57661d234aabf0a3fb4363ab09fe30e3488a Bug-Url: https://bugzilla.redhat.com/1349353 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M ovirt-engine.spec.in M pom.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eyal Edri: Passed CI tests Oved Ourfali: Verified Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I993d57661d234aabf0a3fb4363ab09fe30e3488a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-extension-logger-log4j: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-logger-log4j: move from fc22 to fc24 ...................................................................... ovirt-engine-extension-logger-log4j: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 - use 4.0 repos for 4.0 jobs Change-Id: Ic05a0810c1fdc151dca177d3eae3beb1e11a9d1b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60737 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic05a0810c1fdc151dca177d3eae3beb1e11a9d1b Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-misc: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-misc: move from fc22 to fc24 ...................................................................... ovirt-engine-extension-aaa-misc: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 - added 4.0 target Change-Id: Ieb25effe7058c47b779de5322066a648d64f3cf4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-misc/ovirt-engine-extension-aaa-misc_create-rpms.yaml 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Martin Peřina: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60735 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb25effe7058c47b779de5322066a648d64f3cf4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-ldap: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-ldap: move from fc22 to fc24 ...................................................................... ovirt-engine-extension-aaa-ldap: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 Change-Id: Ib21ad1015085cc330721e2535e1551f2ddde9d7b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib21ad1015085cc330721e2535e1551f2ddde9d7b Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refine DAO dependecies of VmInfoBuilder
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refine DAO dependecies of VmInfoBuilder ...................................................................... core: refine DAO dependecies of VmInfoBuilder The change substitutes DbFacade use by the fine defined specific DAO dependencies in VmInfoBuilder+Utils. Change-Id: Ie883de67e7ed53c35bedc258d407e826ca318aa8 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/factory/VmInfoBuilderFactory.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuildUtilsTest.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/factory/VmInfoBuilderFactoryTest.java 5 files changed, 173 insertions(+), 117 deletions(-) Approvals: Arik Hadas: Looks good to me, approved; Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58952 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie883de67e7ed53c35bedc258d407e826ca318aa8 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0