July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: make VmInfoBuilder non-static
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: make VmInfoBuilder non-static ...................................................................... core: make VmInfoBuilder non-static * make VmInfoBuilder non-static * extract stateless part into VmInfoBuildUtils * make the new stateless class non-static too * introduce VmInfoBuilderFactory Change-Id: I036630301af44b2a2bfe3cea2903ec855960789d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/factory/VmInfoBuilderFactory.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuildUtilsTest.java 9 files changed, 553 insertions(+), 434 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I036630301af44b2a2bfe3cea2903ec855960789d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-extension-aaa-jdbc: moved from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-extension-aaa-jdbc: moved from fc22 to fc24 ...................................................................... ovirt-engine-extension-aaa-jdbc: moved from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 Change-Id: I6ada270b0c0f71e4b59cf5880e83fa4a55451ab9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Martin Peřina: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ada270b0c0f71e4b59cf5880e83fa4a55451ab9 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine-cli: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine-cli: move from fc22 to fc24 ...................................................................... ovirt-engine-cli: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 Change-Id: Ibb17244755106f28c07a0022003b152300801018 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb17244755106f28c07a0022003b152300801018 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Update the OVF store when hosted engine VM is edited
by tnisan＠redhat.com 14 Jul '16

14 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Update the OVF store when hosted engine VM is edited ...................................................................... core: Update the OVF store when hosted engine VM is edited Retrigger the ovf update from the UpdateVmCommand when the hosted engine VM was edited. This is needed to persist the hosted engine VM configuration as soon as possible in case the ovirt-hosted-engine-agent needs to restart the engine VM with the proper settings. There is still a very slight chance of hitting a race condition (when the regularly scheduled OVF updater processes the hosted engine VM at the exact same moment as the triggered job), but the VM will be saved during the next OVF update anyway. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1343991 Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 7e92bd44e17ded6831eceee1610e1b3616c9c505) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I121a9f587b2a85bdd4b366f07b040dc85fa515cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: move from fc22 to fc24 ...................................................................... vdsm: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 Change-Id: Ifce815087c649404b44f657911702735c53f75c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 10 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifce815087c649404b44f657911702735c53f75c3 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: jasper-reports: dropping fedora support
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: jasper-reports: dropping fedora support ...................................................................... jasper-reports: dropping fedora support dropping fedora support. This package is used only by reports which is currently available only on 3.6 for el6 and el7. Change-Id: Ieb94af018b325bc4df1ea60e856c4df567a7f886 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/jasper-reports/jasper-reports_create-rpms.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60723 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb94af018b325bc4df1ea60e856c4df567a7f886 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-log-collector: move from fc22 to fc24
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-log-collector: move from fc22 to fc24 ...................................................................... ovirt-log-collector: move from fc22 to fc24 - dropped fc22 gone EOL - moved master to fc24 - use 4.0 branch for 4.0 jobs Change-Id: I41f1efae34d8f1ca09ed4a8b87cb95ad77fda9bb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_standard.yaml 2 files changed, 11 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41f1efae34d8f1ca09ed4a8b87cb95ad77fda9bb Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: make NumaValidator non-static
by ahadas＠redhat.com 14 Jul '16

14 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: make NumaValidator non-static ...................................................................... core: make NumaValidator non-static Change-Id: I7ffdf72b829f42634d336ea5b5be35984009776d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java 11 files changed, 106 insertions(+), 58 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/58950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ffdf72b829f42634d336ea5b5be35984009776d Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: scripts: ensure rpm-build installed
by sbonazzo＠redhat.com 14 Jul '16

14 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: scripts: ensure rpm-build installed ...................................................................... scripts: ensure rpm-build installed Change-Id: I598cc086e2b3cb31c1155fe3477e77bf3f6292ec Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/shell-scripts/build_local_srcrpm.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/60719 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I598cc086e2b3cb31c1155fe3477e77bf3f6292ec Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi:fix overcommit accepts negative values
by rgolan＠redhat.com 14 Jul '16

14 Jul '16

Roy Golan has submitted this change and it was merged. Change subject: restapi:fix overcommit accepts negative values ...................................................................... restapi:fix overcommit accepts negative values Memory over commit in rest API accepts non positive values. the behavior was for all integers from zero and below to set the memory over commit values to 200. A validation was added for the memory over commit value to reject all non positive integers. (0 is a valid value) Change-Id: I560d2275d3deefad960018c557f7c8b6b06bfb94 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301353 Signed-off-by: yquinn <yquinn(a)redhat.com> Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ClusterOperationCommandBaseTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Cluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 86 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/59232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I560d2275d3deefad960018c557f7c8b6b06bfb94 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0