July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: rename getTemplateVolumeType method
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: rename getTemplateVolumeType method ...................................................................... webadmin: rename getTemplateVolumeType method Renamed getTemplateVolumeType to a clearer one by its functionality: getVolumeType. Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: image upload - remove volume type list
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - remove volume type list ...................................................................... webadmin: image upload - remove volume type list Image upload dialog: * Removed 'Allocation Policy' select-box. * Filled volume format select-box with COW/RAW. The patch is making use of an existing logic that infers volume type (getTemplateVolumeType method). I.e. * For file domains: Sparse volume type. * For block domains: Sparse if COW / Preallocated if RAW. Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Allow passing of scheduling policy name for Update ...
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Allow passing of scheduling policy name for Update Cluster ...................................................................... restapi: Allow passing of scheduling policy name for Update Cluster This patch will enable auto-completion for the scheduling policy name in the SDK. Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315657 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/60218 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: resize upload image dialog
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: resize upload image dialog ...................................................................... webadmin: resize upload image dialog Resized 'Upload Image' dialog to accommodate its widgets more properly. Before: http://imgur.com/a/Pyecu After: http://imgur.com/a/KX8ht Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I516d982cf39c94bf1bd4448ef34a32c1dd9f7fcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - align selection button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - align selection button ...................................................................... webadmin: image upload - align selection button Image Upload dialog: align 'Choose File' button properly. Screenshot: http://imgur.com/a/7jRwK Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6ccf5c877f9c6a587523a523cd751c00633df3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: rename getTemplateVolumeType method
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: rename getTemplateVolumeType method ...................................................................... webadmin: rename getTemplateVolumeType method Renamed getTemplateVolumeType to a clearer one by its functionality: getVolumeType. Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13912345e1c4180b5197e0c486315088e59115dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - remove volume type list
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: image upload - remove volume type list ...................................................................... webadmin: image upload - remove volume type list Image upload dialog: * Removed 'Allocation Policy' select-box. * Filled volume format select-box with QCOW/RAW. The patch is making use of an existing logic that infers volume type (getTemplateVolumeType method). I.e. * For file domains: Sparse volume type. * For block domains: Sparse if COW / Preallocated if RAW. Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Upload drop-down menu button
by piotr.kliczewski＠gmail.com 28 Jul '16

28 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Upload drop-down menu button ...................................................................... webadmin: Upload drop-down menu button Added 'Upload' drop-down menu button to Disks tab to consolidate Start/Cancel/Pause resume commands. Before: http://i.imgur.com/yWbcCSO.png After: http://i.imgur.com/v1aCFJe.png Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Bug-Url: https://bugzilla.redhat.com/1360776 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 4 files changed, 33 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33724bc2cfa45cbc63e2d2df8fbdf03dc73c2cd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core : Updates should not be checked on hosts on maintenance
by masayag＠redhat.com 28 Jul '16

28 Jul '16

Moti Asayag has submitted this change and it was merged. Change subject: core : Updates should not be checked on hosts on maintenance ...................................................................... core : Updates should not be checked on hosts on maintenance VdsManager should not check for updates for host if the host is in maintenance. Change-Id: I9ae1a2a0bd0cb63477f491dc5f2bb9def8cc52b4 Bug-Url: https://bugzilla.redhat.com/1343562 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ae1a2a0bd0cb63477f491dc5f2bb9def8cc52b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: FiltersHelper: Remove unused code
by amureini＠redhat.com 27 Jul '16

27 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: FiltersHelper: Remove unused code ...................................................................... core: FiltersHelper: Remove unused code Removed unused members and methods. Change-Id: I3aae45e1bf9b4176357ca807ee21286141482685 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aae45e1bf9b4176357ca807ee21286141482685 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0