July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.2]: webadmin: Hide hosted engine tab when editing host
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Hide hosted engine tab when editing host ...................................................................... webadmin: Hide hosted engine tab when editing host The hosted engine tab in host editing or adding dialog in the ui is only relevant when adding a new host. This patch hides the tab when a host is edited. To achieve this the initialization of the popup window was moved after the host model initialization. This allows setting the visibility for hostedEngineTab in HostPopupView by using the getIsNew method (was already implemented but didn't work since the relevant fields weren't initialized). Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9 Bug-Url: https://bugzilla.redhat.com/1350423 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit bb20845) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/61478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: protection from NPE in the initialization of RunVm
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: protection from NPE in the initialization of RunVm ...................................................................... core: protection from NPE in the initialization of RunVm Need to verify that the VM to run exists before accessing it. Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Bug-Url: https://bugzilla.redhat.com/1360265 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/61447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e3e7ff30777077cb1e96581574c484d7f71d65b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Hide hosted engine tab when editing host
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Hide hosted engine tab when editing host ...................................................................... webadmin: Hide hosted engine tab when editing host The hosted engine tab in host editing or adding dialog in the ui is only relevant when adding a new host. This patch hides the tab when a host is edited. To achieve this the initialization of the popup window was moved after the host model initialization. This allows setting the visibility for hostedEngineTab in HostPopupView by using the getIsNew method (was already implemented but didn't work since the relevant fields weren't initialized). Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9 Bug-Url: https://bugzilla.redhat.com/1350423 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit bb20845) --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/61479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4746dda9fa0a06f0dec1d179639a20e5941e8ec9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: use cluster.dcId if params.dcId isn't set
by piotr.kliczewski＠gmail.com 27 Jul '16

27 Jul '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: use cluster.dcId if params.dcId isn't set ...................................................................... engine: use cluster.dcId if params.dcId isn't set Retrive dcId through VM's cluster if the first isn't supplied in parameters of ImportVmCommand. And make sure that it isn't overriden along th import flow. Change-Id: I055bf8767650006a9baeca22a504c9aaa8bb050d Bug-Url: https://bugzilla.redhat.com/1359668 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java 2 files changed, 29 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/61325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I055bf8767650006a9baeca22a504c9aaa8bb050d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Make sure used is always <= total
by awels＠redhat.com 27 Jul '16

27 Jul '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Make sure used is always <= total ...................................................................... webadmin: Make sure used is always <= total - In certain situations it is possible that the DWH is reporting used > 0 while total = 0. This patch makes sure that used can never be higher than total. Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360403 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/dashboard/GlobalUtilizationResourceSummary.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792c3bebee465bc2a0d80aae7a12a76e7c34ad88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: image upload - remove volume type list
by derez＠redhat.com 27 Jul '16

27 Jul '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: image upload - remove volume type list ...................................................................... webadmin: image upload - remove volume type list Image upload dialog: * Removed 'Allocation Policy' select-box. * Filled volume format select-box with COW/RAW. The patch is making use of an existing logic that infers volume type (getTemplateVolumeType method). I.e. * For file domains: Sparse volume type. * For block domains: Sparse if COW / Preallocated if RAW. Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Bug-Url: https://bugzilla.redhat.com/1359736 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 8 insertions(+), 27 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Allon Mureinik: Looks good to me, approved Amit Aviram: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eae9cc5ec850127e4e0fe7a0a49c76214bcd0bb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Bump to version 4.1.0.alpha1
by omachace＠redhat.com 27 Jul '16

27 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Bump to version 4.1.0.alpha1 ...................................................................... Bump to version 4.1.0.alpha1 This patch bump version to 4.1.0alpha1 so the RPM packages are build with proper versions on master branch. Change-Id: Ia2e6f86c7fa50980b00307c8e8c1b7cd2be96596 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.packages M automation/build-artifacts.sh M packaging/build.sh 3 files changed, 9 insertions(+), 5 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61469 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2e6f86c7fa50980b00307c8e8c1b7cd2be96596 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Allign name of tar archive to pypi package name
by omachace＠redhat.com 27 Jul '16

27 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Allign name of tar archive to pypi package name ...................................................................... Allign name of tar archive to pypi package name This patch changes the pypi package name to ovirt-engine-sdk-python, and so it allign the name of the tar archive and build process. Change-Id: Ib6c9b0d48233733d42d886a301595d9b9ff13a3f Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M packaging/build.sh M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M sdk/setup.py 6 files changed, 11 insertions(+), 12 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61466 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6c9b0d48233733d42d886a301595d9b9ff13a3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Bump version to 4.1.0a0
by omachace＠redhat.com 27 Jul '16

27 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Bump version to 4.1.0a0 ...................................................................... Bump version to 4.1.0a0 Bump master to version 4.1.0a0. Additionally following fixes was done: - Fixed pypi Source URL which was not valid anymore - Fixed spec file URL which was not valid anymore - Fixed setup macro aligning with pypi packages Change-Id: I4e7e16ac029b9a299b7e5cdbc8649ea0421d85b3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M generator/pom.xml M packaging/build.sh M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M pom.xml M sdk/lib/ovirtsdk4/version.py M sdk/pom.xml M sdk/setup.py 10 files changed, 20 insertions(+), 21 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e7e16ac029b9a299b7e5cdbc8649ea0421d85b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Build source RPMs
by omachace＠redhat.com 27 Jul '16

27 Jul '16

Ondra Machacek has submitted this change and it was merged. Change subject: Build source RPMs ...................................................................... Build source RPMs This patch changes the `build.sh` script so that it builds the source RPMs. Change-Id: I5484a7a3020b4b1244d8abc5fc4a6db6d808873b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4c556c6bc8145ca7b28a8c50e34a76b7bb9e3efd) --- M packaging/build.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5484a7a3020b4b1244d8abc5fc4a6db6d808873b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0