August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.3]: webadmin: Rephrase Preview Snapshot warning
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Rephrase Preview Snapshot warning ...................................................................... webadmin: Rephrase Preview Snapshot warning User warning for preview live snapshot originating in different cluster version is rephrased. User needs to explicitely confirm the intention to restore the memory. Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Tal Nisan: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: SuspendedVMClusterEditChecker removed
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: SuspendedVMClusterEditChecker removed ...................................................................... core: SuspendedVMClusterEditChecker removed Prior this change, Cluster Edit dialog displayed warning for suspended VMs when changing cluster level. This warning is no more needed, since it's covered by - more general warning in Cluster Edit - adding nextrun config - and setting temporal custom compatibility level on the VM This patch removes the checker and UI warning. Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 46 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, but someone else must approve Tal Nisan: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: webadmin: Count of affected VMs shown when CL change
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Count of affected VMs shown when CL change ...................................................................... webadmin: Count of affected VMs shown when CL change During Cluster Version change, count of affected (means not in Down state) VMs is displayed. All of them have to be rebooted once the cluster version is changed. Change-Id: I032e1816bbbc07e12f7721bda79cece6e6abf05f Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 5 files changed, 6 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I032e1816bbbc07e12f7721bda79cece6e6abf05f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: Block cluster version change when Snapshot in Preview
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Block cluster version change when Snapshot in Preview ...................................................................... core: Block cluster version change when Snapshot in Preview Block cluster version change in UpdateClusterVersion when there is a VM snapshot in preview. The webadmin shows list such VM names after Cluster Edit dialog. Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62601 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: core: Temporal VM CustCompatVer after Cluster Ver change
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Temporal VM CustCompatVer after Cluster Ver change ...................................................................... core: Temporal VM CustCompatVer after Cluster Ver change During Cluster Version change, set temporarily the VM Custom Compatibility Version. This change is reverted when the VM is rebooted and so the NextRun configuration is applied. Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java 3 files changed, 13 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d4131ccc41fabaac48ed1f21fecbd1fd1a2f43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change DiskVmElement queries to User auth type
by tnisan＠redhat.com 25 Aug '16

25 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change DiskVmElement queries to User auth type ...................................................................... core: Change DiskVmElement queries to User auth type Changed the DiskVmElement querties auth type to User to avoid problems in VM<->disk operations via REST/SDK Bug-Url: https://bugzilla.redhat.com/1369024 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetDiskVmElementsByVmIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java M packaging/dbscripts/disk_vm_element_sp.sql 7 files changed, 112 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90fec692c2f42bef9b6681bff966b63db533cd72 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Fix all null arguments to schedule and canSchedule
by rgolan＠redhat.com 25 Aug '16

25 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: Fix all null arguments to schedule and canSchedule ...................................................................... scheduling: Fix all null arguments to schedule and canSchedule Change-Id: I20b6864e22b1f57a12a9b0ef615629ec94c99d2c Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 4 files changed, 16 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/61558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20b6864e22b1f57a12a9b0ef615629ec94c99d2c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: External scheduler cleanup and modernization
by rgolan＠redhat.com 25 Aug '16

25 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: scheduling: External scheduler cleanup and modernization ...................................................................... scheduling: External scheduler cleanup and modernization There were some changes to the overall engine and scheduling that is nice to have in the external scheduler logic. Most notably support for Java 8 and CDI. The first change is the CDI support. This patch adds the ExternalSchedulerBroker interface and makes the implementation available as @Singleton. Return types of some methods were converted from Pair of Pairs and such to a nice Java class like ScoringResult. Another change is the added support for per-unit weight results. The external scheduler can now report raw weight data for each host and for each policy unit to utilize the selector support we now have in scheduler. Old summed up weight record: [host id, already factored weight] New raw weight record: [host id, raw weight, policy unit name] Both summed up and raw results are supported to maintain compatibility. Change-Id: Id333b614eccad51ca7a61b344df59e143f1bda89 Signed-off-by: Martin Sivák <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBroker.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ScoringResult.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/WeightResultEntry.java 8 files changed, 139 insertions(+), 72 deletions(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id333b614eccad51ca7a61b344df59e143f1bda89 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.5]: Adding build-artifacts-manual.sh script
by didi＠redhat.com 25 Aug '16

25 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages file. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: I2ff6faffa2ba3ab003bfdbf39ce1588c2a8f452e Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.sh 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Sharon Naftaly: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ff6faffa2ba3ab003bfdbf39ce1588c2a8f452e Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: Adding build-artifacts-manual.sh script
by didi＠redhat.com 25 Aug '16

25 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages file. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: I0ae5643424134932f61c01b69ce7114d5b634e34 Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.sh 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Sharon Naftaly: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae5643424134932f61c01b69ce7114d5b634e34 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0