August 2016 - Engine-commits - oVirt List Archives

Change in otopi[otopi-1.5]: filtering hidden responses in machine dialog dialect
by didi＠redhat.com 25 Aug '16

25 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: filtering hidden responses in machine dialog dialect ...................................................................... filtering hidden responses in machine dialog dialect Change-Id: I2811f085183580ae3d415718158d5a2c8c72da28 Bug-Url: https://bugzilla.redhat.com/1369099 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit aecbd50e7cfcf7143774c160792310efba91048d) --- M src/plugins/otopi/dialog/machine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2811f085183580ae3d415718158d5a2c8c72da28 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: added support for isRunOnlyIfAllValidation flag
by ahadas＠redhat.com 25 Aug '16

25 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: added support for isRunOnlyIfAllValidation flag ...................................................................... added support for isRunOnlyIfAllValidation flag Added support for running the runMultipleAction() method with the isRunOnlyIfAllValidation flag. The isRunOnlyIfAllValidation flag existed in code but was not supported (i.e. was always treated as set to false) It was used by Gluster with flag set to true and therefore changed to false to avoid regression and should be tested by them after this fix. Change-Id: Ic3ae6bfd5929d0fd804dae4f55d18e9dd0b1eb8e Bug-Url: https://bugzilla.redhat.com/1364171 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 6 files changed, 42 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3ae6bfd5929d0fd804dae4f55d18e9dd0b1eb8e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: filtering hidden responses in machine dialog dialect
by didi＠redhat.com 24 Aug '16

24 Aug '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: filtering hidden responses in machine dialog dialect ...................................................................... filtering hidden responses in machine dialog dialect Change-Id: I2811f085183580ae3d415718158d5a2c8c72da28 Bug-Url: https://bugzilla.redhat.com/1369099 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/otopi/dialog/machine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2811f085183580ae3d415718158d5a2c8c72da28 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: fix 0cc81c2 regression
by sbonazzo＠redhat.com 24 Aug '16

24 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: publisher: fix 0cc81c2 regression ...................................................................... publisher: fix 0cc81c2 regression Fixing a regression introduced by 0cc81c2e94fb4c1d813b1ff3642abdd6ba7886ea which deleted fc22 jobs without pointing the publisher to the new el7 jobs. Change-Id: I8ab89988956143937906c8d91d2b607463253c0d Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Fabian Deutsch: Looks good to me Sandro Bonazzola: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62794 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ab89988956143937906c8d91d2b607463253c0d Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.3]: packaging: engine-backup: support verify mode
by tnisan＠redhat.com 24 Aug '16

24 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: support verify mode ...................................................................... packaging: engine-backup: support verify mode Bug-Url: https://bugzilla.redhat.com/1369747 Change-Id: I5741a50fecd6a6a4cd143c5042cd81a4d657f602 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 70 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5741a50fecd6a6a4cd143c5042cd81a4d657f602 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: engine-backup: support verify mode
by tnisan＠redhat.com 24 Aug '16

24 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: engine-backup: support verify mode ...................................................................... packaging: engine-backup: support verify mode Bug-Url: https://bugzilla.redhat.com/1369747 Change-Id: I5741a50fecd6a6a4cd143c5042cd81a4d657f602 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 70 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5741a50fecd6a6a4cd143c5042cd81a4d657f602 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adding 4.0 ovirt image test job
by tlitovsk＠redhat.com 24 Aug '16

24 Aug '16

Anatoly Litovsky has submitted this change and it was merged. Change subject: Adding 4.0 ovirt image test job ...................................................................... Adding 4.0 ovirt image test job Change-Id: I5ae9f24babdc8ccbbbb47ff33082f44a46695193 Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Anatoly Litovsky: Verified; Looks good to me; Ready for merge -- To view, visit https://gerrit.ovirt.org/62775 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ae9f24babdc8ccbbbb47ff33082f44a46695193 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.0]: build: ovirt-release40-4.0.3
by sbonazzo＠redhat.com 24 Aug '16

24 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-release40-4.0.3 ...................................................................... build: ovirt-release40-4.0.3 Change-Id: Ie3764cd5713cf1d065928b32f91969290bdfa999 --- M configure.ac M ovirt-release40.spec.in 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62780 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3764cd5713cf1d065928b32f91969290bdfa999 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: improve propriety UUID generation
by mperina＠redhat.com 24 Aug '16

24 Aug '16

Martin Peřina has submitted this change and it was merged. Change subject: improve propriety UUID generation ...................................................................... improve propriety UUID generation UUID generation is not random enough and may generate in some circumstances duplicate UUIDs I was thinking first to use the native PG UUID generator but this seems complex since the UUID generator functions are provided as a PG extension that only a super user DB role can install and even if we handled that in engine-setup, it will solve only local provisioned DB. In this patch I suggest the following improvements to the uuid_generate_v1 function 1) Setting a seed before using the random() function 2) Generating the first 8 characters using the clock timestamp value 3) Improve randomness of other generated values I believe that the above is a pretty simple solution that is sufficient for our needs Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1362459 Signed-off-by: emesika <emesika(a)redhat.com> --- M packaging/dbscripts/create_functions.sql 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3211f7d83ba2b4a37c5d533911ecd0d7f03e58 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, restapi: Report version parts for host's os element
by masayag＠redhat.com 24 Aug '16

24 Aug '16

Moti Asayag has submitted this change and it was merged. Change subject: core,restapi: Report version parts for host's os element ...................................................................... core,restapi: Report version parts for host's os element The version parts of host's os are being parsed and reported properly as parsed from the host os: For RHEL: <os type="RHEL"> <version major="7" minor="2" full_version="7.2 - 9.el7"/> </os> For RHEV-H: <os type="RHEV Hypervisor"> <version major="7" minor="2" full_version="7.2 - 20160711.0.el7ev"/> </os> For ovirt-node: <os type="oVirt Node"> <version major="3" minor="6" full_version="3.6 - 0.999.201608161021.el7.centos"/> </os> Change-Id: Id845c71160f4af3b5bf9474beaaad3540ecafe3d Bug-Url: https://bugzilla.redhat.com/1368134 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OS.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSParserTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OSTest.java 5 files changed, 96 insertions(+), 75 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/62627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id845c71160f4af3b5bf9474beaaad3540ecafe3d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0