August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove redundant things from destroy vm
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove redundant things from destroy vm ...................................................................... core: remove redundant things from destroy vm Clear the assigned numa nodes in ProcessDownVm instead of in DestroyVm. The reason is that destroy VM is an asynchronous operation and the numa nodes should be cleared only when it succeeds. Change-Id: I5b124cdf39f97f7c91a6c53e20eaa44f1ae61ce1 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 2 files changed, 14 insertions(+), 15 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b124cdf39f97f7c91a6c53e20eaa44f1ae61ce1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: Adding build-artifacts-manual.sh script
by rmartins＠redhat.com 22 Aug '16

22 Aug '16

Rafael Martins has submitted this change and it was merged. Change subject: Adding build-artifacts-manual.sh script ...................................................................... Adding build-artifacts-manual.sh script Adding build-artifacts-manual.sh script and related packages and repos files. build-artifacts-manual.sh is used for creating rpms from an existing tarball. It assumes that the tarball already exists in the projects directory and builds srpms and rpms, and moves the files to exported_artifacts directory. Change-Id: If196f18ca30da156bbcfc17ccf3f120c0f62bdab Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com> --- A automation/build-artifacts-manual.packages A automation/build-artifacts-manual.repos A automation/build-artifacts-manual.sh 3 files changed, 25 insertions(+), 0 deletions(-) Approvals: Sharon Naftaly: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62486 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If196f18ca30da156bbcfc17ccf3f120c0f62bdab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: commands that query vms to use only vds id
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: commands that query vms to use only vds id ...................................................................... core: commands that query vms to use only vds id We currently pass a cloned instance of the whole VDS object which is redundant, so changing this to pass only its id. Change-Id: Ie5c68b22bb24710180e74b1eca7f84251c88a927 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmStatsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java 7 files changed, 15 insertions(+), 23 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5c68b22bb24710180e74b1eca7f84251c88a927 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by omachace＠redhat.com 22 Aug '16

22 Aug '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I7cbdcef3fa8a1f4babc45a81a07b945162e79e1a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M generator/pom.xml M pom.xml M sdk/pom.xml 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62660 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cbdcef3fa8a1f4babc45a81a07b945162e79e1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix monitoring of guest agent nics
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix monitoring of guest agent nics ...................................................................... core: fix monitoring of guest agent nics We used to to compare the hash that is being calculated by the engine (of network interfaces reported by the guest agent) with the hash in the dynamic VM data reported by VDSM. The problem is that VDSM doesn't report this hash, therefore it is always zero and therefore we update the dynamic data of a VM that is installed with guest agent on each monitoring cycle. This patch fixes this by changing the mentioned check so the computed hash will be compared to the one that was calculated previously. Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Bug-Url: https://bugzilla.redhat.com/1366786 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38533ac778ffef528340d33cfbb64589d5d49fe8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: log num of running vms only upon change
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: log num of running vms only upon change ...................................................................... core: log num of running vms only upon change The log of the number of running VMs on a host flooded the engine log. Therefore, adding some logic in order to log it only when the number of running VMs on a host is changed. Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Bug-Url: https://bugzilla.redhat.com/1367519 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsStatisticsFetcher.java 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62636 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7184e48d9ca5d87cab1491d58f63628a8a6d997e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Block cluster version change when Snapshot in Preview
by tnisan＠redhat.com 22 Aug '16

22 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Block cluster version change when Snapshot in Preview ...................................................................... core: Block cluster version change when Snapshot in Preview Block cluster version change in UpdateClusterVersion when there is a VM snapshot in preview. The webadmin shows list such VM names after Cluster Edit dialog. Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie929a303805fda75ff32111a57ad142fd30726d1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Switch from cirrus to vga at cluster upgrade
by ahadas＠redhat.com 22 Aug '16

22 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Switch from cirrus to vga at cluster upgrade ...................................................................... core: Switch from cirrus to vga at cluster upgrade VNC/cirrus is switched to VNC/vga when upgrading cluster from 3.6 to 4.0. Change-Id: Ib249ccf07247cd737c295b074bfb6dddb8de5292 Bug-Url: https://bugzilla.redhat.com/1302657 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib249ccf07247cd737c295b074bfb6dddb8de5292 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add Original Template link to Vm
by juan.hernandez＠redhat.com 22 Aug '16

22 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add Original Template link to Vm ...................................................................... restapi: Add Original Template link to Vm The VM resource is enriched for Original Template. Change-Id: I8973ba30ebf29cb91b7849b7fe913d5dcf187809 Bug-Url: https://bugzilla.redhat.com/1333045 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/60457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8973ba30ebf29cb91b7849b7fe913d5dcf187809 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: automation: add isort check
by lveyde＠redhat.com 22 Aug '16

22 Aug '16

Lev Veyde has submitted this change and it was merged. Change subject: automation: add isort check ...................................................................... automation: add isort check Added isort check for python code Change-Id: I4a511edeaf343de1b6cf2201ec77a4ecc3a041cb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/check-patch.req.fc24 A ovirt-engine-setup-plugin-live/.isort.cfg M ovirt-engine-setup-plugin-live/build/python.inc M ovirt-engine-setup-plugin-live/configure.ac 4 files changed, 28 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Looks good to me, approved Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a511edeaf343de1b6cf2201ec77a4ecc3a041cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0