August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[master]: Don't send password using GET and query parameter
by juan.hernandez＠redhat.com 22 Aug '16

22 Aug '16

Juan Hernandez has submitted this change and it was merged. Change subject: Don't send password using GET and query parameter ...................................................................... Don't send password using GET and query parameter Currently when the SDK requests the SSO token it does so using the HTTP GET method, and passing the user name and password as URL parameters. As a result this user name and password are likely stored in the web server access logs. To avoid that issue this patch changes the SDK so that it uses the HTTP POST will the user name and password in the request body. This change isn't compatible with the support for external SSO servers. As the engine doesn't support that at the moment this patch also removes it. It will be re-added in the future, when the engine supports it. Change-Id: I2d18ea2c91ec2ececaab1c6fb2e4da4e50005a4d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D sdk/examples/external_authentication.rb M sdk/lib/ovirtsdk4/http.rb M sdk/spec/spec_helper.rb 3 files changed, 194 insertions(+), 220 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d18ea2c91ec2ececaab1c6fb2e4da4e50005a4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - adding support for command steps
by laravot＠redhat.com 22 Aug '16

22 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - adding support for command steps ...................................................................... core: CommandBase - adding support for command steps Currently the steps and the tasks infrastractures are strongly dependent on each other and different execution steps for internal command are derived from created tasks. Newly added flows are without tasks, this patch adds an infrastrature that each command can leverage to add an execution step by overriding the added method. Change-Id: I15cb8410eb223a7ff387ab6c4fae23292afdac61 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 30 insertions(+), 6 deletions(-) Approvals: Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cb8410eb223a7ff387ab6c4fae23292afdac61 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding progress to Step
by laravot＠redhat.com 22 Aug '16

22 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: adding progress to Step ...................................................................... core: adding progress to Step This patch adds the possibility to save the progress for each step. When a step is accosiated with command that reports progress, it can update it on the step. Change-Id: I506623cd14996aa9c5f874b3e4b99175167354b4 Bug-Url: https://bugzilla.redhat.com/529086 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseGenericDaoTestCase.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/job_sp.sql A packaging/dbscripts/upgrade/04_01_0250_add_progress_column_to_step_table.sql 7 files changed, 41 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I506623cd14996aa9c5f874b3e4b99175167354b4 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding support for step subject entities
by laravot＠redhat.com 22 Aug '16

22 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: adding support for step subject entities ...................................................................... core: adding support for step subject entities This patch adds support for step suject entities, those entities indicates to what the entities the step is related to. The step subject entity contains the entity id, the entity type and the step "weight" in the entity, which will provide us the abillity to calculate the progress of the operations that are being executed on the entity Change-Id: Ibcf695f274e4c6d4a75a80aecffc4be9441507d0 Bug-Url: https://bugzilla.redhat.com/529086 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubjectEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepSubjectEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractSubjectEntityRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobSubjectEntityDaoImpl.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepSubjectEntityDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepSubjectEntityDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/job_sp.sql A packaging/dbscripts/upgrade/04_01_0240_add_step_subject_entites.sql 15 files changed, 344 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/61939 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcf695f274e4c6d4a75a80aecffc4be9441507d0 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest type inference
by amureini＠redhat.com 22 Aug '16

22 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest type inference ...................................................................... core: AddVmCommandTest type inference Change-Id: I410158552351f65dd536e10fe11a63dd53563e52 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 4 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I410158552351f65dd536e10fe11a63dd53563e52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmCommandTest mocking strictness
by amureini＠redhat.com 22 Aug '16

22 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmCommandTest mocking strictness ...................................................................... core: AddVmCommandTest mocking strictness Use anyListOf(Class) instead of anyList() to make the mocking a tad stricter and a tad safer. Change-Id: Iffd36c9fdb2afd6b32abd10e3b27612cf1d9f56d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62639 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffd36c9fdb2afd6b32abd10e3b27612cf1d9f56d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AddVmPoolCommand type inference
by amureini＠redhat.com 22 Aug '16

22 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddVmPoolCommand type inference ...................................................................... core: AddVmPoolCommand type inference Change-Id: Ife3a2c90196d3922c62304c6d6fcda39b3febcda Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3a2c90196d3922c62304c6d6fcda39b3febcda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Include master branch in hook consideration
by eedri＠redhat.com 21 Aug '16

21 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Include master branch in hook consideration ...................................................................... Include master branch in hook consideration until now master branch wasn't in the logic of deciding if to move bug to MODIFIED or not. this was because we searched for branch-suffix matching x.y.z, while master will always have empty match for that. this patch should include master in the check and if there are newer branches that match the target milestone, the status change will be skipped Change-Id: I963d5fd32f8bcf757f8608b60b84225ea87d7c08 Signed-off-by: Eyal Edri <eedri(a)redhat.com> Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/change-merged.set_MODIFIED 1 file changed, 18 insertions(+), 6 deletions(-) Approvals: Shlomo Ben David: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I963d5fd32f8bcf757f8608b60b84225ea87d7c08 Gerrit-PatchSet: 3 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Rephrase Preview Snapshot warning
by tjelinek＠redhat.com 21 Aug '16

21 Aug '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Rephrase Preview Snapshot warning ...................................................................... webadmin: Rephrase Preview Snapshot warning User warning for preview live snapshot originating in different cluster version is rephrased. User needs to explicitely confirm the intention to restore the memory. Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/62596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f93f0ddea68dc080d2618551d42a45e1f78d96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SuspendedVMClusterEditChecker removed
by ahadas＠redhat.com 21 Aug '16

21 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: SuspendedVMClusterEditChecker removed ...................................................................... core: SuspendedVMClusterEditChecker removed Prior this change, Cluster Edit dialog displayed warning for suspended VMs when changing cluster level. This warning is no more needed, since it's covered by - more general warning in Cluster Edit - adding nextrun config - and setting temporal custom compatibility level on the VM This patch removes the checker and UI warning. Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Bug-Url: https://bugzilla.redhat.com/1356027 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62475 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5d54f8c127a8ec7b2ccafcede8f9fe3da1fdc8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0