August 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: reducing ovirt-engine build-artifacts time to 2 hours
by eedri＠redhat.com 14 Aug '16

14 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: reducing ovirt-engine build-artifacts time to 2 hours ...................................................................... reducing ovirt-engine build-artifacts time to 2 hours Now that we have experimental flow running on latest artifacts we need a faster flow publishing RPMs to experimental and 6 hours is too much time to wait. In additon, recent improvements done in CI allows us to run more jobs and not worry on load or long build queue. We might considering changing this to run per commit at some point if we see we have the resources for it. Change-Id: I54dc71ffda131d6d8c847e0849a4d146071aef38 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62319 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54dc71ffda131d6d8c847e0849a4d146071aef38 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Revert "packaging: setup: Enroll missing pki on upgrade"
by eedri＠redhat.com 14 Aug '16

14 Aug '16

Eyal Edri has submitted this change and it was merged. Change subject: Revert "packaging: setup: Enroll missing pki on upgrade" ...................................................................... Revert "packaging: setup: Enroll missing pki on upgrade" This reverts commit f87e5c1ba7c58d342ba520422b0ec36fb01a866e. Change-Id: If74a568b7fbf4b3b28d710a5db980e8111aac175 Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/62316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74a568b7fbf4b3b28d710a5db980e8111aac175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor maintenance parameters
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: refactor maintenance parameters ...................................................................... core: refactor maintenance parameters 1. Rename class field _isInternal to internal 2. Put the constructors at the top Change-Id: I124c014d7ee47fa39fc131ab690c42e5f94e30ec Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceVdsParameters.java 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124c014d7ee47fa39fc131ab690c42e5f94e30ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use only vm dynamic data in destroy command
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use only vm dynamic data in destroy command ...................................................................... core: use only vm dynamic data in destroy command There is no real need to fetch the whole VM object, only the dynamic part is required. Change-Id: Ic36e27be2dac0d5b5f69502c5ad28e645eafb66d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62244 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic36e27be2dac0d5b5f69502c5ad28e645eafb66d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: simplify GetAllVmStats with stream api
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: simplify GetAllVmStats with stream api ...................................................................... core: simplify GetAllVmStats with stream api Change-Id: I721d94a6952a2d9d52fcd1a48f56e30f0000646a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetAllVmStatsVDSCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62235 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I721d94a6952a2d9d52fcd1a48f56e30f0000646a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in maintenance command
by ahadas＠redhat.com 14 Aug '16

14 Aug '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in maintenance command ...................................................................... core: cleanup in maintenance command 1. Inline _isInternal class field 2. Replace nested for-loops with stream API 3. Remove use of depracated DbFacade#getInstance Change-Id: Ie3111212c01f7d39e1c8a7b170162754e50d80ba Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3111212c01f7d39e1c8a7b170162754e50d80ba Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Refactor CurrentUser code
by piotr.kliczewski＠gmail.com 13 Aug '16

13 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Refactor CurrentUser code ...................................................................... webadmin: Refactor CurrentUser code CurrentUser#onUserLogin is typically called after UI plugins get initialized. Keeping separate DbUser reference in CurrentUser is not only redundant but also dangerous -- before CurrentUser#onUserLogin executes, UI plugins will get 'null' from api.loginUserName() and api.loginUserId() functions. This patch also removes some unused methods from CurrentUser. Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Bug-Url: https://bugzilla.redhat.com/1361656 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java 2 files changed, 10 insertions(+), 24 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/62161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b6998dd2bfaabd22f80fdde1c154fb2da447804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: database: memory_and_disk_images_storage_domain_view
by piotr.kliczewski＠gmail.com 13 Aug '16

13 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: database: memory_and_disk_images_storage_domain_view ...................................................................... database: memory_and_disk_images_storage_domain_view Inline EXISTS conditions in a select list, should, in theory perform a query once per row of the select list, while moving the same logic to a LEFT JOIN should allow the database to perform the query just once and hash-join it, resulting in a performance improvement. This patch also adds the missing indexes on the snapshots table to make these joins efficient. According to the work done on verifying bug #1302752, on a loaded system with 500 hosts, 7K VMs and 3 disks per VM, this patch improves the query's runtime by a factor of 33 - from 6600 msecs to 200 msecs. Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Bug-Url: https://bugzilla.redhat.com/1363823 Bug-Url: https://bugzilla.redhat.com/1302752 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0860_memory_and_disk_images_storage_domain_view_join_indexes.sql 2 files changed, 13 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/62286 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: database: memory_and_disk_images_storage_domain_view
by amureini＠redhat.com 12 Aug '16

12 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: database: memory_and_disk_images_storage_domain_view ...................................................................... database: memory_and_disk_images_storage_domain_view Inline EXISTS conditions in a select list, should, in theory perform a query once per row of the select list, while moving the same logic to a LEFT JOIN should allow the database to perform the query just once and hash-join it, resulting in a performance improvement. This patch also adds the missing indexes on the snapshots table to make these joins efficient. According to the work done on verifying bug #1302752, on a loaded system with 500 hosts, 7K VMs and 3 disks per VM, this patch improves the query's runtime by a factor of 33 - from 6600 msecs to 200 msecs. Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Related-To: https://bugzilla.redhat.com/1363823 Related-To: https://bugzilla.redhat.com/1302752 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0220_memory_and_disk_images_storage_domain_view_join_indexes.sql 2 files changed, 13 insertions(+), 17 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62044 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbedd49da10fa6752234eacf72bbb0f350b3c778 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: Enroll missing pki on upgrade
by piotr.kliczewski＠gmail.com 12 Aug '16

12 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: setup: Enroll missing pki on upgrade ...................................................................... packaging: setup: Enroll missing pki on upgrade Without this patch, imageio-proxy pki will not be generated on upgrade from 3.6, because it did not exist then. Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe Bug-Url: https://bugzilla.redhat.com/1365451 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/62230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5bbe9ddb45bfcbf6b7bf8aa7c6e2fb19fa206fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0