August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: CopyImageGroupCommand - set CopyImageGroupWithData end...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupCommand - set CopyImageGroupWithData end procedure ...................................................................... core: CopyImageGroupCommand - set CopyImageGroupWithData end procedure This patch sets the CopyImageGroupWithData end procedure to be command managed. as its not executed by CopyImageGroupCommand. The change as no functional effect (as the end method performs nothing anyway), but its more correct. Change-Id: I3e99f0c614f26908a7541b73241f36d5ffb21ce5 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62182 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e99f0c614f26908a7541b73241f36d5ffb21ce5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCommand to inherit from CommandBase ...................................................................... core: StorageJobCommand to inherit from CommandBase This patch changes StorageJobCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AllocateImageGroupVolumeCommand.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60263c3517a334f9b8308765fefbc4905bc3bb09 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CloneImageGroupVolumesStructureCommand to inherit from...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CloneImageGroupVolumesStructureCommand to inherit from CommandBase ...................................................................... core: CloneImageGroupVolumesStructureCommand to inherit from CommandBase This patch changes CloneImageGroupVolumesStructureCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: I1a74daa3915bbc66738e6743176df85cd8f19590 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a74daa3915bbc66738e6743176df85cd8f19590 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getVolumeInfoVDS command execution moved to ImagesHandler
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: getVolumeInfoVDS command execution moved to ImagesHandler ...................................................................... core: getVolumeInfoVDS command execution moved to ImagesHandler This patch moves the vds getVolumeInfo() usage to the ImagesHandler so it can be used easily by classes that are not part of the BaseImagesCommand hierarchy. Change-Id: I2c1743dfa3fcc8b0e237334ef1200393bc86c5dd Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 3 files changed, 13 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1743dfa3fcc8b0e237334ef1200393bc86c5dd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupWithDataCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupWithDataCommand to inherit from CommandBase ...................................................................... core: CopyImageGroupWithDataCommand to inherit from CommandBase This patch changes CopyImageGroupWithDataCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and only the getVolumeInfo from BaseImagesCommand is being used, therefore i prefer to not being depend on that class. Change-Id: Ief1802a6527783d587b0e0c057d3adcbd50fd463 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java 1 file changed, 21 insertions(+), 5 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62131 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief1802a6527783d587b0e0c057d3adcbd50fd463 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CopyImageGroupVolumesDataCommand to inherit from Comma...
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CopyImageGroupVolumesDataCommand to inherit from CommandBase ...................................................................... core: CopyImageGroupVolumesDataCommand to inherit from CommandBase This patch changes CopyImageGroupVolumesDataCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and no other methods from BaseImagesCommand are used, so this patch just changes the class to inherit from the base command class. Change-Id: Ic5b2dd83124286f223f417635b8dd83bc049c67e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupVolumesDataCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5b2dd83124286f223f417635b8dd83bc049c67e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeContainerCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeContainerCommand to inherit from CommandBase ...................................................................... core: CreateVolumeContainerCommand to inherit from CommandBase This patch changes CreateVolumeContainerCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and no other methods from BaseImagesCommand are used, so this patch just changes the class to inherit from the base command class. Change-Id: I2d252f0f288f278fd2153d8bf4418a58ae362503 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d252f0f288f278fd2153d8bf4418a58ae362503 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Image/GetVolumeInfo - adding LeaseState
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Image/GetVolumeInfo - adding LeaseState ...................................................................... core: Image/GetVolumeInfo - adding LeaseState Change-Id: Ic0ac900aed4a0dc33726ba4b12f3fc6af84a5a3d Signed-off-by: laravot(a)redhat.com <laravot(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LeaseState.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/Image.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVolumeInfoVDSCommand.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 4 files changed, 24 insertions(+), 0 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ac900aed4a0dc33726ba4b12f3fc6af84a5a3d Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeCommand to inherit from CommandBase
by laravot＠redhat.com 10 Aug '16

10 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeCommand to inherit from CommandBase ...................................................................... core: CreateVolumeCommand to inherit from CommandBase This patch changes CreateVolumeCommand to inherit from CommandBase instead of BaseImagesCommand, this is done as there's no need to execute the inherited end methods and no other methods from BaseImagesCommand are used, so this patch just changes the class to inherit from the base command class. Change-Id: I46c98697ca8ab4cfbf0fea934bd054a473bb7304 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeCommand.java 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46c98697ca8ab4cfbf0fea934bd054a473bb7304 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: ovirt-live-4.0.2_rc4
by sbonazzo＠redhat.com 10 Aug '16

10 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-live-4.0.2_rc4 ...................................................................... build: ovirt-live-4.0.2_rc4 Change-Id: Ie71719d881ed735f46ca0336748faa35349901fc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/62216 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71719d881ed735f46ca0336748faa35349901fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0