August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-backup: Drop Reports from --help
by sbonazzo＠redhat.com 09 Aug '16

09 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Drop Reports from --help ...................................................................... packaging: engine-backup: Drop Reports from --help Change-Id: I804a529175e3cd63668341cd501ab58781c640b0 Bug-Url: https://bugzilla.redhat.com/1340810 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 5 insertions(+), 32 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/60493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I804a529175e3cd63668341cd501ab58781c640b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Do not backup/restore Reports
by sbonazzo＠redhat.com 09 Aug '16

09 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Do not backup/restore Reports ...................................................................... packaging: engine-backup: Do not backup/restore Reports Keep most relevant code, for now, but disable it. Remove relevant paths from BACKUP_PATHS. Bug-Url: https://bugzilla.redhat.com/1340810 Change-Id: Icf681ba20a68c406288b4709fade1a8e01f77dd4 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 25 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/60472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf681ba20a68c406288b4709fade1a8e01f77dd4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Add active propery back to Disk
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add active propery back to Disk ...................................................................... restapi: Add active propery back to Disk This patch fixes a regression introduced by: https://gerrit.ovirt.org/#/c/61737/ which removed the 'active' property on disk Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M pom.xml 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: restapi: Set Disk 'active' properly in V3
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Set Disk 'active' properly in V3 ...................................................................... restapi: Set Disk 'active' properly in V3 When using the old V3 VM disks server we should set the active value from the Disk to the DiskAttachment otherwise it will be ignored down the chain Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Set Disk 'active' properly in V3
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Set Disk 'active' properly in V3 ...................................................................... restapi: Set Disk 'active' properly in V3 When using the old V3 VM disks server we should set the active value from the Disk to the DiskAttachment otherwise it will be ignored down the chain Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Add active propery back to Disk
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add active propery back to Disk ...................................................................... restapi: Add active propery back to Disk This patch fixes a regression introduced by: https://gerrit.ovirt.org/#/c/61737/ which removed the 'active' property on disk Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M pom.xml 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VdsmImageLocationInfo - adding default ctor
by laravot＠redhat.com 09 Aug '16

09 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: VdsmImageLocationInfo - adding default ctor ...................................................................... core: VdsmImageLocationInfo - adding default ctor As VdsmImageLocationInfo is used in params class it may be serialized/deserialized, default ctor is needed for the deserialization. Change-Id: I6ef7f33352e7504edeb78586584947d8824467b3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsmImageLocationInfo.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/61649 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef7f33352e7504edeb78586584947d8824467b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Don't call finazlize on image upload progress.
by derez＠redhat.com 09 Aug '16

09 Aug '16

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Don't call finazlize on image upload progress. ...................................................................... webadmin: Don't call finazlize on image upload progress. Currently, when a progress callback triggered while uploading an image, and the upload status is not "TRANSFERRING", there is a call to finalize upload. This is wrong, because in any scenario in which the status becomes anything other than "TRANSFERRING", finalizing the upload already happens. that means that currently a call for finalizing will happen twice. Remove the call for finalizeUpload in onProgress(). Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/62017 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad2ad4b7500d44be2ff2ca9ea7ed91bc61c5c313 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Set Disk 'active' properly in V3
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Set Disk 'active' properly in V3 ...................................................................... restapi: Set Disk 'active' properly in V3 When using the old V3 VM disks server we should set the active value from the Disk to the DiskAttachment otherwise it will be ignored down the chain Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Passed CI tests Martin Peřina: Looks good to me, but someone else must approve Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05daa7dc8ab9f1280ace5f458906f6fb8206fb97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add active propery back to Disk
by tnisan＠redhat.com 09 Aug '16

09 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Add active propery back to Disk ...................................................................... restapi: Add active propery back to Disk This patch fixes a regression introduced by: https://gerrit.ovirt.org/#/c/61737/ which removed the 'active' property on disk Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Bug-Url: https://bugzilla.redhat.com/1364783 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M pom.xml 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff95ab41cf11fa2845c28b29891ee22a2e738eda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.ondra(a)gmail.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0