August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: AttachStorageDomainToPoolCommand - dont pass compensat...
by piotr.kliczewski＠gmail.com 08 Aug '16

08 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommand - dont pass compensation context ...................................................................... core: AttachStorageDomainToPoolCommand - dont pass compensation context If the data center is unintnalized, AttachStorageDomainToPoolCommand executes the AddStoragePoolWithStorages command. Currently the compensation context is passed to that command, on failure during the command execution the data registered on the compensation context won't be reverted becasue of an infrastractural bug. Regardless of the need to fix the infrastractual issue in bz 1364804, this patch solves the bug by not passing the compensation context Change-Id: I80c56009b005917bdb2b4a642fadef32623c59d0 Bug-Url: https://bugzilla.redhat.com/1359788 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/62041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80c56009b005917bdb2b4a642fadef32623c59d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Allow passing of scheduling policy name for Update ...
by tnisan＠redhat.com 08 Aug '16

08 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Allow passing of scheduling policy name for Update Cluster ...................................................................... restapi: Allow passing of scheduling policy name for Update Cluster This patch will enable auto-completion for the scheduling policy name in the SDK. Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1315657 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ori Liel: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58788 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c88c789b3eea74d2a64138e8b35e92ce7eacb0c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix high memory limit default value
by tnisan＠redhat.com 08 Aug '16

08 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix high memory limit default value ...................................................................... core: fix high memory limit default value In the secondary methods of power saving load balancing for finding source/destination hosts by memory utilization the default value of high memory limit is 0. In case no value was inserted to this limit - the scheduling policy will filter out all hosts since no host will satisfy host available memory < 0. fix - the default value was changed to max long in case no value was inserted Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119 Bug-Url: https://bugzilla.redhat.com/1359767 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 0a22ab1) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java 2 files changed, 53 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/61370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: qos: Fix CPU Profile live update
by tnisan＠redhat.com 08 Aug '16

08 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: qos: Fix CPU Profile live update ...................................................................... qos: Fix CPU Profile live update Update a running VM if the VM gets another CPU profile assigned. Bug-Url: https://bugzilla.redhat.com/1361500 Change-Id: Ida176cead62a3c183fd1cce92b22edbebe545a9c Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateCpuProfileCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 4 files changed, 38 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59493 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida176cead62a3c183fd1cce92b22edbebe545a9c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: qos: Update Disk QoS on disk profile change
by tnisan＠redhat.com 08 Aug '16

08 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: qos: Update Disk QoS on disk profile change ...................................................................... qos: Update Disk QoS on disk profile change When the disk profile on a disk is changed, the QoS updates are sent to all VMs with that disk assigned. Prior to that patch only QoS changes on the profile were live updated. Change-Id: If1dbe1f7bd3962500683fd20c26a97712dd179d0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346754 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/UpdateDiskProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/RemoveStorageQosCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateStorageQosCommand.java 5 files changed, 37 insertions(+), 21 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60920 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1dbe1f7bd3962500683fd20c26a97712dd179d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.6]: build: removed fc22 check from automation scripts
by Shirly Radco 08 Aug '16

08 Aug '16

Shirly Radco has submitted this change and it was merged. Change subject: build: removed fc22 check from automation scripts ...................................................................... build: removed fc22 check from automation scripts Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 0 insertions(+), 18 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: build: removed fc22 check from automation scripts
by Shirly Radco 08 Aug '16

08 Aug '16

Shirly Radco has submitted this change and it was merged. Change subject: build: removed fc22 check from automation scripts ...................................................................... build: removed fc22 check from automation scripts Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Signed-off-by: Shirly Radco <sradco(a)redhat.com> (cherry picked from commit efe9aee3634508d45a1d5beab06a0b5b0fddf9eb) --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 0 insertions(+), 18 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: Added information about maintenance modes in the man page.
by stirabos＠redhat.com 08 Aug '16

08 Aug '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Added information about maintenance modes in the man page. ...................................................................... Added information about maintenance modes in the man page. Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335952 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M man/hosted-engine.8 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a5ec7f7eb22ec6ec4ff66bb67910db6a31c8fc1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: Revert "engine: Create default network QoS for ovirtmgmt upo...
by piotr.kliczewski＠gmail.com 08 Aug '16

08 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" ...................................................................... Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" This reverts commit 7bbfdab92ac600994319aac2bc5ee35ec11f3dc9. Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java 1 file changed, 1 insertion(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.2]: Revert "engine: allow QoS and non-QoS networks to be attache...
by piotr.kliczewski＠gmail.com 08 Aug '16

08 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: Revert "engine: allow QoS and non-QoS networks to be attached to a nic" ...................................................................... Revert "engine: allow QoS and non-QoS networks to be attached to a nic" This reverts commit 984878ccbb5084fa936dca5df39f2bf2b8fc740a. Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 118 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.2 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0