August 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: fix high memory limit default value
by piotr.kliczewski＠gmail.com 08 Aug '16

08 Aug '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: fix high memory limit default value ...................................................................... core: fix high memory limit default value In the secondary methods of power saving load balancing for finding source/destination hosts by memory utilization the default value of high memory limit is 0. In case no value was inserted to this limit - the scheduling policy will filter out all hosts since no host will satisfy host available memory < 0. fix - the default value was changed to max long in case no value was inserted Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119 Bug-Url: https://bugzilla.redhat.com/1354281 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 0a22ab1) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java 2 files changed, 55 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/61331 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: automation: use 4.0 repos
by Shirly Radco 08 Aug '16

08 Aug '16

Shirly Radco has submitted this change and it was merged. Change subject: automation: use 4.0 repos ...................................................................... automation: use 4.0 repos Change-Id: I19692d99247f303bc3608bf284ab883ae96b7af7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.repos M automation/check-merged.repos M automation/check-patch.repos 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62040 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19692d99247f303bc3608bf284ab883ae96b7af7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AttachStorageDomainToPoolCommand - dont pass compensat...
by laravot＠redhat.com 08 Aug '16

08 Aug '16

Liron Aravot has submitted this change and it was merged. Change subject: core: AttachStorageDomainToPoolCommand - dont pass compensation context ...................................................................... core: AttachStorageDomainToPoolCommand - dont pass compensation context If the data center is unintnalized, AttachStorageDomainToPoolCommand executes the AddStoragePoolWithStorages command. Currently the compensation context is passed to that command, on failure during the command execution the data registered on the compensation context won't be reverted becasue of an infrastractural bug. Regardless of the need to fix the infrastractual issue in bz 1364804, this patch solves the bug by not passing the compensation context Change-Id: I80c56009b005917bdb2b4a642fadef32623c59d0 Bug-Url: https://bugzilla.redhat.com/1359788 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/62035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80c56009b005917bdb2b4a642fadef32623c59d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: dnf support on Fedora
by sbonazzo＠redhat.com 08 Aug '16

08 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: dnf support on Fedora ...................................................................... packaging: spec: dnf support on Fedora - Updated comment on supported Fedora version - Added python-dnf-plugins-extras-versionlock: on Fedora both dnf-2 and dnf-3 are available so both versions of versionlock plugin are needed. - Dropped yum dependency on Fedora since it's deprecated in favor of python2-dnf. - Added python3-dnf if built with_python3 enabled - Kept yum-plugin-versionlock dependency only if yum is installed. - Added missing dnf versionlock plugin cleanup on %post Related-To: https://bugzilla.redhat.com/1355626 Change-Id: I663bc86de7af53e62afaab0fdb7010414ae7a7f5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I663bc86de7af53e62afaab0fdb7010414ae7a7f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: drop legacy fc22 only code
by sbonazzo＠redhat.com 08 Aug '16

08 Aug '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: drop legacy fc22 only code ...................................................................... automation: drop legacy fc22 only code Dropped code which was executed only when building within a fc22 chroot. Fedora 22 is now EOL and we won't never build for fc22 anymore. Change-Id: I13850cb814854159a8e168af2d0dfc365c1142e5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh 2 files changed, 0 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Verified Eyal Edri: Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/61988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13850cb814854159a8e168af2d0dfc365c1142e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: build: removed fc22 check from automation scripts
by Shirly Radco 08 Aug '16

08 Aug '16

Shirly Radco has submitted this change and it was merged. Change subject: build: removed fc22 check from automation scripts ...................................................................... build: removed fc22 check from automation scripts Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M automation/build-artifacts.sh M automation/check-merged.sh M automation/check-patch.sh 3 files changed, 0 insertions(+), 18 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I730fff27382949ade482ddd5dd58c563738735d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Revert "engine: Create default network QoS for ovirtmgmt upo...
by tnisan＠redhat.com 07 Aug '16

07 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" ...................................................................... Revert "engine: Create default network QoS for ovirtmgmt upon DC creation" This reverts commit 7bbfdab92ac600994319aac2bc5ee35ec11f3dc9. Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddEmptyStoragePoolCommand.java 1 file changed, 1 insertion(+), 35 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aad475b1b075ffc3b182082d63304f48cbb56e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: Revert "engine: allow QoS and non-QoS networks to be attache...
by tnisan＠redhat.com 07 Aug '16

07 Aug '16

Tal Nisan has submitted this change and it was merged. Change subject: Revert "engine: allow QoS and non-QoS networks to be attached to a nic" ...................................................................... Revert "engine: allow QoS and non-QoS networks to be attached to a nic" This reverts commit 984878ccbb5084fa936dca5df39f2bf2b8fc740a. Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Bug-Url: https://bugzilla.redhat.com/1364145 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java 2 files changed, 118 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/62022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20d5e51741b79005ae2c9c452fdea2faf7e322a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Call super method getJobMessageProperties
by amureini＠redhat.com 07 Aug '16

07 Aug '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Call super method getJobMessageProperties ...................................................................... engine: Call super method getJobMessageProperties Add a call to super method in getJobMessageProperties in order to get CommandBase implementation invoked before adding properties. This patch fixes coverity issue #1353695 Change-Id: I4f86794fed438b640ec139f782e51519e26cb5b6 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Passed CI tests Freddy Rolland: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/62025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f86794fed438b640ec139f782e51519e26cb5b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: userportal: Fix first vm creation in session
by rgolan＠redhat.com 07 Aug '16

07 Aug '16

Roy Golan has submitted this change and it was merged. Change subject: webadmin: userportal: Fix first vm creation in session ...................................................................... webadmin: userportal: Fix first vm creation in session When creating a vm on a local storage domain it should be pinned to a specific host that is available for this domain. When creating a vm on local storage for the first time it wouldn't be created with a pinned host due to an async code that would not run in the expected order. When editing such a vm the user would get an error since it seems that he is editing the pinned host. To ensure the correct order of execution the handling of the local storage was moved to the end of the block of code that is run asynchronously. Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08 Bug-Url: https://bugzilla.redhat.com/1284472 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Jenny Tokar: Verified Yanir Quinn: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/61934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99918ef35099546734cf8835e5abe5bfcef33d08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0