September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0.4]: core: log reason for stopping vm only if set
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: log reason for stopping vm only if set ...................................................................... core: log reason for stopping vm only if set Previously we always tried to include the stop reason when auditing VM stop operation. When no reason was set, either because it is not enabled in the cluster or the user simply did not enter a reason, the audit log included the following redundant message: (Reason: No reason was returned for this operation failure. See logs for further details.) This patch changes that so audit logs will include the stop reason only when it is set. That way, we avoid messages as shown above. Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Bug-Url: https://bugzilla.redhat.com/1340414 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> (cherry picked from commit 220f657dcd3de9919448106b06fe168fb510a3f2) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 13 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25b3ffced6036796d20bfcce0d47c22a3365a80d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: don't cast from Guid to StorageDomain
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: don't cast from Guid to StorageDomain ...................................................................... webadmin: don't cast from Guid to StorageDomain This patch removes a wrong cast from the return type of getEntity() (Guid) to StorageDomain, and replaces it with a cast to Guid. Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Bug-Url: https://bugzilla.redhat.com/1371304 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/63116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb41d6aa1f415414d8bc404e7288a5fe317df8f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't add V3 guest IP to links
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Don't add V3 guest IP to links ...................................................................... restapi: Don't add V3 guest IP to links Currently the V3 compatibility layer tries to add the guest IP to all the returned objects of type "vm". That is wrong, as links, for example, shouldn't include such information. To solve the problem this patch changes the API so that the population of the guest IP is performed only for objects of type "vm" returned by the "list", "get", and "update" operations of the services that manage virtual machines. Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 371894f4b19605ebe10fe0e5e2cddd0146482c4a) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 71 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't add V3 disk attachment details to links
by piotr.kliczewski＠gmail.com 02 Sep '16

02 Sep '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Don't add V3 disk attachment details to links ...................................................................... restapi: Don't add V3 disk attachment details to links Currently the V3 compatibility layer tries to add the attachment details (bootable, etc) to all the returned objects of type "disk". That is wrong, as links, for example, shoundn't include such information. To solve the problem this patch changes the API so that the population of these details is performed only for objects of type "disk" returned by the "list", "get", and "update" operations of the services that manage virtual machine disks. Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9aa386f4ea54dd69e96fe87176a394ef6113d3ef) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 4 files changed, 49 insertions(+), 79 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal,webadmin: default refresh
by awels＠redhat.com 02 Sep '16

02 Sep '16

Alexander Wels has submitted this change and it was merged. Change subject: userportal,webadmin: default refresh ...................................................................... userportal,webadmin: default refresh - Defaulted refresh to false Change-Id: I8bf4eef17f82bf1552f89b6cf450533d3837921b Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendPermissionResourceTest.java M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManagerTest.java 3 files changed, 10 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63083 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf4eef17f82bf1552f89b6cf450533d3837921b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Generate RPM Maven dependencies
by omachace＠redhat.com 02 Sep '16

02 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Generate RPM Maven dependencies ...................................................................... Generate RPM Maven dependencies Currently the RPM packaging of the SDK doesn't generate the Maven dependencies. This means that other packages that use tools like Xmvn to build won't work correctly. To avoid that this patch changes the RPM build process so that it genrates a POM file that can be used in RPM distributions, and generates the dependencies from that POM file. Change-Id: I2d273398ede6f7a0f86c0253d71660f8decb366b Bug-Url: https://bugzilla.redhat.com/1372652 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit c81e06c50b978fcc511151413af66cbc099e251b) --- R automation/build-artifacts.packages.fc23 C automation/build-artifacts.packages.fc24 C automation/check-patch.packages.el7 R automation/check-patch.packages.fc23 C automation/check-patch.packages.fc24 M packaging/build.xml M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in A packaging/transform-pom.xsl 10 files changed, 121 insertions(+), 38 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d273398ede6f7a0f86c0253d71660f8decb366b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Generate RPM Maven dependencies
by omachace＠redhat.com 02 Sep '16

02 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Generate RPM Maven dependencies ...................................................................... Generate RPM Maven dependencies Currently the RPM packaging of the SDK doesn't generate the Maven dependencies. This means that other packages that use tools like Xmvn to build won't work correctly. To avoid that this patch changes the RPM build process so that it genrates a POM file that can be used in RPM distributions, and generates the dependencies from that POM file. Change-Id: I2d273398ede6f7a0f86c0253d71660f8decb366b Bug-Url: https://bugzilla.redhat.com/1372652 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- R automation/build-artifacts.packages.fc23 C automation/build-artifacts.packages.fc24 C automation/check-patch.packages.el7 R automation/check-patch.packages.fc23 C automation/check-patch.packages.fc24 M packaging/build.xml M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in A packaging/transform-pom.xsl 10 files changed, 121 insertions(+), 38 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d273398ede6f7a0f86c0253d71660f8decb366b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: console: use virsh with SASL auth
by stirabos＠redhat.com 02 Sep '16

02 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: console: use virsh with SASL auth ...................................................................... console: use virsh with SASL auth Using virsh with SASL auth instead of TLS one since it was causing auth issues on redeployment on dirty hosts. Change-Id: I73340250134bd24672cc91362d25cc3605b111ba Bug-Url: https://bugzilla.redhat.com/1333449 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/bin/hosted-engine.in 2 files changed, 21 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73340250134bd24672cc91362d25cc3605b111ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: console: avoid assuming remote-viewer in instructions
by stirabos＠redhat.com 02 Sep '16

02 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: console: avoid assuming remote-viewer in instructions ...................................................................... console: avoid assuming remote-viewer in instructions Provide console connection instructions not based on a local remote-viewer. Bug-Url: https://bugzilla.redhat.com/1333449 Depends-On: https://gerrit.ovirt.org/61697/ Change-Id: I3eca5eaaf6d4fe3021462ff45b152cd21741c110 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/gr-he-setup/vm/runvm.py 2 files changed, 26 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eca5eaaf6d4fe3021462ff45b152cd21741c110 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.0]: Revert "Revert "console: remove virt-viewer dependency""
by stirabos＠redhat.com 02 Sep '16

02 Sep '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: Revert "Revert "console: remove virt-viewer dependency"" ...................................................................... Revert "Revert "console: remove virt-viewer dependency"" This reverts commit aa5d8354dd367cb8b4c1f1342b57450581715db3. Change-Id: I93879ad97dfcff13163ee214bf1eb36ca3a7b0aa Bug-Url: https://bugzilla.redhat.com/1333449 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M man/hosted-engine.8 M ovirt-hosted-engine-setup.spec.in M src/bin/hosted-engine.in 3 files changed, 27 insertions(+), 19 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93879ad97dfcff13163ee214bf1eb36ca3a7b0aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0