September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Accept 'action' and 'fault' from actions
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Accept 'action' and 'fault' from actions ...................................................................... Accept 'action' and 'fault' from actions Currently the SDK expects that the server to return 'action' XML elements when actions succeed, and 'fault' when they fail. But the server may send 'action' with a nested 'fault' when something fails. This patch modifies the SDK so that it also accepts that. Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 65a779295c65065749177a9243d1155191d958ee) --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/service_spec.rb M sdk/spec/vm_service_spec.rb 4 files changed, 82 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Accept 'action' and 'fault' from actions
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Accept 'action' and 'fault' from actions ...................................................................... Accept 'action' and 'fault' from actions Currently the SDK expects that the server to return 'action' XML elements when actions succeed, and 'fault' when they fail. But the server may send 'action' with a nested 'fault' when something fails. This patch modifies the SDK so that it also accepts that. Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/lib/ovirtsdk4/service.rb M sdk/spec/service_spec.rb M sdk/spec/vm_service_spec.rb 4 files changed, 82 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fd210df7aff836421d5c9c3c13652fbd9f390e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Fix reading of list of primitive and enum types
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5ecd43a6f1dfe5f7c8f8bcf67d880edab955fa60) --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/network_reader_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/xml_reader_spec.rb 5 files changed, 151 insertions(+), 23 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use the cached vm-statistics for vm search queries
by ahadas＠redhat.com 01 Sep '16

01 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: use the cached vm-statistics for vm search queries ...................................................................... core: use the cached vm-statistics for vm search queries VM statistics are cached in VmManager instances so they can be retrieved from them instead of parsing them from the query from the database. This patch doesn't delete VM statistics from 'vms' view since we need to be sure it is not used by others first. Change-Id: I24d01411d72fac02b463026a416a98096f89770f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/62314 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24d01411d72fac02b463026a416a98096f89770f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Fix reading of list of primitive and enum types
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit b90c5cad7bb1b0ca146db8d900fd4d9be69a6b73) --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M sdk/ext/ov_xml_reader.c A sdk/tests/test_network_reader.py M sdk/tests/test_reader.py M sdk/tests/test_xml_reader.py 5 files changed, 182 insertions(+), 28 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Fix reading of list of primitive and enum types
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/ReadersGenerator.java M sdk/ext/ovirtsdk4c/ov_xml_reader.c A sdk/spec/network_reader_spec.rb M sdk/spec/reader_spec.rb M sdk/spec/xml_reader_spec.rb 5 files changed, 151 insertions(+), 23 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cd3d4c5d838b6240fe8b11df6f5521e1a79b252 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add .yardocs file to the .gem file
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add .yardocs file to the .gem file ...................................................................... Add .yardocs file to the .gem file This is required in order to make sure that the documentation generated by the 'rubydocs.info' web site uses AsciiDoc, otherwise it doesn't look good. Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit fc853e13e86d4d1ce359f8ce402b4e7624ec83a4) --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M sdk/README.adoc M sdk/ovirt-engine-sdk.gemspec 5 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add .yardocs file to the .gem file
by juan.hernandez＠redhat.com 01 Sep '16

01 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add .yardocs file to the .gem file ...................................................................... Add .yardocs file to the .gem file This is required in order to make sure that the documentation generated by the 'rubydocs.info' web site uses AsciiDoc, otherwise it doesn't look good. Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/spec.el7.in M packaging/spec.fc23.in M packaging/spec.fc24.in M sdk/README.adoc M sdk/ovirt-engine-sdk.gemspec 5 files changed, 5 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/63014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd69d90ea16f24859f7ad5aded68b33e68eb21f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: update lun's info on any property change
by derez＠redhat.com 01 Sep '16

01 Sep '16

Daniel Erez has submitted this change and it was merged. Change subject: core: update lun's info on any property change ...................................................................... core: update lun's info on any property change When syncing DB LUNs with the information from the storage, if the LUNs' IDs are different we save a new LUN, and if the LUN's size was changed, we update the existing one. This approach ignores other fields that may have changed, so that: * If another field which is not the LUN's size was changed, the LUN will not be updated. * If the LUN's size was changed, the lun will be updated, along with other fields that were changed. This patch takes a new approach - getLunsToUpdateInDb returns the LUNs that require a DB update and updateLunsInDb always updates these LUNs in the DB (or saves new ones if the ID was changed). Therefore, adding more filters to getLunsToUpdateInDb (like LUNId and deviceSize) will possibly cause more LUNs to be updated in the DB. Change-Id: I9cfd28001fe065001669040ba010d2ee54ac876d Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 2 files changed, 64 insertions(+), 42 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/62749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfd28001fe065001669040ba010d2ee54ac876d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Fix reading of list of primitive and enum types
by omachace＠redhat.com 01 Sep '16

01 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix reading of list of primitive and enum types ...................................................................... Fix reading of list of primitive and enum types This patch fixes reading of list of primitive and enum types, previously we simply skip the reading. Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ReadersGenerator.java M sdk/ext/ov_xml_reader.c A sdk/tests/test_network_reader.py M sdk/tests/test_reader.py M sdk/tests/test_xml_reader.py 5 files changed, 182 insertions(+), 28 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49cc4bbe165ca25c7e5d54ef176591deca4c692a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0