January 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: adding cli for 4.1 experimental repos
by Code Review 02 Jan '17

02 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: adding cli for 4.1 experimental repos ...................................................................... adding cli for 4.1 experimental repos - also dropped fc23 since its eol Change-Id: Idb7a41df664eb6728e6ee14ba7da1a44cd859760 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-cli/ovirt-engine-cli_build-artifacts.yaml M jobs/confs/yaml/builders/copy-create-job-artifact.yaml 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb7a41df664eb6728e6ee14ba7da1a44cd859760 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduling: Fix AREM logic for host affinity
by Code Review 02 Jan '17

02 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: scheduling: Fix AREM logic for host affinity ...................................................................... scheduling: Fix AREM logic for host affinity This patch updates the AREM algorithms with regards to host affinity. We sadly have a logic bug in the previously merged version. All affinity groups have to be considered separately when a VM is part of multiple host affinity groups. The correct operation for selecting a valid host is intersection, not union. Bug-Url: https://bugzilla.redhat.com/1404660 Change-Id: I683c46ef3be8e94cacbb554c5a372a9574f584d4 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 72 insertions(+), 124 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I683c46ef3be8e94cacbb554c5a372a9574f584d4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: replace vague error message with specific ones.
by Code Review 02 Jan '17

02 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: replace vague error message with specific ones. ...................................................................... core: replace vague error message with specific ones. Split 'inexisting network attachment' into 3 different failures diferentiating upon action requested to be done with them. Change-Id: If99e5feab8a97b355f3b3da964cc16a48282809d Bug-Url: https://bugzilla.redhat.com/1324482 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 29 insertions(+), 44 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If99e5feab8a97b355f3b3da964cc16a48282809d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: allow to change vm name only when it is down
by Code Review 02 Jan '17

02 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: allow to change vm name only when it is down ...................................................................... core: allow to change vm name only when it is down When a VM is runnning, name change would be applied only on its next restart. Change-Id: Idc510aa83bd9cc3a32b048b72983753136032bea Bug-Url: https://bugzilla.redhat.com/1375379 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 5 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc510aa83bd9cc3a32b048b72983753136032bea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: storage: hide the query for additional mount options
by Code Review 02 Jan '17

02 Jan '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: storage: hide the query for additional mount options ...................................................................... storage: hide the query for additional mount options The engine is not able to handle additional mount options so they are going to be lost when it imports the hosted-engine storage domain. Hiding the user query for additional mount options till the engine will be able to handle them. Change-Id: I2f56851cc69b6c00a519ca06778bcfb000a53afa Bug-Url: https://bugzilla.redhat.com/1402417 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/gr-he-setup/storage/nfs.py 1 file changed, 19 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69018 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f56851cc69b6c00a519ca06778bcfb000a53afa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cache unplugged passthrough nics on vm migration
by Code Review 02 Jan '17

02 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: cache unplugged passthrough nics on vm migration ...................................................................... core: cache unplugged passthrough nics on vm migration This has two benefits: 1. Better performance - not to query VM's passthrough network interfaces on every migration attempt. 2. We can always retrieve the unplugged NICs when migration succeed. Previously, when one migration attempt failed, these NICs were cleared and so if the next migration attempt would have succeed, they could not be plugged back. Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 26 insertions(+), 19 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: ReduceSANStorageDomainDevices - free space validation
by Code Review 02 Jan '17

02 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: ReduceSANStorageDomainDevices - free space validation ...................................................................... core: ReduceSANStorageDomainDevices - free space validation The user can execute the ReduceSANStorageDomainDevices command with few devices to reduce from the domain. ReduceSANStorageDomainDevices executes RemoveDeviceFromSANStorageDomain for each of the devices, this command first moves the data from the device and then reduces the domain by removing the device from it. The data is moved using the lvm command pvmove, if there's not enough free space the operation will fail. When attempting to reduce multiple devices, we can't rely on the lvm verification for space (as lvm isn't aware that the user actually wants to reduce more than one device). This patch adds verification that there's enough free space for the operation - the command executes getVgInfo, sums the pe allocation of the devices for reduction and checks if the number of the free extents is sufficent. Change-Id: I80cfb95b61692ea83c3eaf2c490d20b17b2d0236 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/BlockStorageDomainHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 53 insertions(+), 4 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/69155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80cfb95b61692ea83c3eaf2c490d20b17b2d0236 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: getDeviceList.parseLun() - PE related fields
by Code Review 02 Jan '17

02 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: getDeviceList.parseLun() - PE related fields ...................................................................... core: getDeviceList.parseLun() - PE related fields This patch adds the PE related fields (pe_alloc_count and pe_count) to the parsing done in getDeviceList.parseLun() which is used by getVgInfo (currently reported by it). Change-Id: If1a06a83c0b4e48d1ecdb513eda336ba7dd2615f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69154 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1a06a83c0b4e48d1ecdb513eda336ba7dd2615f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: common: adding pe allocation/pe count fields to LUN
by Code Review 02 Jan '17

02 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: common: adding pe allocation/pe count fields to LUN ...................................................................... common: adding pe allocation/pe count fields to LUN This patch adds the peCount/peAllocatedCount fields to the LUN entity. On the further patches on this series those fields will be populated by getVgInfo and will be used to determine if a storage domain has enough free space for requested reducation of the domain. Change-Id: I5362ae189ee050fc8b23149e9d19489c104df35d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5362ae189ee050fc8b23149e9d19489c104df35d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move cleanup of passthrough nics to runningFailed
by Code Review 02 Jan '17

02 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: move cleanup of passthrough nics to runningFailed ...................................................................... core: move cleanup of passthrough nics to runningFailed There are few benefits of moving the cleanup of passthrough network interfaces to 'runningFailed' method: 1. this cleanup should be done only when the migration fails after the scheduler chose a host (i.e., not upon an error in 'initVdss') - this is exactly what 'runningFailed' is there for. 2. it simplifies the execute ('executeVmCommand') method. 3. that way, the cleanup is done when call to VDSM for migration fails. 4. that way, the cleanup is done when the last rerun attempt fails. Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124 Bug-Url: https://bugzilla.redhat.com/1408834 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 33 insertions(+), 28 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0