January 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Fix some more issues with SDK
by Code Review 03 Jan '17

03 Jan '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Fix some more issues with SDK ...................................................................... Fix some more issues with SDK Change-Id: Ida23f6f21355df04341bb13b89f0c0861a9a3a3e Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Gil Shinar: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida23f6f21355df04341bb13b89f0c0861a9a3a3e Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: change param name in amend volume
by Code Review 03 Jan '17

03 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: change param name in amend volume ...................................................................... engine: change param name in amend volume Change the parameter name passed to VDSM to qcow2_attr See VDSM Iab10e868b69f42543c12873c1014979d2efafa1e Change-Id: Ibbfbf32d3bd46437e84dfad45987b738e280f0e6 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/69365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbfbf32d3bd46437e84dfad45987b738e280f0e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: allow to change vm name only when it is down
by Code Review 03 Jan '17

03 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: allow to change vm name only when it is down ...................................................................... core: allow to change vm name only when it is down When a VM is runnning, name change would be applied only on its next restart. Change-Id: Idc510aa83bd9cc3a32b048b72983753136032bea Bug-Url: https://bugzilla.redhat.com/1375379 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 3 files changed, 5 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc510aa83bd9cc3a32b048b72983753136032bea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduling: Fix AREM logic for host affinity
by Code Review 03 Jan '17

03 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: scheduling: Fix AREM logic for host affinity ...................................................................... scheduling: Fix AREM logic for host affinity This patch updates the AREM algorithms with regards to host affinity. We sadly have a logic bug in the previously merged version. All affinity groups have to be considered separately when a VM is part of multiple host affinity groups. The correct operation for selecting a valid host is intersection, not union. Change-Id: I2c95ae9ece924263accdfba5deac084506a6da2a Bug-Url: https://bugzilla.redhat.com/1404660 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 48e6d23) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcerTest.java 2 files changed, 72 insertions(+), 124 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/69436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c95ae9ece924263accdfba5deac084506a6da2a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactor use of EditableVmField
by Code Review 03 Jan '17

03 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: refactor use of EditableVmField ...................................................................... core: refactor use of EditableVmField When a field is editable in just one status, we can use the syntactic-sugar of onStatuses = <status> instead of onStatuses = { <status> }. Change-Id: Ica5c6f8980894204da38f816cd71e9f13468b179 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java 2 files changed, 36 insertions(+), 36 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5c6f8980894204da38f816cd71e9f13468b179 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Clarify how to use the SDK with Maven
by Code Review 03 Jan '17

03 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Clarify how to use the SDK with Maven ...................................................................... Clarify how to use the SDK with Maven This patch improves the README.adoc file of the SDK trying to clarify that the SDK is distributed in binary form via Maven Central, so there is no need to build it from source. Change-Id: I25341cb006eb2907404b4ab16600a7524f08248c Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/README.adoc 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25341cb006eb2907404b4ab16600a7524f08248c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: services: Update default mem heap values
by Code Review 03 Jan '17

03 Jan '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: packaging: services: Update default mem heap values ...................................................................... packaging: services: Update default mem heap values DWH configuration was updated to allocate 1 GB of RAM: DWH_HEAP_MIN=1g DWH_HEAP_MAX=1g Change-Id: I8efba50f4d79ce42015973b115d90f048e0fa226 Bug-Url: https://bugzilla.redhat.com/1408652 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.py 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69120 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8efba50f4d79ce42015973b115d90f048e0fa226 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Fix writing 'id' attribute for enum values
by Code Review 03 Jan '17

03 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Fix writing 'id' attribute for enum values ...................................................................... Fix writing 'id' attribute for enum values Currently the SDK doesn't generate correctly the XML for attributes named 'id' that contain enum values. For example, when writing the list of SSO methods of a virtual machine it generates the following: <sso> <methods> <method> <id>guest_agent</id> </method> </methods> </sso> But it should write the following instead, as the 'id' model attribute should always be represented as an XML attribute: <sso> <methods> <method id="guest_agent"/> </methods> </sso> This patch addresses that issue, which was mostly a typo in the generator of the XML writing code. Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d Bug-Url: https://bugzilla.redhat.com/1408839 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 7aaafb7bac31622d351b5921e30266656128cfc3) (cherry picked from commit 2e52935a1895f5da8ff0f5f7f95166d1e45228ac) --- M generator/src/main/java/org/ovirt/sdk/python/WritersGenerator.java A sdk/tests/test_sso_writer.py 2 files changed, 68 insertions(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52065c9aeba4628155cbdc638bf0334834f4a15d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: adding dashboard 4.1 to build from master
by Code Review 03 Jan '17

03 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: adding dashboard 4.1 to build from master ...................................................................... adding dashboard 4.1 to build from master Also dropped fc23 builds since its fc23 is EOL Change-Id: Ie977fffb8f63af70f0cfd9a6fdfcf2d647bcf265 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-dashboard/ovirt-engine-dashboard_standard.yaml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie977fffb8f63af70f0cfd9a6fdfcf2d647bcf265 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: storage: hide the query for additional mount options
by Code Review 03 Jan '17

03 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: hide the query for additional mount options ...................................................................... storage: hide the query for additional mount options The engine is not able to handle additional mount options so they are going to be lost when it imports the hosted-engine storage domain. Hiding the user query for additional mount options till the engine will be able to handle them. Change-Id: I2f56851cc69b6c00a519ca06778bcfb000a53afa Bug-Url: https://bugzilla.redhat.com/1402417 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit 995c6a65ab897d804f794306cc3654214f2c29b6) --- M src/plugins/gr-he-setup/storage/nfs.py 1 file changed, 19 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f56851cc69b6c00a519ca06778bcfb000a53afa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-2.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0