January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Make StorageDomainType values static
by Code Review 12 Jan '17

12 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Make StorageDomainType values static ...................................................................... core: Make StorageDomainType values static StorageDomainType enum conversion values (for DB storage purposes) was equal to the ordinal value of each enum, relying on the ordinal values is error prone as introducing a new enum not at the end of the chain will cause the ordinals of the enum coming after to shift. This patch sets the conversion values of the enums in StorageDomainType to static ones based on their current ordinal and from the static values when converting Change-Id: Id345876c05408cf45238bcb146d522ff29be0026 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainType.java 1 file changed, 26 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69917 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id345876c05408cf45238bcb146d522ff29be0026 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use Map interface type in StorageType instead of the i...
by Code Review 12 Jan '17

12 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use Map interface type in StorageType instead of the implementation ...................................................................... core: Use Map interface type in StorageType instead of the implementation Change-Id: Iab324e2ad9767095e61da7059b788d67276c13be Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/StorageType.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69919 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab324e2ad9767095e61da7059b788d67276c13be Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: otopi: Move to 4.1 branch otopi-1.6
by Code Review 12 Jan '17

12 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: otopi: Move to 4.1 branch otopi-1.6 ...................................................................... otopi: Move to 4.1 branch otopi-1.6 Change-Id: I08d2bc618ce10481e3c6744e6934198f0e8fc2f6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/otopi/otopi_standard.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08d2bc618ce10481e3c6744e6934198f0e8fc2f6 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: build: post otopi-1.6
by Code Review 12 Jan '17

12 Jan '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: build: post otopi-1.6 ...................................................................... build: post otopi-1.6 Change-Id: I13681c7eea8ae8a5d9e011cd3f360a5bad5a343b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13681c7eea8ae8a5d9e011cd3f360a5bad5a343b Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: automatically start vms with lease by their priority
by Code Review 12 Jan '17

12 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: automatically start vms with lease by their priority ...................................................................... core: automatically start vms with lease by their priority Before iterating the VMs that are both in Unknown status and configured with a lease and automatically try to start them, sort them according to their priority. Change-Id: I84c9e6af89ac4bf530f0124f928f707a8e310e32 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsOnHostComparator.java M packaging/dbscripts/vms_sp.sql 6 files changed, 80 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84c9e6af89ac4bf530f0124f928f707a8e310e32 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: scheduler: Log error if scheduled task cannot be submitted
by Code Review 12 Jan '17

12 Jan '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: scheduler: Log error if scheduled task cannot be submitted ...................................................................... scheduler: Log error if scheduled task cannot be submitted Logs error if scheduled task cannot be submitted (which means that the task is dropped), so administrators can easily find out that Quartz thread pool has been depleted and no other scheduled task will be executed until some already running thread is returned to the pool. Change-Id: I769a913d0208d61399ee60441f1c09e8cc03ada7 Bug-Url: https://bugzilla.redhat.com/1364791 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> (cherry picked from commit 88abff1447553607797d5df9d88c17e5e041a8ec) --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerThreadPool.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Martin Peřina: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I769a913d0208d61399ee60441f1c09e8cc03ada7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Make all files in workspace writable by user
by Code Review 12 Jan '17

12 Jan '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Make all files in workspace writable by user ...................................................................... Make all files in workspace writable by user Some files in workspace stays as read only after build Cleanup should change their mode to be able to clean with git plugin in next run on slave https://ovirt-jira.atlassian.net/browse/OVIRT-1022 Change-Id: I2342de088cd293476f967f07492e67bce45f4b96 Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/shell-scripts/mock_cleanup.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gil Shinar: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2342de088cd293476f967f07492e67bce45f4b96 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: he: prevent switching to ReinitializeFSM after VM migration.
by Code Review 12 Jan '17

12 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: he: prevent switching to ReinitializeFSM after VM migration. ...................................................................... he: prevent switching to ReinitializeFSM after VM migration. VDSM could return successful result upon migration completion or could return 'Virtual machine does not exist' if you are not lucky enough. Last case should be interpreted as a sign or successful migration completion too. Change-Id: I6a3ec6f3577e540c0e1526dd3219e6a7460f6b22 Bug-Url: https://bugzilla.redhat.com/1411319 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Denis Chaplygin: Verified Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a3ec6f3577e540c0e1526dd3219e6a7460f6b22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: build: otopi-1.6.0
by Code Review 12 Jan '17

12 Jan '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: build: otopi-1.6.0 ...................................................................... build: otopi-1.6.0 Change-Id: Idfb745923ebf3d6514e2e109d916eedc676f4456 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 28 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfb745923ebf3d6514e2e109d916eedc676f4456 Gerrit-PatchSet: 5 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: [maven-release-plugin] prepare for next development iteration
by Code Review 12 Jan '17

12 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I656ccf8a451752eeedd335dc78b29e1b26b3c8d8 --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/70066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I656ccf8a451752eeedd335dc78b29e1b26b3c8d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0