January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: Cold Merge: Fix audit message
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Cold Merge: Fix audit message ...................................................................... Cold Merge: Fix audit message Without this fix, the audit message is: Merging snapshots (<UNKNOWN> into <UNKNOWN>) of disk <UNKNOWN> With this fix, the audir message is: Merging snapshots (src-snap into dest-snap) of disk vm-disk Change-Id: I96bfc3d9b811c9b5a8712ca2d97512045877beb9 Bug-Url: https://bugzilla.redhat.com/1411111 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ColdMergeCommand.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/70039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96bfc3d9b811c9b5a8712ca2d97512045877beb9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Change use host label in new or manage storage domain
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Change use host label in new or manage storage domain ...................................................................... webadmin: Change use host label in new or manage storage domain Change-Id: I95aa9e741276813faca4439dde7c01656349fd50 Bug-Url: https://bugzilla.redhat.com/1306110 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95aa9e741276813faca4439dde7c01656349fd50 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Show popup upon import of images from external pro...
by Code Review 11 Jan '17

11 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Show popup upon import of images from external provider ...................................................................... webadmin: Show popup upon import of images from external provider Show a popup notifying on the start of the import and the status in the footer similar to when importing VMs/templates from an export domain Change-Id: I5a9c6d5fe1ee6f3a2970f4065c6eb52c88a353ff Bug-Url: https://bugzilla.redhat.com/1302562 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties 4 files changed, 34 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a9c6d5fe1ee6f3a2970f4065c6eb52c88a353ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tools: Link to CI updated
by Code Review 11 Jan '17

11 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: tools: Link to CI updated ...................................................................... tools: Link to CI updated Change-Id: Id2583c1f91ff88650858eab6e31541020a2289b1 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M automation/README.md 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Eyal Edri: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2583c1f91ff88650858eab6e31541020a2289b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Moved publishers section to job definition instead of projects
by Code Review 11 Jan '17

11 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Moved publishers section to job definition instead of projects ...................................................................... Moved publishers section to job definition instead of projects Before publishers were placed under project and didn't have effect. Moving it under job definition and changing with wrapper Change-Id: I5ede2f14ed58e9f2e3e4e61ea0138bdcbaff482f Signed-off-by: Pavel Zhukov <pzhukov(a)redhat.com> --- M jobs/confs/projects/ovirt/deploy_to_experimental.yaml M jobs/confs/yaml/templates/standard-stage.yaml 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Gil Shinar: Looks good to me Pavel Zhukov: Verified; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ede2f14ed58e9f2e3e4e61ea0138bdcbaff482f Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: install python-requests as a dependency
by Code Review 11 Jan '17

11 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: install python-requests as a dependency ...................................................................... install python-requests as a dependency Change-Id: I8a044d7ae0d3fe2764b35ff187d3b2f09759cd3c Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-nodejs/ovirt-engine-nodejs.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a044d7ae0d3fe2764b35ff187d3b2f09759cd3c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added build for fc24+ovirt4.0
by Code Review 11 Jan '17

11 Jan '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Added build for fc24+ovirt4.0 ...................................................................... Added build for fc24+ovirt4.0 Change-Id: Ia392716af356ff2911be7ddff83973fab7fae5a8 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Gil Shinar: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia392716af356ff2911be7ddff83973fab7fae5a8 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Added build for fc24+ovirt4.0
by Code Review 11 Jan '17

11 Jan '17

>From Gil Shinar <gshinar(a)redhat.com>: Gil Shinar has submitted this change and it was merged. Change subject: Added build for fc24+ovirt4.0 ...................................................................... Added build for fc24+ovirt4.0 Change-Id: Ic349beda3d0d3425c7642a07ae8b4c4059b3aaa6 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-nodejs/ovirt-engine-nodejs.yaml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Gil Shinar: Looks good to me, approved; Ready for merge Daniel Belenky: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70037 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic349beda3d0d3425c7642a07ae8b4c4059b3aaa6 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Shlomi Ben-David Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Add verify grade to Gerrit message
by Code Review 11 Jan '17

11 Jan '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Add verify grade to Gerrit message ...................................................................... Add verify grade to Gerrit message The message that Gerrit prints doesn't include the grade. Adding the grade beside the Gerrit message. Before: * Check Bug-Url:: WARN, no bug url/s found After: * Check Bug-Url:: WARN, no bug url/s found (-1) Change-Id: I57cb2ba4f47cfa50f19028190fb8e7d5abf67d03 Fixes: OVIRT-942 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_bug_url M hooks/lib/gerrit.py 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved Gil Shinar: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/68552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57cb2ba4f47cfa50f19028190fb8e7d5abf67d03 Gerrit-PatchSet: 6 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: text: remove redundant ACTION_TYPE_FAILED_NETWORK_ADDRESS_CA...
by Code Review 11 Jan '17

11 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: text: remove redundant ACTION_TYPE_FAILED_NETWORK_ADDRESS_CANNOT_BE_CHANGED ...................................................................... text: remove redundant ACTION_TYPE_FAILED_NETWORK_ADDRESS_CANNOT_BE_CHANGED Looks like the message isn't in use anymore since https://gerrit.ovirt.org/#/c/58538 . Change-Id: Id122733346665d6bd4b1b578db3faa929dc5a590 Bug-Url: https://bugzilla.redhat.com/1341024 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 0 insertions(+), 8 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/69806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id122733346665d6bd4b1b578db3faa929dc5a590 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0