January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant variable in RunVmValidator
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant variable in RunVmValidator ...................................................................... core: Remove redundant variable in RunVmValidator Change-Id: I6a259b86aba0ce2f55d09df894a22834ea2e7455 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69832 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a259b86aba0ce2f55d09df894a22834ea2e7455 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add list type in StorageDomainCommandBase
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add list type in StorageDomainCommandBase ...................................................................... core: Add list type in StorageDomainCommandBase The list created in getPermissionCheckSubjects() was created without a type causing a compilation warning even though the type can easily be specified Change-Id: I915d2c7bd36bab438417db7fb3a205fa2181ed73 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I915d2c7bd36bab438417db7fb3a205fa2181ed73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Limit access modifiers in RunVmValidator methods
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Limit access modifiers in RunVmValidator methods ...................................................................... core: Limit access modifiers in RunVmValidator methods Change-Id: I402ef667a1df551b6fba6d19cf1bc7a0c7b4b391 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 1 file changed, 18 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I402ef667a1df551b6fba6d19cf1bc7a0c7b4b391 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Limit access modifiers in StorageDomainCommandBase
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Limit access modifiers in StorageDomainCommandBase ...................................................................... core: Limit access modifiers in StorageDomainCommandBase Change-Id: I7d5f94b1ed25f06e063db65b75bc50cd5f433e5a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69853 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d5f94b1ed25f06e063db65b75bc50cd5f433e5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: move illegal Pass Discard logging to AddVmCommand
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: move illegal Pass Discard logging to AddVmCommand ...................................................................... backend: move illegal Pass Discard logging to AddVmCommand This patch moves the logging of disks with illegal Pass Discard value from AddVmFromTemplateCommand to AddVmCommand. Therefore, the log will not be shown only when creating a cloned vm from a template, but also when creating a thin vm from a template, when cloning a vm and when adding a vm from a snapshot. Change-Id: I84349befab5c9752825b0667a327edddae1d3819 Bug-Url: https://bugzilla.redhat.com/1410019 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/69546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84349befab5c9752825b0667a327edddae1d3819 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: log disks with illegal Pass Discard on RestoreFromS...
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: log disks with illegal Pass Discard on RestoreFromSnapshot ...................................................................... backend: log disks with illegal Pass Discard on RestoreFromSnapshot When restoring a snapshot, if at least one disk in that snapshot has an illegal Pass Discard value, an audit log will be shown to warn the user about it. Change-Id: Ib69e4da3d4f012d79ca4ae85a7e2d25a381dd4de Bug-Url: https://bugzilla.redhat.com/1410019 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreFromSnapshotCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/69548 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib69e4da3d4f012d79ca4ae85a7e2d25a381dd4de Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: fix logging of disks with illegal Pass Discard
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: fix logging of disks with illegal Pass Discard ...................................................................... backend: fix logging of disks with illegal Pass Discard Previously, when adding a cloned vm from a template, if at least one of the target vm's disks had an illegal Pass Discard value, the wrong disks' ids were logged (the source disks' ids instead of the target ones). This patch simplifies the way we log these disks by moving the log handling to BlockStorageDiscardFunctionalityHelper and fixes this bug, so that now the right ids are logged. Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d Bug-Url: https://bugzilla.redhat.com/1410017 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/BlockStorageDiscardFunctionalityHelper.java 4 files changed, 32 insertions(+), 35 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/69545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I566b36d3b7c25c4b8badfa59a9113fd3885eac4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: log disks with illegal Pass Discard on ImportVmTemp...
by Code Review 10 Jan '17

10 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: log disks with illegal Pass Discard on ImportVmTemplate ...................................................................... backend: log disks with illegal Pass Discard on ImportVmTemplate When importing a vm template from an export domain, if at least one disk from the imported template has an illegal Pass Discard value, an audit log will be shown to warn the user about it. Change-Id: I51a77c5e760d476fa3e541651ee1bc4800dc2952 Bug-Url: https://bugzilla.redhat.com/1410019 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/69547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51a77c5e760d476fa3e541651ee1bc4800dc2952 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Use RNG device from OVF if provided
by Code Review 10 Jan '17

10 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Use RNG device from OVF if provided ...................................................................... Use RNG device from OVF if provided When building vm.conf instead of stubbing the RNG device see if one exists in the OVF and use it instead. Change-Id: I0552e71ef6c058b1c778ea4ab5b733ee51869db5 Bug-Url: https://bugzilla.redhat.com/1368027 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 49efd2179dc3f973dda812833b3566bedbba8972) --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml 3 files changed, 47 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0552e71ef6c058b1c778ea4ab5b733ee51869db5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add quotaId and quotaName to Cloner
by Code Review 10 Jan '17

10 Jan '17

>From Alexander Wels <awels(a)redhat.com>: Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Add quotaId and quotaName to Cloner ...................................................................... webadmin: Add quotaId and quotaName to Cloner Updating the hosted engine VM via webadmin was failing due to the values for quotaId and quotaName not being cloned in the Cloner, which left the values set to null in the clone. Those values are not editable for the HE VM, leading to a failure during validation. This patch adds these values to the Cloner in order to prevent the validation failure. Change-Id: I45af78e71d1a624967c9427f3672746a3e0855b9 Bug-Url: https://bugzilla.redhat.com/1410431 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/69861 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45af78e71d1a624967c9427f3672746a3e0855b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0