January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: API: add a default timeout for engine API
by Code Review 10 Jan '17

10 Jan '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: API: add a default timeout for engine API ...................................................................... API: add a default timeout for engine API oVirt python SDK doesn't set a default timeout on the API so, if for any reason an API call got stuck, ovirt-hosted-engine-setup will wait forever. Change-Id: Id8fae577745b091c7831e255dfd72028be86a2a4 Bug-Url: https://bugzilla.redhat.com/1410501 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/engineapi.py 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Lev Veyde: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8fae577745b091c7831e255dfd72028be86a2a4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add import VM example
by Code Review 09 Jan '17

09 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add import VM example ...................................................................... Add import VM example Example on how to import an exported VM to a target storage domain Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> (cherry picked from commit b5c3abdf6cea990ad736066b16cf9ecd4a8341f6) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ImportVm.java 1 file changed, 102 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Add import VM example
by Code Review 09 Jan '17

09 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add import VM example ...................................................................... Add import VM example Example on how to import an exported VM to a target storage domain Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> (cherry picked from commit b5c3abdf6cea990ad736066b16cf9ecd4a8341f6) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ImportVm.java 1 file changed, 102 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Edit VM-Pool storage domains logic
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Edit VM-Pool storage domains logic ...................................................................... webadmin: Edit VM-Pool storage domains logic When searching for the right storage domain to display in the Edit VM Pool dialog, the condition checked was wrong in some cases. Instead of checking for the "imageParentId", the "templateImageId" is checked. Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329 Bug-Url: https://bugzilla.redhat.com/1392461 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/69851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99cde07885b1753f66bf213003b845f65fd2c329 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add import VM example
by Code Review 09 Jan '17

09 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add import VM example ...................................................................... Add import VM example Example on how to import an exported VM to a target storage domain Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ImportVm.java 1 file changed, 102 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Benny Zlotnik: Verified Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69773 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1706c4b0bb190b53e796f12967775640ceeb515 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add some more 4.1 to experimental
by Code Review 09 Jan '17

09 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Add some more 4.1 to experimental ...................................................................... Add some more 4.1 to experimental Change-Id: I70984627c80fbd44670b6fe04fadd04b5912bb1a Signed-off-by: Gil Shinar <gshinar(a)redhat.com> --- M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml M jobs/confs/projects/py2exe-py2.7/py2exe-py2.7.yaml M jobs/confs/projects/python-windows/python-windows.yaml M jobs/confs/projects/pywin32-py2.7/pywin32-py2.7.yaml 4 files changed, 23 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Gil Shinar: Verified; Looks good to me Daniel Belenky: Verified; Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70984627c80fbd44670b6fe04fadd04b5912bb1a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: [maven-release-plugin] prepare for next development iteration
by Code Review 09 Jan '17

09 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I7ee8718c8ab768063bb48b70b901ab338f0724f8 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ee8718c8ab768063bb48b70b901ab338f0724f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: [maven-release-plugin] prepare release 4.1.0.a1
by Code Review 09 Jan '17

09 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.1.0.a1 ...................................................................... [maven-release-plugin] prepare release 4.1.0.a1 Change-Id: I805fb64b9ba72979159487cb96ceab5bff12fde4 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M packaging/spec.el7.in M packaging/spec.fc24.in M packaging/spec.fc25.in M pom.xml M sdk/CHANGES.adoc M sdk/pom.xml M sdk/setup.py 8 files changed, 239 insertions(+), 1,683 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I805fb64b9ba72979159487cb96ceab5bff12fde4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Throw exception on VDS detach failure.
by Code Review 09 Jan '17

09 Jan '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Throw exception on VDS detach failure. ...................................................................... core: Throw exception on VDS detach failure. Once the engine encounters a SanlockException during force detach operation, the error that is being presented is an internal error log since VDSM does not set the failure in its return value. Instead, we should throw the exception and handle it in the bll commands. Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7 Bug-Url: https://bugzilla.redhat.com/1373181 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AttachStorageDomainToPoolCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DetachStorageDomainVDSCommand.java 2 files changed, 12 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/69800 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88a7ae1a0502e75dbe371b29558422726eca63b7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update VmManager caches when Hosted Engine VM is imported
by Code Review 09 Jan '17

09 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: Update VmManager caches when Hosted Engine VM is imported ...................................................................... core: Update VmManager caches when Hosted Engine VM is imported This calls VmManager.update once the Hosted Engine VM is properly imported. That should update the cached values, most importantly for this bug the vCPU count that is then used to compute the load percentage. Change-Id: Icf76ab5fdc66977dae7308f28a8dd290cda6689a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1390675 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Andrej Krejcir: Verified Arik Hadas: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf76ab5fdc66977dae7308f28a8dd290cda6689a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>

1 0