January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: api: DisksResource - initial size support on add disk
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: api: DisksResource - initial size support on add disk ...................................................................... api: DisksResource - initial size support on add disk When a sparse image disk is created on block domain it's created with initial allocation and being extended as needed by the spm (when it's plugged to a running vm). Speicifying inital size on the disk creation is useful when there's a need to create the disk with initial allocated different than the default value (1gb) for various reasons. An example would be the image upload, when the data is uploaded to disk extensions aren't supported - so the disk needs to be created with initial size that is big enough to contain all the uploaded data. Change-Id: I463c46a0072076fb0db8ba78a3b587ca34868771 Bug-Url: https://bugzilla.redhat.com/1400296 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69647 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I463c46a0072076fb0db8ba78a3b587ca34868771 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: no way to edit the migration bandwidth.
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: no way to edit the migration bandwidth. ...................................................................... webadmin: no way to edit the migration bandwidth. Regression introduced by https://gerrit.ovirt.org/#/c/60820/ Accidentally used the label editor which does not synch the values to the entity. Change-Id: Ia0c2fd6934961966196eb8fa333353fb5345fe9d Bug-Url: https://bugzilla.redhat.com/1410475 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> (cherry picked from commit c8ba4a0a17ca838ae814bd637dbd594a1696d74a) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c2fd6934961966196eb8fa333353fb5345fe9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: added isIpv6MigrationProperlyHandled to FeatureSupp...
by Code Review 08 Jan '17

08 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: backend: added isIpv6MigrationProperlyHandled to FeatureSupported ...................................................................... backend: added isIpv6MigrationProperlyHandled to FeatureSupported ipv6 migration/literal ip addressess are due to be introduced in 4.2, where vdsm properly handles/ensures ipv6 literal addresses to be used in qemu uri's. until then, a temporary solution that simply wraps ipv6 addresses in square brackets (in accordance with rfc2732) is planned to be placed on top of this patch. Change-Id: I7cafa52dca0b3364efc560319ed668a7a6122d90 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Leon Goldberg: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cafa52dca0b3364efc560319ed668a7a6122d90 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename and use literal ip in getMigrationNetworkIp
by Code Review 08 Jan '17

08 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: rename and use literal ip in getMigrationNetworkIp ...................................................................... core: rename and use literal ip in getMigrationNetworkIp all currently-supported versions of vdsm expect what rfc#2732 calls "literal ip addresses" as for the dstqemu parameter of the migrate verb. as part of the ipv6 migration effort, it is required to use ip addresses that are uri compatible, i.e. ip literals. the ipv4 variation requires no further modifications, however if there's no ipv4 and ipv6 is used, complying to rfc#2732 is necessary. the function was renamed to both indicate and explain the string modification. Change-Id: I5e3349f349e737b5198bb5100e76c8f25699e9bf Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Marcin Mirecki: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Leon Goldberg: Verified Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/68784 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e3349f349e737b5198bb5100e76c8f25699e9bf Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: fix typo ouf->of
by Code Review 08 Jan '17

08 Jan '17

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: engine: fix typo ouf->of ...................................................................... engine: fix typo ouf->of Change-Id: I9a421ededbbfc9ab3dc723432e9f5c37540e69bd Bug-Url: https://bugzilla.redhat.com/1410346 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Verified -- To view, visit https://gerrit.ovirt.org/69792 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a421ededbbfc9ab3dc723432e9f5c37540e69bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: fix typo ouf->of
by Code Review 08 Jan '17

08 Jan '17

>From Oved Ourfali <oourfali(a)redhat.com>: Oved Ourfali has submitted this change and it was merged. Change subject: engine: fix typo ouf->of ...................................................................... engine: fix typo ouf->of Change-Id: I9a421ededbbfc9ab3dc723432e9f5c37540e69bd Bug-Url: https://bugzilla.redhat.com/1410346 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69710 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a421ededbbfc9ab3dc723432e9f5c37540e69bd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: replace "" invalid mac address from input with null
by Code Review 08 Jan '17

08 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: replace "" invalid mac address from input with null ...................................................................... core: replace "" invalid mac address from input with null • fixed validations — "" is not valid mac address. • added code to replace "" with null, thus fixing invalid user input. Change-Id: I3d8e867a5a7e5b1ff003fd9264c6cd56cf9bf244 Bug-Url: https://bugzilla.redhat.com/1378045 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtilsTest.java 5 files changed, 62 insertions(+), 6 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/65298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d8e867a5a7e5b1ff003fd9264c6cd56cf9bf244 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix QemuimgCommitSupported definition
by Code Review 08 Jan '17

08 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Fix QemuimgCommitSupported definition ...................................................................... core: Fix QemuimgCommitSupported definition Support for QemuimgCommitSupported was enabled in 4.1, so for new installations we should put into db proper value, which will spare us to add value updates for upcoming versions. Change-Id: Ib09d1bbd075ea859b912f9c0b3e3e0e0c7866d25 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Objections: Ala Hino: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/69753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib09d1bbd075ea859b912f9c0b3e3e0e0c7866d25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix usage of fn_db_add_config_value_for_versions_up_to
by Code Review 08 Jan '17

08 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: Fix usage of fn_db_add_config_value_for_versions_up_to ...................................................................... core: Fix usage of fn_db_add_config_value_for_versions_up_to Fixes improper or unnecessary usage of fn_db_add_config_value_for_versions_up_to when defining versioned config values. Change-Id: I6c8bead7de0c4c98ccf4dcbf0c6598026646470f Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Verified Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69752 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c8bead7de0c4c98ccf4dcbf0c6598026646470f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adding 4.1 branch to ovirt-provider-ovn
by Code Review 08 Jan '17

08 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Adding 4.1 branch to ovirt-provider-ovn ...................................................................... Adding 4.1 branch to ovirt-provider-ovn Adding ovirt-provider-ovn-4.1 branch Change-Id: I6be9d027445cabeb3d5e23546ef5289c2ce63aca Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> --- M jobs/confs/projects/ovirt-provider-ovn/ovirt-provider-ovn.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me -- To view, visit https://gerrit.ovirt.org/69495 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6be9d027445cabeb3d5e23546ef5289c2ce63aca Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0