January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: do not copy lease_sd_id from vm to template
by Code Review 09 Jan '17

09 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: do not copy lease_sd_id from vm to template ...................................................................... core: do not copy lease_sd_id from vm to template When creating a template, do not copy the storage domain that the lease of the VM that the template is based on resides in to the template configuration. Change-Id: I59f86759c92e75887f6de2fc5ce476fc23f95b75 Bug-Url: https://bugzilla.redhat.com/1317429 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/69808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59f86759c92e75887f6de2fc5ce476fc23f95b75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: fixing jjb version for cockpit-ovirt
by Code Review 09 Jan '17

09 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: fixing jjb version for cockpit-ovirt ...................................................................... fixing jjb version for cockpit-ovirt cockpit-ovirt used wrongfuly the same version as the branch to create jobs in jjb YAML. this resulted in deploy-ovirt-experimental job not to run because it depends on the version to be in the format of 'X.Y', e.g 4.1 Change-Id: I06ce659b266ad99afbf8a1a7714cad46bb548b63 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/cockpit-ovirt/cockpit-ovirt.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06ce659b266ad99afbf8a1a7714cad46bb548b63 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: fix imgbased job names in jjb
by Code Review 09 Jan '17

09 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: fix imgbased job names in jjb ...................................................................... fix imgbased job names in jjb - imgbased fixed ( had ovirt-x.y instead of x.y ver ) - also fixed nightly publishers for 3.6,4.0 & 4.1 Change-Id: Ia1d4ec852304b1f479ac08f40ffcfcc5056f38b0 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/imgbased/imgbased.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml 4 files changed, 13 insertions(+), 9 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1d4ec852304b1f479ac08f40ffcfcc5056f38b0 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: set 'virtual-host' as the default tuned profile
by Code Review 09 Jan '17

09 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: set 'virtual-host' as the default tuned profile ...................................................................... set 'virtual-host' as the default tuned profile 'virtual-host' is the recommanded tuned profile for hypervisors. Same profile is recommanded for hyperconverged installation with gluster. So when there is no tuned profile defined at the cluster level then 'virtual-host' will be used if virt service is enabled. Note: If there is no profile defined at the cluster level and only gluster service is enabled not virt service then we will not set any tuned profile. Change-Id: Ifab913bb55dc4708fe33799459a83c6ea7d43ede Bug-Url: https://bugzilla.redhat.com/1380739 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M src/plugins/ovirt-host-deploy/tune/tuned.py 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/69489 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifab913bb55dc4708fe33799459a83c6ea7d43ede Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.6 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: Add 'virtual-host' tuned profile
by Code Review 09 Jan '17

09 Jan '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: gluster: Add 'virtual-host' tuned profile ...................................................................... gluster: Add 'virtual-host' tuned profile 'virtual-host' is the recommanded profile for HCI. So adding that profile to the list of available tuned profile. Also when gluster service disabled, we should reset the tuned profile to null. Change-Id: I6e1b0245c539cb7ee4eff488a055cf0922a8f654 Bug-Url: https://bugzilla.redhat.com/1380739 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/69558 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1b0245c539cb7ee4eff488a055cf0922a8f654 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix tooltip for brick status
by Code Review 09 Jan '17

09 Jan '17

>From Sahina Bose <sabose(a)redhat.com>: Sahina Bose has submitted this change and it was merged. Change subject: webadmin: Fix tooltip for brick status ...................................................................... webadmin: Fix tooltip for brick status Change-Id: Ia0c4b3b815b19f5bb3fa0768040d33d074482556 Bug-Url: https://bugzilla.redhat.com/1296786 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeBrickStatusColumn.java 1 file changed, 30 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/69482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0c4b3b815b19f5bb3fa0768040d33d074482556 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: dal: AuditLogMessages - missing message
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: dal: AuditLogMessages - missing message ...................................................................... dal: AuditLogMessages - missing message This patch adds the missing "USER_DEACTIVATE_STORAGE_DOMAIN_OVF_UPDATE_INCOMPLETE" message. Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f Bug-Url: https://bugzilla.redhat.com/1410105 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29e2eb1f8faef4c3c4884a6b1fa5a7601e33a19f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: ReduceSANStorageDomainDevices - free space validation
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: ReduceSANStorageDomainDevices - free space validation ...................................................................... core: ReduceSANStorageDomainDevices - free space validation The user can execute the ReduceSANStorageDomainDevices command with few devices to reduce from the domain. ReduceSANStorageDomainDevices executes RemoveDeviceFromSANStorageDomain for each of the devices, this command first moves the data from the device and then reduces the domain by removing the device from it. The data is moved using the lvm command pvmove, if there's not enough free space the operation will fail. When attempting to reduce multiple devices, we can't rely on the lvm verification for space (as lvm isn't aware that the user actually wants to reduce more than one device). This patch adds verification that there's enough free space for the operation - the command executes getVgInfo, sums the pe allocation of the devices for reduction and checks if the number of the free extents is sufficent. Change-Id: I80cfb95b61692ea83c3eaf2c490d20b17b2d0236 Bug-Url: https://bugzilla.redhat.com/1410115 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/BlockStorageDomainHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 53 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80cfb95b61692ea83c3eaf2c490d20b17b2d0236 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: getDeviceList.parseLun() - PE related fields
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: getDeviceList.parseLun() - PE related fields ...................................................................... core: getDeviceList.parseLun() - PE related fields This patch adds the PE related fields (pe_alloc_count and pe_count) to the parsing done in getDeviceList.parseLun() which is used by getVgInfo (currently reported by it). Change-Id: If1a06a83c0b4e48d1ecdb513eda336ba7dd2615f Bug-Url: https://bugzilla.redhat.com/1410115 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1a06a83c0b4e48d1ecdb513eda336ba7dd2615f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: common: adding pe allocation/pe count fields to LUN
by Code Review 09 Jan '17

09 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: common: adding pe allocation/pe count fields to LUN ...................................................................... common: adding pe allocation/pe count fields to LUN This patch adds the peCount/peAllocatedCount fields to the LUN entity. On the further patches on this series those fields will be populated by getVgInfo and will be used to determine if a storage domain has enough free space for requested reducation of the domain. Change-Id: I5362ae189ee050fc8b23149e9d19489c104df35d Bug-Url: https://bugzilla.redhat.com/1410115 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/LUNs.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/69607 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5362ae189ee050fc8b23149e9d19489c104df35d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0