February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Add support for custom global headers
by Code Review 24 Feb '17

24 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add support for custom global headers ...................................................................... Add support for custom global headers Currently there is no way to have global custom headers. This patch adds support for that. For example, if the caller, for whatever the reason, needs to send the 'My: myvalue' header to add a virtual machine, it can be done as follows: connection = Connection( url='https://engine/ovirt-engine/api', username='username@domain', password='password', ca_file='ca.pem', headers={'My', 'myvalue'}, ) # Get the reference to the service that manage the collection # of virtual machines and add virtual machine: vms_service = connection.system_service().vms_service() vms_service.add(types.Vm()) Change-Id: I465788b9a36167338eb21f0a4c8a40f3d2d570de Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py M sdk/tests/server.py M sdk/tests/test_vm_service.py 3 files changed, 49 insertions(+), 3 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I465788b9a36167338eb21f0a4c8a40f3d2d570de Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add support for custom headers and query parameters
by Code Review 24 Feb '17

24 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add support for custom headers and query parameters ...................................................................... Add support for custom headers and query parameters Currently there is no way to send to the server custom headers or query parameters. This patch adds support for that. For example, if the caller, for whatever the reason, needs to send the 'My: myvalue' header and the 'your=yourvalue' query parameter to the request to add a virtual machine, it can be done as follows: # Get the reference to the service that managse the collection # of virtual machines: vms_service = connection.system_service().vms_service() # Add the virtual machine, with a custom query and header vms_service.add( types.Vm(), headers={'my': 'value'}, query={'your': 'value'}, ) Change-Id: I27ca5f421215da1d920474445be08746248e4aed Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 5f518c2992d2c9f7bf29e62f4df6aae2be26d3f2) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/tests/server.py M sdk/tests/test_vm_service.py 3 files changed, 124 insertions(+), 14 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73041 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ca5f421215da1d920474445be08746248e4aed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Move updateBondOptions to SetupNetworksBondModel
by Code Review 24 Feb '17

24 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Move updateBondOptions to SetupNetworksBondModel ...................................................................... webadmin: Move updateBondOptions to SetupNetworksBondModel SetupNetworksBondPopupView.updateBondOptions() updates the value of customBondEditor manually via the view. Setting the value this way doesn't fire any event. Therefore, the model is not updated during initialization. Moving updateBondOptions() and its registration to SetupNetworksBondModel fixes this behavior. Change-Id: I6a16a729633c3e1bd90a47689dbaffa9d5e813d8 Bug-Url: https://bugzilla.redhat.com/1424813 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksBondModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 2 files changed, 19 insertions(+), 26 deletions(-) Approvals: Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a16a729633c3e1bd90a47689dbaffa9d5e813d8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-release[master]: automation: fix repos for fc25
by Code Review 24 Feb '17

24 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: fix repos for fc25 ...................................................................... automation: fix repos for fc25 Change-Id: I426cbbd6b1e0fda9507ec51928b6c6193f7945a8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- R automation/check-patch.repos.fc25 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/73031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I426cbbd6b1e0fda9507ec51928b6c6193f7945a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: test: adding he and hc suites to ovirt-system-tests_manual
by Code Review 24 Feb '17

24 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: test: adding he and hc suites to ovirt-system-tests_manual ...................................................................... test: adding he and hc suites to ovirt-system-tests_manual Change-Id: I261dded5aed2c0f63ff6510d35fee3c2ab696702 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Simone Tiraboschi: Verified; Ready for review Jenkins CI: Passed CI tests Rafael Martins: Looks good to me -- To view, visit https://gerrit.ovirt.org/73032 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I261dded5aed2c0f63ff6510d35fee3c2ab696702 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add support for custom headers and query parameters
by Code Review 24 Feb '17

24 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add support for custom headers and query parameters ...................................................................... Add support for custom headers and query parameters Currently there is no way to send to the server custom headers or query parameters. This patch adds support for that. For example, if the caller, for whatever the reason, needs to send the 'My: myvalue' header and the 'your=yourvalue' query parameter to the request to add a virtual machine, it can be done as follows: # Get the reference to the service that managse the collection # of virtual machines: vms_service = connection.system_service().vms_service() # Add the virtual machine, with a custom query and header vms_service.add( types.Vm(), headers={'my': 'value'}, query={'your': 'value'}, ) Change-Id: I27ca5f421215da1d920474445be08746248e4aed Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/tests/server.py M sdk/tests/test_vm_service.py 3 files changed, 124 insertions(+), 14 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ca5f421215da1d920474445be08746248e4aed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: engine: Add timeout to communication with network provider
by Code Review 24 Feb '17

24 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add timeout to communication with network provider ...................................................................... engine: Add timeout to communication with network provider Previously there was no explicit timeout for communication to external network provider. This way there was a long timeout applied to the communication. Since some objects are locked during the communication, some objects was locked for a long period of time if the external network provided did not respond. An explicit timeout for the communication is added, to avoid locking for a long period of time. The library com.woorea.openstack is used for the communication with external network providers. The version of this library is increased to 3.1.2, which introduces the possibility to add the timeout for communication. Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Bug-Url: https://bugzilla.redhat.com/1380356 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 5f7c65771a412e5952d693de0bddffea1a59244d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M ovirt-engine.spec.in M pom.xml 4 files changed, 42 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72992 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: gluster: add arbiter flag for bricks
by Code Review 24 Feb '17

24 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: gluster: add arbiter flag for bricks ...................................................................... gluster: add arbiter flag for bricks While creating a arbiter volume or adding bricks to arbiter volume, every third brick should be marked as arbiter brick Change-Id: I7161ebca6e262a7b2606817a940b399461fd8460 Bug-Url: https://bugzilla.redhat.com/1417101 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> (cherry picked from commit e8a11105db1983019c8b8dd97758c736ed2383dc) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/73027 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7161ebca6e262a7b2606817a940b399461fd8460 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Warn on add brick for HC volume
by Code Review 24 Feb '17

24 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Warn on add brick for HC volume ...................................................................... webadmin: Warn on add brick for HC volume Show a warning about recommendation of adding new volumes to scale out an HC cluster Change-Id: I1534ccbaab95dc386ba373877a7a0c6fb9de0f05 Bug-Url: https://bugzilla.redhat.com/1417582 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 59 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified; Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/73021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1534ccbaab95dc386ba373877a7a0c6fb9de0f05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Add timeout to communication with network provider
by Code Review 24 Feb '17

24 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Add timeout to communication with network provider ...................................................................... engine: Add timeout to communication with network provider Previously there was no explicit timeout for communication to external network provider. This way there was a long timeout applied to the communication. Since some objects are locked during the communication, some objects was locked for a long period of time if the external network provided did not respond. An explicit timeout for the communication is added, to avoid locking for a long period of time. The library com.woorea.openstack is used for the communication with external network providers. The version of this library is increased to 3.1.2, which introduces the possibility to add the timeout for communication. Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Bug-Url: https://bugzilla.redhat.com/1380356 Signed-off-by: Dominik Holler <dholler(a)redhat.com> (cherry picked from commit 5f7c65771a412e5952d693de0bddffea1a59244d) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M ovirt-engine.spec.in M pom.xml 4 files changed, 42 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Dominik Holler: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0