February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: he_restore: avoid failing with other VMs disks
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: he_restore: avoid failing with other VMs disks ...................................................................... he_restore: avoid failing with other VMs disks For migration or disaster recovery purposes we let the user filter out the hosted-engine storage domain and the engine VM to redeploy from a backup on a different hosted-engine env. Due to another bug the user could create a floating disk on the hosted-engine storage domain and then connect it to the engine VM. In this case we should still remove the hosted-engine storage domain filtering out other VMs disks as well without failing. Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Bug-Url: https://bugzilla.redhat.com/1425893 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Add a Guid constructor to ImportHostedEngineStorageDom...
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Add a Guid constructor to ImportHostedEngineStorageDomain command ...................................................................... core: Add a Guid constructor to ImportHostedEngineStorageDomain command This constructor is used by the Backend.compensate in case the engine is restarted during the import. Change-Id: I63ab881827b1cdea2df9af6fcc81214b13e3cdfd Bug-Url: https://bugzilla.redhat.com/1425900 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 6649a5d1b25d334235a5de19d68b53d3aa72ddab) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63ab881827b1cdea2df9af6fcc81214b13e3cdfd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: he_restore: updating foreign key removing HE hosts
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: he_restore: updating foreign key removing HE hosts ...................................................................... he_restore: updating foreign key removing HE hosts For migration or disaster recovery purposes we let the user filter out the hosted-engine hosts to redeploy from a backup on a different hosted-engine env. In order to be sure that all the hosted-engine runs with a local up-do-date configuration we have to remove them from the engine DB asking to the user to redeploy them to be sure that they point to the right hosted-engine storage domain. In order to remove them at restore time avoiding foreign key errors, we need to update all the existing VMs related to these hosts. Set status=Down, exit_reason=AdminShutdown, exit_status=Normal, run_on_vds=NULL, migrating_to_vds=NULL for all the VM that were running on the hosted-engine hosts we are filtering out at restore time. Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Bug-Url: https://bugzilla.redhat.com/1425890 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85a6fcd18005393e69ed319e7b56709e7adc5b9b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add timeout to communication with network provider
by Code Review 23 Feb '17

23 Feb '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: Add timeout to communication with network provider ...................................................................... engine: Add timeout to communication with network provider Previously there was no explicit timeout for communication to external network provider. This way there was a long timeout applied to the communication. Since some objects are locked during the communication, some objects was locked for a long period of time if the external network provided did not respond. An explicit timeout for the communication is added, to avoid locking for a long period of time. The library com.woorea.openstack is used for the communication with external network providers. The version of this library is increased to 3.1.2, which introduces the possibility to add the timeout for communication. Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Bug-Url: https://bugzilla.redhat.com/1380356 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M ovirt-engine.spec.in M pom.xml 4 files changed, 42 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Dominik Holler: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2eb1380273c811bf659ac067e6ebb65cbf31b99 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: he_restore: avoid failing with other VM disks
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: he_restore: avoid failing with other VM disks ...................................................................... he_restore: avoid failing with other VM disks For migration or disaster recovery purposes we let the user filter out the hosted-engine storage domain and the engine VM to redeploy from a backup on a different hosted-engine env. Due to another bug the user could create a floating disk on the hosted-engine storage domain and then connect it to the engine VM. In this case we should still remove the hosted-engine storage domain filtering out other VMs disks as well without failing. Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Bug-Url: https://bugzilla.redhat.com/1416459 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: he_restore: avoid failing on other VMs disks
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: he_restore: avoid failing on other VMs disks ...................................................................... he_restore: avoid failing on other VMs disks For migration or disaster recovery purposes we let the user filter out the hosted-engine storage domain and the engine VM to redeploy from a backup on a different hosted-engine env. Due to another bug the user could create a floating disk on the hosted-engine storage domain and then connect it to the engine VM. In this case we should still remove the hosted-engine storage domain filtering out other VMs disks as well without failing. Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Bug-Url: https://bugzilla.redhat.com/1416459 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72801 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2be23b172ea592f9b6be08477fad0f4bf29a30ad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: hosted-engine: add a DB cleaner utility
by Code Review 23 Feb '17

23 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: hosted-engine: add a DB cleaner utility ...................................................................... hosted-engine: add a DB cleaner utility Hosted-engine auto-import procedure is not going to work if the engine DB already contains hosted-engine entities and, on the other side, they cannot be removed from the engine to avoid breaking a working environment. This was preventing the user from migration an hosted-engine env from one storage device to another via backup/restore. Change-Id: Id61ae0b05a75018ded532d7a0c38c15b4b885803 Bug-Url: https://bugzilla.redhat.com/1422470 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/bin/engine-backup.sh.in A packaging/setup/dbutils/hecleaner.sh A packaging/setup/dbutils/hecleaner_sp.sql A packaging/setup/dbutils/hecleaner_sp_drop.sql 4 files changed, 225 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/72804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id61ae0b05a75018ded532d7a0c38c15b4b885803 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused VM#balloonEnabled
by Code Review 23 Feb '17

23 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused VM#balloonEnabled ...................................................................... core: remove unused VM#balloonEnabled Change-Id: Ie50709922284264990b203e743429f39ae5fce21 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java 4 files changed, 11 insertions(+), 45 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/72911 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie50709922284264990b203e743429f39ae5fce21 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: Fix installing logutils.jar
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Fix installing logutils.jar ...................................................................... core: Fix installing logutils.jar Fix installing logutils.jar on downstream build when using minimead.py which replaces pom version with specific version of the build. Change-Id: I2099186df489841b95d1a086a05f03e9bb525d9d Bug-Url: https://bugzilla.redhat.com/1408193 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72885 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2099186df489841b95d1a086a05f03e9bb525d9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: he: Ensures that there will be no spm_id=1 host after restore.
by Code Review 23 Feb '17

23 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: he: Ensures that there will be no spm_id=1 host after restore. ...................................................................... he: Ensures that there will be no spm_id=1 host after restore. Restoring HE environment from backup could lead into two hosts, thinking they have spm_id==1 at same moment. One of those hosts will be newly deployed HE host with default spm_id==1, another one host will be old host from the database. This patch changes spm_id of the host with value '1' to some unused value. Change-Id: Ib7b10f57a9350adf3da73580c4a69e5ce317502e Bug-Url: https://bugzilla.redhat.com/1417518 Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> (cherry picked from commit b440a7e46bba47e43e16305236c3c3207345139e) --- M packaging/setup/dbutils/hecleaner_sp.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/72923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7b10f57a9350adf3da73580c4a69e5ce317502e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0