February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: Fix response for getting configuration from shared storage
by Code Review 07 Feb '17

07 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: Fix response for getting configuration from shared storage ...................................................................... Fix response for getting configuration from shared storage This patch formats the response after getting configuration from shared storage. The previous format missed the key that the user was trying to get. Change-Id: Ib8d154bbe9a75251145afec76f44da0c0b32e5ed Bug-Id: https://bugzilla.redhat.com/1419623 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M src/ovirt_hosted_engine_setup/get_shared_config.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/71769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8d154bbe9a75251145afec76f44da0c0b32e5ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: v2v- remove "VirtIO Drivers" drop down for KVM
by Code Review 07 Feb '17

07 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: v2v- remove "VirtIO Drivers" drop down for KVM ...................................................................... webadmin: v2v- remove "VirtIO Drivers" drop down for KVM Since You can't inject virtio WIN drivers to VMs with WIN OS imported from KVM (not supported), then we remove the "virtio drivers" drop down menu from v2v import dialog (2nd dialog). We also avoid displaying the following warning message in v2v dialog for KVM import: "You have selected windows OS and have not selected VirtIO drivers. This may cause the system not to boot up". Change-Id: Ia9d4c46d27691f5e3fef3259529f80d9de86a8aa Bug-Url: https://bugzilla.redhat.com/1374589 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java 1 file changed, 32 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/71770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9d4c46d27691f5e3fef3259529f80d9de86a8aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Add console device
by Code Review 07 Feb '17

07 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Add console device ...................................................................... core: Add console device Add console device when importing hosted engine VM. Previously the device was ignored, not registered in the engine and not written to the ovf which caused the console commands to fail. Change-Id: Ia1cddaa7396f1abb160a49e79afe3e17b608dddc Bug-Url: https://bugzilla.redhat.com/1364132 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> (cherry picked from commit 173d2b1) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommandTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 4 files changed, 56 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/71757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1cddaa7396f1abb160a49e79afe3e17b608dddc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: overcome VDSM recovery in PollVDSCommand
by Code Review 07 Feb '17

07 Feb '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: overcome VDSM recovery in PollVDSCommand ...................................................................... engine: overcome VDSM recovery in PollVDSCommand Refer to VDSM recovery response as a negative poll attempt. Change-Id: Ice4c1fb7359d6516916f0e360bb62de388974064 Bug-Url: https://bugzilla.redhat.com/1415471 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetAmountOfMemoryVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetNumberOfCpusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java 6 files changed, 23 insertions(+), 12 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice4c1fb7359d6516916f0e360bb62de388974064 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: replace javax.ejb.Singleton with javax.inject.Singleton
by Code Review 07 Feb '17

07 Feb '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: replace javax.ejb.Singleton with javax.inject.Singleton ...................................................................... core: replace javax.ejb.Singleton with javax.inject.Singleton Change-Id: Idf5ba453840bfb0e9c0f52ea5757b577e77f9ca7 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71511 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf5ba453840bfb0e9c0f52ea5757b577e77f9ca7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: packaging: spec: re-add vdsm-hook-vhostmd
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: re-add vdsm-hook-vhostmd ...................................................................... packaging: spec: re-add vdsm-hook-vhostmd for some reason it was disabled on el7 introducing a difference with fedora version. Being vhostmd available in el7 there's no reason for keeping this difference. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1419105 Change-Id: Iedfa1ffbbcce1b6e13407ccd6108fac43ab10b40 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> (cherry picked from commit f8ae3e3af90d5f670476604f5c8137babf21a2be) --- M ovirt-release41.spec.in 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfa1ffbbcce1b6e13407ccd6108fac43ab10b40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: epel: Exclude collectd
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: epel: Exclude collectd ...................................................................... epel: Exclude collectd We want it from opstools sig repo. Change-Id: Iff8e44edb40751f9e1164306e6fc6ae8adcdfe3a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M mock_configs/epel-7-x86_64.cfg M mock_configs/epel-7-x86_64_proxied.cfg 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff8e44edb40751f9e1164306e6fc6ae8adcdfe3a Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-4.1]: Add gdeploy to node
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: Add gdeploy to node ...................................................................... Add gdeploy to node Enable copr repo providing gdeploy and require it in oVirt Node Next Generation Change-Id: I749c42a6c8bc89c2f7dc4248c3a71cc413fad730 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1411640 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.repos.el7 M automation/check-patch.repos.fc24 M ovirt-el7-ppc64le-deps.repo.in M ovirt-el7-x86_64-deps.repo.in M ovirt-f24-deps.repo.in M ovirt-release41.spec.in 6 files changed, 39 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71632 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I749c42a6c8bc89c2f7dc4248c3a71cc413fad730 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: packaging: spec: re-add vdsm-hook-vhostmd
by Code Review 07 Feb '17

07 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: re-add vdsm-hook-vhostmd ...................................................................... packaging: spec: re-add vdsm-hook-vhostmd for some reason it was disabled on el7 introducing a difference with fedora version. Being vhostmd available in el7 there's no reason for keeping this difference. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1419105 Change-Id: Iedfa1ffbbcce1b6e13407ccd6108fac43ab10b40 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71615 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfa1ffbbcce1b6e13407ccd6108fac43ab10b40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: Pools without VMs are hidden
by Code Review 07 Feb '17

07 Feb '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Pools without VMs are hidden ...................................................................... userportal: Pools without VMs are hidden Pools without any VMs are filtered out to prevent NPEs. Change-Id: I6401299c50b784b2a0f36fd194efa932a0917021 Bug-Url: https://bugzilla.redhat.com/1378331 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 35 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6401299c50b784b2a0f36fd194efa932a0917021 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0