February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: backend: add "shared" lock for the AddVmTemplateCommand
by Code Review 01 Feb '17

01 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: add "shared" lock for the AddVmTemplateCommand ...................................................................... backend: add "shared" lock for the AddVmTemplateCommand On AddVmTemplateCommand we added a lock ("shared") for the VM. Change-Id: If4822f781b2c426c9fc26ed9af6e52605065497b Bug-Url: https://bugzilla.redhat.com/1364137 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 14 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4822f781b2c426c9fc26ed9af6e52605065497b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove redundant private ctor modifier in StepEnum
by Code Review 01 Feb '17

01 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remove redundant private ctor modifier in StepEnum ...................................................................... core: Remove redundant private ctor modifier in StepEnum Declaring an enum ctor as private is redundant as they are always private Change-Id: I60151b3c77b6ec3eb4e83391792ea382435a3276 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified Benny Zlotnik: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71503 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60151b3c77b6ec3eb4e83391792ea382435a3276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: @Inject DirectoryUtils' DAOs
by Code Review 01 Feb '17

01 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: @Inject DirectoryUtils' DAOs ...................................................................... core: @Inject DirectoryUtils' DAOs Change-Id: I357b87e2fd513ecd44ea237de594a5c6d075cbc7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71411 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I357b87e2fd513ecd44ea237de594a5c6d075cbc7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Make DirectoryUtils injectable
by Code Review 01 Feb '17

01 Feb '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Make DirectoryUtils injectable ...................................................................... core: Make DirectoryUtils injectable DirectoryUtils is a stateless helper class, making it a classic candidate to be injected, so it's usages can be more easily tested. Change-Id: Ib3f080f5effbf251721bf4db9d76efff6c472a47 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDirectoryUserByPrincipalQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryGroupsForUserQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDirectoryUserByIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java 8 files changed, 47 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, but someone else must approve Objections: Martin Peřina: I would prefer that you didn't submit this -- To view, visit https://gerrit.ovirt.org/71410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3f080f5effbf251721bf4db9d76efff6c472a47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: Add next run field messages
by Code Review 01 Feb '17

01 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Add next run field messages ...................................................................... Add next run field messages On next run warning we display code fields such as 'minAllocatedMem' instead of 'Minimum Allocated Memory' Change-Id: If876d4f2dfa74de62b5b75e7949d3b1e3ced38c2 Bug-Url: https://bugzilla.redhat.com/1347356 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java A frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/NextRunFieldMessages.java A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/NextRunFieldMessages.properties 3 files changed, 28 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If876d4f2dfa74de62b5b75e7949d3b1e3ced38c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: avoid failing on "no free macs" when no re-assign
by Code Review 01 Feb '17

01 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: avoid failing on "no free macs" when no re-assign ...................................................................... engine: avoid failing on "no free macs" when no re-assign Avoid failing on MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES when no re-assign was requested. Change-Id: Ia19513f5c11fc03fb80d75259a91749e71fc930e Bug-Url: https://bugzilla.redhat.com/1390575 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtilsTest.java 4 files changed, 72 insertions(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71196 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia19513f5c11fc03fb80d75259a91749e71fc930e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: replace "" invalid mac address from input with null
by Code Review 01 Feb '17

01 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: replace "" invalid mac address from input with null ...................................................................... core: replace "" invalid mac address from input with null • fixed validations — "" is not valid mac address. • added code to replace "" with null, thus fixing invalid user input. Change-Id: I3d8e867a5a7e5b1ff003fd9264c6cd56cf9bf244 Bug-Url: https://bugzilla.redhat.com/1390575 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtilsTest.java 5 files changed, 62 insertions(+), 6 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d8e867a5a7e5b1ff003fd9264c6cd56cf9bf244 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-appliance: add stable builders
by Code Review 01 Feb '17

01 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-appliance: add stable builders ...................................................................... ovirt-appliance: add stable builders Change-Id: I7c8c634819979c00f2f221b1f3f18382e60bee2a Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-appliance/ovirt-appliance.yaml 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71496 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8c634819979c00f2f221b1f3f18382e60bee2a Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live-4.1.0
by Code Review 01 Feb '17

01 Feb '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: build: ovirt-live-4.1.0 ...................................................................... build: ovirt-live-4.1.0 Change-Id: I7746412d7213c775dc72e2b5907e980af227e475 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71497 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7746412d7213c775dc72e2b5907e980af227e475 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Template sorting improved
by Code Review 01 Feb '17

01 Feb '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: core: Template sorting improved ...................................................................... core: Template sorting improved * Sorting by Name column means: sort by name, version name, version number. Version name value 'base version' is interpreted as NULL. * Sorting by Version column is completely disabled. Change-Id: If6a6fc1ad0aa3a75eae925d2cc480593b881c7d0 Bug-Url: https://bugzilla.redhat.com/1273825 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Jakub Niedermertl: Verified Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70895 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6a6fc1ad0aa3a75eae925d2cc480593b881c7d0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0